[ZBXNEXT-1196] Redesign of install form Created: 2012 Apr 24  Updated: 2012 May 07  Resolved: 2012 May 07

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request Priority: Minor
Reporter: Toms (Inactive) Assignee: Toms (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File setup_1.png    

 Comments   
Comment by Oleksii Zagorskyi [ 2012 Apr 25 ]

(1) [usability] The step 7 in case of success config file creation, could be more informative. I mean:
The text "Configuration file: OK" replace to "Configuration file "/full/path/to/the/file" created: OK"

The same for fail result:
"Configuration file: Fail" replace to "Configuration file "/full/path/to/the/file" created: Fail"

<Toms> RESOLVED in r27118

<zalex> Tested, CLOSED

Comment by Oleksii Zagorskyi [ 2012 Apr 25 ]

(2) [usability] Rename the button "Save configuration file" to "Download configuration file"
then change the description above of the button.
Now, the "save" action to download a file it's not intuitively clear, IMO.

<Toms> RESOLVED in r27118

<zalex> Tested, CLOSED

Comment by Toms (Inactive) [ 2012 Apr 26 ]

Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBXNEXT-1196

Comment by Alexey Fukalov [ 2012 Apr 26 ]

(3)
On 3rd step buttons are misplaced in Chrome, see "setup_1.png".
In Firefox first slide buttons are misaligned too.

<zalex> I see the same to 1st step in Opera.

<Toms> RESOLVED in r27188

<zalex> 1st step in Opera -> CLOSED. Chrome (Iron 17.0) on 3rd step worked ok for me even before r27188.

Comment by Oleksii Zagorskyi [ 2012 Apr 26 ]

(4)
On 4th step the "Database type" drop-down contains only MySQL and PostgreSQL.
Is this ok?

<richlv> it should depend on the db support that is available in your php installation - you should see only supported types.
we could make an improvement and show all types, but the unavailable ones would be disabled in the dropdown (couldn't be chosen)

<zalex> Yes, after installation php5-sqlite package, SQLite3 appeared in that drop-down. Thanks.
I'm not sure is it worth to "coding" for this improvement
Feel free to close this comment. But probably would be better to add a small note here (step 4):
http://www.zabbix.com/documentation/2.0/manual/installation/install#installing_zabbix_web_interface

<zalex> Actually list of supported databases visible at the 3rd step in the "PHP databases support" value.

<Toms> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 26 ]

(5)
On requirements step:
remove total Fail/Ok
add scroll for requirements
retry button is not scrollable

Remove second step.

On first step image instead of text.

Increase version font size to 16 and remove "v".

Add copyright text with link to license to footer.

Change first step name from "Introduction" to "Welcome".

<Toms> RESOLVED in r27188

<Vedmak> CLOSED

Comment by richlv [ 2012 Apr 26 ]

i'd suggest for the image on the 1st step not to have any text on it, and it should take ~ 2/3 of the area, leaving the rest for normal text

Comment by Oleksii Zagorskyi [ 2012 Apr 28 ]

who is the author of that picture?

<Toms> It is temp picture

<zalex> the picture in trunk r27285 is very similar
Interesting what it means, why exactly that picture?

Comment by Oleksii Zagorskyi [ 2012 Apr 28 ]

(6) ?sid=cc77447aba07b498 should not be added to the "www.zabbix.com" and "GPL v2" links even if i logged in and opened "setup.php" page
REOPENED

<Toms> RESOLVED in r27227

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 May 02 ]

(7)
In ie8 only part of image is shown.

<Toms> RESOLVED in r27227

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 May 02 ]

(8)
In default.css for div.setup_wizard:

  • colors should be with capital letters "#608cb6" => "#608CB6"
  • there should be a space before opening bracket "div.setup_wizard div.left_menu li{"
  • styles like "margin: 1px 0 0 0;" can be shortened to "margin: 1px 0 0;"

I did that in my previous commit but it was overwritten

<Toms> RESOLVED in r27227

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 May 03 ]

(9)
I reformatted css in rev. 27239. if everything ok, can be merged.

Comment by Toms (Inactive) [ 2012 May 07 ]

Fixed in 2.0.0 r27285

Comment by Oleksii Zagorskyi [ 2012 May 07 ]

(10) Trunk r27285. In the Opera, Iron 17, Firefox 10, and I suppose other browsers all buttons at all steps are are misplaced, the same as (3)
REOPENED

<Toms> Opera 11.62, Firefox 12.0 doesn't show this behavior. Iron in not supported by Zabbix didn't checked.

<zalex> Toms, sorry, my bad. I'm updating trunk fronted using custom script where the revision and current timestamp are added to a defines line.
define('ZABBIX_VERSION', '2.0.0rc4-27285 last updated: Mon May 7 09:43:38 EEST 2012 ');
It was a problem.
That's why I've reopened. Sorry again.
btw, Iron it the same as Chromium (Chrom).
CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 May 07 ]

(11) I've reached the step where the configuration file is created, but it couldn't be created, due to the lack of permissions. That's ok, but it also displays a "Config file DB server is not equal to wizard input." error above. What in the world does that mean?

Btw: "Configuration file "/opt/lampp/htdocs/zabbix/trunk/frontends/php/conf/zabbix.conf.php" created: Fail" could probably be replaced with something more human. Like "Could not create the configuration file".

<Toms> Changed according to (1)

<pavels> What about the weird error message?

<Toms> Looks OK for me. I think these kind of things should be discussed with Rich.

<Vedmak> About error message, you probably tried to install Zabbix with existing configuration file, but as setup didn't have permissions to write it, you got situation where you have old config file which differ with values you entered during setup, so it tells you that "DB server" differs.

<pavels> That is should just say "Cannot overwrite the current configuration file" or something. The current message is extremely unclear.

<pavels> After some discussion we've decided to remove that message, and to add a message if the configuration file exists. Something like "The current configuration file will be overwritten". It should also be highlighted somehow, maybe bold?

<Toms> Will be improved in ZBX-4953





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-1181] Redesign Configuration -> Hosts -> Mass update Created: 2012 Apr 11  Updated: 2017 May 31  Resolved: 2013 Jun 28

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: API (A), Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0, 2.1.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: hostmassupdate, hosts
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-4862 Error when trying to add/remove addit... Closed

 Comments   
Comment by richlv [ 2012 Apr 16 ]

hmm. does the closing of this issue mean that host mass update form is fully redesigned ?
also, if this issue is duplicated by another, then it can not be closed as a duplicate itself, reopening

Comment by Eduards Samersovs (Inactive) [ 2012 Apr 20 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1181

Comment by Alexey Fukalov [ 2012 Apr 20 ]

(1)
Please review my changes in rev. 26996. If everything is ok, can be merged.

<Eduard> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Apr 20 ]

trunk r.26998 version 2.0.0 rc3

Comment by richlv [ 2012 Jul 10 ]

(2) apparently, mass update form was also changed functionally (for example, template linkage part) - but this hasn't been documented anywhere at all.

all functional changes to that form should be documented here (including info on what exactly changed)

Comment by Eduards Samersovs (Inactive) [ 2013 Jun 26 ]

During last year in this form was some changes and now can say that this form looks pretty good.

Comment by Oleksii Zagorskyi [ 2013 Jun 28 ]

Resolution looks a bit scary, I fixed it as I see it logical.

It's sad that several sub-issues again were ignored and not closed.





[ZBXNEXT-1157] remote Command via right click on menu Created: 2012 Mar 20  Updated: 2012 Mar 20  Resolved: 2012 Mar 20

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 1.8.9
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Minor
Reporter: Gavin Balaam Assignee: Alexei Vladishev
Resolution: Fixed Votes: 0
Labels: maps, remotecommands
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

I'd like to be able to run remote commands via a right click option.

Currently the only options are those that are run local to the zabbix server.

The reason being that we have a scenario that causes an alert, and we have remote commands that we can run to resolve the issue, but we are not yet ready for that to be fully automated.



 Comments   
Comment by richlv [ 2012 Mar 20 ]

probably not remote commands, but global/frontend scripts;
and probably left click, not right click

anyway, it will be possible to run frontend scripts either on the agent or server in 2.0





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-1126] Redesign Script execution Created: 2012 Feb 17  Updated: 2018 Oct 26  Resolved: 2012 Apr 18

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Trivial
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Alexander Vladishev [ 2012 Apr 17 ]

(1) Incorrect link to parent trigger prototype in a trigger prototype form

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 17 ]

(2) Sorting doesn't work by "Commands" in Administration->Scripts
Sorting by field "command" not allowed. [CScript.get -> zbx_db_sorting]
Invalid argument supplied for foreach() [scripts.php:260]
array_slice() expects parameter 1 to be array, boolean given [include/func.inc.php:1510]
Invalid argument supplied for foreach() [include/views/administration.script.list.php:46]

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 17 ]

(3) Script errors from Zabbix server should be displayed in the header

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Apr 17 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1126

Comment by Alexander Vladishev [ 2012 Apr 17 ]

Successfully tested!

Comment by Eduards Samersovs (Inactive) [ 2012 Apr 17 ]

trunk r.26914 version 2.0 rc3

Comment by Oleksii Zagorskyi [ 2012 Apr 18 ]

Reopened to set correct Fix version/s

Comment by Oleksii Zagorskyi [ 2012 Apr 18 ]

hmm, 2.0.0rc3 is not available already.
left 2.0.0 as it was.
Closed again

Comment by richlv [ 2018 Oct 26 ]

This issue has been used to alter the configuration wizard, which is not reflected in the issue, commit message or elsewhere.
Reversing that change tracked at ZBXNEXT-4829 .





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-1113] Redesign Configuration->Discovery Rules Created: 2012 Feb 10  Updated: 2017 May 31  Resolved: 2012 Feb 17

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 17 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1113

Comment by Eduards Samersovs (Inactive) [ 2012 Feb 20 ]

trunk r.25463 version pre-1.9.10





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-914] Redesign Administration->DM Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Apr 12

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: distributed
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File administration-authentication.png     PNG File dm-node.png    
Issue Links:
Duplicate
duplicates ZBX-3734 removing last link in map properties ... Closed
is duplicated by ZBX-3266 unnecessary rows in mass update forms Closed

 Description   

Edit form



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(1) When creating a new node, the "Type" select doesn't have the "Master" option.

<Eduard> RESOLVED

<pavels> Now the "Master node" select is missing for child nodes.

<Eduard> Because you don't have master yet..

<pavels> But we should be able to add child nodes using the local node as the master.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(2) When trying to create a node with the node id "0", the error message just says "ERROR: Cannot add node". I think we should add the "Warning. Incorrect value for field "ID"." message.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexei Vladishev [ 2012 Mar 13 ]

(3) Unable to link 1500 or more hosts in Proxy management form.

<Eduard> RESOLVED sorting, but actually can't repeat bug.

<pavels> This seems to be caused by the max_input_vars parameter or it's Suhosin analog. It will be fixed as a separate issue. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(4) When I'm trying to edit a created node, the form looks weird. Note the error message, the duplicating "Name" fields and the "Master node" text. See https://support.zabbix.com/secure/attachment/18327/dm-node.png

<Eduard> RESOLVED

<pavels> We shouldn't be able to change the type of the node after it's created.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(5) When I'm trying to create a passive proxy with a DNS interface without a DNS address, an error occurs:

Undefined index: 10173 [api/classes/CHostInterface.php:537]
Interface with IP "127.0.0.1" cannot have empty DNS name while having "Use DNS" property on "". [CProxy.create -> CHostInterface.create -> CHostInterface.checkInput]

Note, that the last message is missing the proxy name.

<Eduard> RESOLVED

<pavels> The same error message for hosts says "Interface with IP "127.0.0.1" cannot have empty DNS name while having "Use DNS" property on "%HOSTNAME%". Let's make it consistent.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(6) When trying creating a proxy without a "Proxy name" the error message reads "Warning. Incorrect value for field "host".". It should be "Warning. Incorrect value for field "proxy name".".

<Eduard> RESOLVED

<pavels> CLOSED.

<pavels> REOPENED: same thing when trying to create a proxy with an existing name: "Host "1" already exists."

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(7) History seems to be broken.

<Eduard> RESOLVED

<pavels> History is missing from Administration - General. This seems to have been broken in the trunk sometime earlier.

<Eduard> RESOLVED

<pavels> History should have a link to a specific configuration page, not just a single "Configuration of Zabbix" link.

<Eduard> RESOLVED

<pavels> I've changed the title of General / Other to "Other configuration parameters", it's more correct. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(8) The layout of administration/authentication and some other pages is broken in firefox https://support.zabbix.com/secure/attachment/18328/administration-authentication.png

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(9) The navigation menu is missing from the graph, application and screen forms.

<Eduard> Applications, Screens RESOLVED. For Graphs I will do it in ZBXNEXT-908, because most of code will be rewritten..

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(10) It would be really great, if your current location in the navigation menu would be either highlighted, or displayed as text instead of link.

<Eduard> RESOLVED (current location will be without link)

<pavels> Doesn't work in the list of discovery rules and item prototype form.

<Eduard> RESOLVED, same as (14)

<pavels> Noup, still doesn't work.

<Eduard> RESOLVED

<pavels> Still doesn't work in the item prototype form, and in the discrovery form items are highlighted instead of discoveries.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 13 ]

(11) Since you've also fixed page headers, there's one small issue. The header on monitoring/events reads "HISTORY OF EVENTS ON 13 Mar 2012 15:48:42" while on the trigger status page - "STATUS OF TRIGGERS [13 Mar 2012 15:51:23]". It should be unified.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 14 ]

(12) A couple of code issues:

1. CDiscoveryRule already has a "selectPrototypes" option, there's no need for "selectItems";
2. I suggest renaming CWarning::render() to show() to be consistent with other classes.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by richlv [ 2012 Mar 14 ]

apparently, the work is happening in svn://svn.zabbix.com/branches/dev/ZBXNEXT-914

Comment by richlv [ 2012 Mar 14 ]

(13) apparently the trailing dot is missing for "Incorrect interface port "10051eee" provided"

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Oleksii Zagorskyi [ 2012 Mar 15 ]

(14) dev branch r26073 tested. When I click and open some discovery rule properties then I cannot click to a link "Item prototypes (2)" because it's not a hyper-link but just simple text.
When I click to "Trigger prototypes (1)" or "Graph prototypes (1)" then i CAN click to "Item prototypes (2)"

<Eduard> RESOLVED

<zalex> Successful tested, CLOSED.

Comment by Oleksii Zagorskyi [ 2012 Mar 15 ]

(15) according our discussion related to ZBX-3374 would be good to add additional link "<< Discovery rules list" prior the link "Discovery: <some name>"
Then the ZBX-3374 will be fully resolved.

<Eduard> RESOLVED
<zalex> Successful tested, CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 16 ]

(16) The node select is missing from the top of the page.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 16 ]

(17) A "S_STATUS_OF_ZABBIX" string appears in the history.

<Eduard> Seems it was saved in your profile, please re-test it now..

<pavels> Yep, it's ok now. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 19 ]

(18) Please review my changes in r26175.

<Eduard> Ok, CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 20 ]

TESTED.

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 20 ]

trunk r.26226 version 2.0.0.rc2

Comment by richlv [ 2012 Apr 10 ]

interestingly, this has broken map editing in opera (11.61, linux)

adding a new element now fails. error console just reports : "Syntax error at line 1 in event handler: expected expression, got <end of file>"

this was broken in revision r26226

<Eduard> RESOLVED in ZBXNEXT-908 (r.26791)

<richlv> problem gone in the dev branch, rev 26799; leaving as is for code review





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-913] Redesign Configuration->IT services Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2011 Nov 23

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File service-tree.jpg    
Issue Links:
Duplicate
duplicates ZBX-2788 "Never" it services uptime/downtime r... Closed
duplicates ZBX-3859 a couple of problems creating it serv... Closed
duplicates ZBX-2495 polish editing and viewing of IT serv... Closed
duplicates ZBX-2501 collapse-expand-collapse cycle not wo... Closed

 Description   

Edit form



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2011 Nov 08 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-913

Comment by Eduards Samersovs (Inactive) [ 2011 Nov 23 ]

trunk revision 23470





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-909] Redesign Configuration->Discovery Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Feb 03

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File screenshot-1.jpg     JPEG File screenshot-2.jpg     JPEG File screenshot-3.jpg     JPEG File screenshot-4.jpg     JPEG File screenshot-5.jpg    

 Description   

Edit form



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 02 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-909

Comment by Alexander Vladishev [ 2012 Feb 02 ]

(1) Please review my changes in r25169.

<Eduard> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 02 ]

(2) [F] аt not successful saving all new discovery checks disappear
https://support.zabbix.com/secure/attachment/17956/screenshot-1.jpg
https://support.zabbix.com/secure/attachment/17957/screenshot-2.jpg

"new" button becomes unclickable

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 02 ]

(3) [F] discovery checks disappear if save discovery rule with "Device uniqueness criteria" = "<discovery check>"
https://support.zabbix.com/secure/attachment/17958/screenshot-3.jpg

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 02 ]

(4) [AF] cannot delete a discovery rule
pg_query(): Query failed: ERROR: operator does not exist: character varying = integer LINE 1: ...nid FROM conditions c WHERE c.conditiontype=18 AND c.value=2 ^ HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts. [include/db.inc.php:430]
Error in query [SELECT DISTINCT c.actionid FROM conditions c WHERE c.conditiontype=18 AND c.value=2] [ERROR: operator does not exist: character varying = integer LINE 1: ...nid FROM conditions c WHERE c.conditiontype=18 AND c.value=2 ^ HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.]
pg_fetch_assoc() expects parameter 1 to be resource, boolean given [include/db.inc.php:565]
pg_free_result() expects parameter 1 to be resource, boolean given [include/db.inc.php:566]

Related issue: ZBX-4182

<Eduard> RESOLVED

<Sasha> REOPENED SQL statement at include/discovery.inc.php:186 should be fixed too.

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 02 ]

(5) [F] Cannot delete a discovery rule from a form - 'Delete' button disabled

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 03 ]

(6) аt not successful saving "key" and "SNMP OID" values disappear
https://support.zabbix.com/secure/attachment/17970/screenshot-4.jpg
https://support.zabbix.com/secure/attachment/17971/screenshot-5.jpg

<Eduard> RESOLVED
<Sasha> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Feb 03 ]

trunk r.25197 version pre-1.9.10





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-908] Redesign Configuration->Graphs Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Apr 18

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: graphs
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates ZBX-2889 draw style should not be shown for st... Closed
duplicates ZBX-4642 better strings for graph configuratio... Closed
duplicates ZBX-4758 In graph_prototypes.php it is possibl... Closed
is duplicated by ZBXNEXT-944 merge pie graphs & exploded pie graphs Open
is duplicated by ZBX-3099 problems editing graphs in trunk Closed
is duplicated by ZBX-3197 Width of the pop-up windows should be... Closed

 Description   

Edit form;

item ordering must be changed to the draggable one as elsewhere;
item list must gain header;
item list must use "remove" links instead of checkboxes + a button

also see (5) in ZBX-3585



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Apr 04 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-908

Comment by Alexey Fukalov [ 2012 Apr 04 ]

(1)
Sorting by graphtype seems working only for graphs on current page.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by richlv [ 2012 Apr 04 ]

(2) let's enable "Show working time" and "Show triggers" checkboxes by default for new graphs

<Eduard> RESOLVED

<richlv> dev branch rev 26651 - they still seem to be disabled by default

<Eduard> Rich, you test code faster rather than I can commit to in svn ))

<richlv> hey, "resolved" means "committed"
CLOSED

Comment by richlv [ 2012 Apr 04 ]

(3) in graph elements, colour codes now use lowercase (uppercase everywhere else and before)
this seems to happen only when adding new items, modifying colour sets them to uppercase again

<Eduard> RESOLVED

<richlv> CLOSED

Comment by richlv [ 2012 Apr 04 ]

(4) apparently, new graph elements now use randomised colour.
4.1. this isn't documented anywhere;
4.2. sometimes, this can generate broken colour code, for example, i got : e0498

<Eduard> RESOLVED

<richlv> totally broken colours aren't generated anymore, but some quick colour choosing algorithm description would be still needed.
additional idea... if the generated colour matches "graphcolor", maybe we can skip that and generate next colour ?

<Eduard> RESOLVED

<richlv> i meant some description here that we could later adapt for the zabbix manual

<richlv> i believe https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908 is a good place to describe the algo

<Eduard> RESOLVED

Comment by richlv [ 2012 Apr 04 ]

(5) open a graph, save it (without changing anything).
we do update query with all fields in the graphs table. even worse, we delete all graph items, then create them one by one, doing select from ids/update ids for every one of them.
5.1. if possible, we shouldn't do update in this case;
5.2. we shouldn't delete all items & recreate them;
5.3. when creating items (for a new graph, for example), maybe it's possible to increase ids only once and insert all graph items in one go ?

<Eduards> 5.2 - It's hard to simple resolve because in graph item array we can receive NEW items and DELETED items.. so easy way is delete and recreate all ))
We can register new ZBXNEXT but it's is so global and so big work..

<richlv> for anything that won't be fixed here, please, create new issues (although they should be ZBX, not ZBXNEXT )

<richlv> won't be fixed here, split out as ZBX-4861 - CLOSED

Comment by richlv [ 2012 Apr 04 ]

(6) currently it is possible to add all kind of mixed items from templates and hosts to a single custom graph.
same limits as before should be returned - only items from a single template or from any number of hosts.

or, to put it otherwise, if the first item to be added to a graph is from from a template, subsequent items can only be added from the same template (group & host dropdowns are disabled and provide a helpful tooltip)
if the first item is added from a host, further item adding should not display templates (and their items) when adding more graph items

<Eduard> RESOLVED

<Vedmak> now i cannot change item, "Critical error. Incorrect value "host_templateid" for "srcfld3" field." in opened popup. And still can create graphs with mixed items.

<Eduard> RESOLVED

<Vedmak> items from mixed sources can be added by updating already added items.

<Eduard> RESOLVED

<Vedmak> it is still possible
Open new graph form, add template item, click save, get error that name is missing for graph, now you can add host items.

Also, when graph created with lld created items, these items cannot be updated error in popup.

<Eduard> RESOLVED

<Vedmak> problem with lld created items still exists.

Also, open new graph form, add template item, click save, get empty name error, remove that item, try to add another, only items from template can be added.

Also, if for axis item we selected host item, we can add template items after that.

<Eduard> RESOLVED

<Vedmak> CLSOED

Comment by richlv [ 2012 Apr 05 ]

(7) it is possible to add an item twice. this was not possible in 1.8

also reported as (1) in ZBX-3099

<Eduard> Decided allow adding multiple items, because they can be configured with different functions.

<richlv> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 05 ]

(8)
In class.CImg.php for random preloader id better use something like timestamp, rand() function can still get same numbers..

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 05 ]

(9)
In graph prototypes list, graph names are prepended with discovery rule name and have disabled checkboxes.

<Eduard> RESOLVED

<Vedmak> previous was fixed, but now discovered graphs names are clickable and redirect to "ERROR: No permissions to referred object or it does not exist!"
Also prabably all discovered entities should have space after discovery rule name, items and triggers too.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 05 ]

(10)
If i set percentile to incorrect value "abc" for example, in preview i get error.

<Eduard> Decided not to fix, because in Preview we see a warning message.

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 05 ]

(11)
Incorrect item colors can be saved.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 10 ]

(12)
Sometimes item cannot be removed from graph, or wrong item is removed.

<Eduard> RESOLVED

<Vedmak> Update still happens to wrong item. open graph, remove one item, try to update last item.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 10 ]

(13)
Pie and Exploded graph cannot be saved with more than one "Graph sum" items, however it can be previewed. Probably should display error message in place of preview as with other errors.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 10 ]

(14)
I think we should allow removing last item.

<Eduard> RESOLVED (12)

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 10 ]

(15)
1. open new graph prototype form
2. add one normal item
3. try to edit that item
4. prototype item popup is open, normal item popup must be opened

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 10 ]

(16)
Open pie graph, remove all items, try to save, get error "Incorrect value "" for int field "drawtype". [CGraph.update -> CGraph.updateReal -> DB.insert -> DB.checkValueTypes]"

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by richlv [ 2012 Apr 11 ]

(17) set percentile value to "abc", try to save the graph - percentile is removed.
set percentile to "abc123", try to save the graph - percentile is removed.
set percentile to "123abc123", try to save the graph - percentile is changed to 123.

it should always stay the same, never cleared

<Eduard> RESOLVED

<richlv> for numbers, .00 is added - but let's assume that's ok, CLOSED

Comment by richlv [ 2012 Apr 11 ]

(18) maybe we should limit percentile field lengths to 5 characters ? that should allow entering strings like :
100.00
99.957

more precision here might not be necessary. api also should limit percentile values to 5 chars, though

<Eduard> RESOLVED, precision maxlenght set to 6 to support "100.00" value.

<richlv> ah, i can't count
but entering "-444" and trying to save changes it to "-444.00", which is 7 characters
maybe .00 should be added only if the number is considered to be valid ?

<Eduard> Decided not to fix.

<richlv> frontend part closed (fix would complicate things a bit too much and it's a really minor problem), but reviewer should verify the api part as well

<Vedmak> There are no API validation for such things, i think we won't implement it in this issue.. CLOSED

Comment by richlv [ 2012 Apr 11 ]

(19) try to save percentile as "abc" - frontend complains that it's not "double". maybe we can change that to "decimal number" ?

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 11 ]

(20)
Now in page source can be found code like:

<span id="items_29_name" class="link" onclick="PopUp('popup.php?writeonly=1&dstfrm=graphForm&dstfld1=items_52_itemid&dstfld2=items_52_name&dstfld3=items_52_host_templateid'
+ '&srctbl=items'
+ ''
+ (hostTemplateId() > 0 ? '&only_hostid=' + hostTemplateId() : '')
+ '&real_hosts=1'
+ ''
+ '&srcfld1=itemid&srcfld2=name&srcfld3=host_templateid', 800, 600)" name="items[29][name]">
Zabbix server:Free swap space in %
</span>

These concatenations should be removed.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 12 ]

(21)
If item has long description, takes 2+ lines, it cannot be dragged/sorted properly.

<Eduard> RESOLVED

<Vedmak> not really fixed, but decided not to fix CLOSED

<richlv> probably worth specifying why this won't be fixed

<Vedmak> probably too much investigation is needed.

<richlv> please, split it out in a separate zbx then

<Vedmak> created ZBX-4875

<richlv> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 12 ]

(22)
New icon mapping form is broken.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 12 ]

(23)
Seems dragging in web steps form broken too.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Oleksii Zagorskyi [ 2012 Apr 13 ]

(24) [usability] opened color picker should be moved a bit right.
Now it closes the color I'm trying to change and other colors (located bottom) -> it's bad, I do not see it and them as well.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 13 ]

(25)
Links in maps seems broken.
Add 2 elements, create link between them, this link does not appear in elements form.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by richlv [ 2012 Apr 13 ]

spec draft in https://zabbix.org/wiki/Docs/specs/ZBXNEXT-908
please, populate it with missing detail

Comment by Alexey Fukalov [ 2012 Apr 13 ]

(26)
When we add prototype to graph, it's not prefixed with host name.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Apr 13 ]

(27)
When graph created with lld created items, these items cannot be updated error in popup.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 16 ]

(28) Now we can edit templated graphs. It shouldn't be so

<Eduard> RESOLVED

<Sasha> REOPENED

  • items in graph shouldn't look as a link
  • sorting arrows should be disabled
  • parent graphs should be displayed like in triggers

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 16 ]

(29) The link from the list of graphs opens a form of a template instead of the list of graphs from a template

<Eduard> RESOLVED
<Sasha> CLOSED





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-907] Redesign Configuration->Application Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2011 Nov 23

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Alexei Vladishev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Edit form



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2011 Nov 15 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-907

Comment by richlv [ 2011 Nov 15 ]

(1) try to create an application with the same name :

Application [z] already exists

square brackets should be changed to doublequotes, trailing dot is missing

<Eduard> RESOLVED

<richlv> CLOSED

Comment by richlv [ 2011 Nov 15 ]

(2) edit a list of applications on a host with some applications coming from a template. click on template name - this goes to the application list for that template. edit an application here, change it's name, save.
we now have a list of applications on some host (sometimes the host we edited before, sometimes totally different host)

<Eduard> RESOLVED

<richlv> what about committing ?
<Eduard> COMMITED

<richlv> CLOSED

Comment by Alexey Fukalov [ 2011 Nov 15 ]

(3) [GUI]
Application form page has header "CONFIGURATION OF WEB MONITORING".

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2011 Nov 15 ]

(4) [GUI]
If "Dropdown first entry" is set to "None" and "Not selected" is selected in host dropdown, most controls disappear from page.

<Eduard> RESOLVED

<Vedmak> Now when "Not selected" is set, all applications are shown.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by richlv [ 2011 Nov 15 ]

(5) unittests must be added/updated - especially see things like header above (3) ...

<Eduard> RESOLVED

Comment by Eduards Samersovs (Inactive) [ 2011 Nov 23 ]

revision 23467, 23464





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-906] Redesign Configuration->Host groups Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2011 Nov 30

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Edit form



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2011 Nov 10 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-906

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 15 ]

<Igor>
(1) I think that we should use the same operation names in the drop-down on the left side of the screen and in the confirmation messages for these operations.

For example, in the drop-down is "Activate selected hosts", but in the confirmation dialog box is "Enable selected hosts groups ?".
Think that we can use "Activate selected hosts" for both of them.

<Igor> CLOSED, now we are using "Activate selected" message.

(2) In the confirmation dialog box should be "Disable selected hosts" instead of "Disable selected host groups".

<richlv> but we don't have any hosts selected
the best would probably be "Disable hosts in the selected host groups" or something like that, but that's a bit too long...

<igor> Yes, we do not have any hosts selected, only hosts groups, but host groups can not be disabled. Yes, second variant is too long.

<Eduard> RESOLVED

<Igor> CLOSED, now in the confirmation dialog box we are using message "Disable hosts in the selected host groups".

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 16 ]

(3) When using ZBXNEXT-906 dev branch, in the Administration->Users report after click on the user group name (or on user name) appears the following errors (this error only appears when using Mysql DB, when using PostgreSql this error is not reproducible) :

Error in query [SELECT n.nodeid AS nodeid,n.name AS node_name,g.*,0AS permission FROM groups g LEFT JOIN nodes n ON (g.groupid div 100000000000000)=n.nodeid WHERE g.groupid BETWEEN 000000000000000 AND 099999999999999 ORDER BY n.name,g.name] [Unknown column '0AS' in 'field list']
mysql_fetch_assoc() expects parameter 1 to be resource, boolean given [include\db.inc.php:572]
mysql_free_result() expects parameter 1 to be resource, boolean given [include\db.inc.php:573]

But in trunk branch the same problem is not reproducible. Something wrong with this dev branch (Unknown column '0AS') ?

<Eduard> RESOLVED

<Igor> CLOSED

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 16 ]

(4) Maybe it is better to replace message "Group added" (that appears in the info bar after adding new host group or after cloning existing host group) with " "X" Group added", where "X" is name of the added host group ?

<Eduard> Decided not to do

<Igor> CLOSED, this behaviour is the same when creating (adding) new host.

Comment by Aleksandrs Saveljevs [ 2011 Nov 23 ]

(5) Some messages are not translated, some are split into several parts:

$ grepphp incorrect.user.data
./frontends/php/include/perm.inc.php: fatal_error('Incorrect user data in "get_accessible_hosts_by_user".');
./frontends/php/include/perm.inc.php: fatal_error(_('Incorrect user data in').SPACE.'"get_accessible_groups_by_user"');
./frontends/php/include/perm.inc.php: fatal_error(_('Incorrect user data in').SPACE.'"get_accessible_nodes_by_user"');

<Eduard> RESOLVED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 24 ]

(6) New PHP files have old FSF postal address.

<Eduard> RESOLVED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 24 ]

(7) New PHP files don't have svn:eol-style property set to native.

<Eduard> RESOLVED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 25 ]

(8) There was a problem syncing with trunk. I have found one problem, but there might be other problems, too.

<asaveljevs> File services_form.php is not present in trunk and should have been deleted in development branch. However, the file is still present in the branch. That means it will be added to trunk when the branch is reintegrated.

<Eduard> RESOLVED
<sasha> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2011 Nov 30 ]

trunk revision 23620





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-904] Redesign Configuration->Screens Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Mar 13

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Minor
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: screens
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File history_not_visible.png     PNG File history_visible.png     PNG File screen_element_selection.png    
Issue Links:
Duplicate
is duplicated by ZBX-1204 screen deletion not registered on the... Closed
is duplicated by ZBX-4702 Dynamic item missing in the exported ... Closed
is duplicated by ZBX-1841 screen and slideshow editing problems 2 Closed
is duplicated by ZBX-1946 row and column span in screens exceed... Closed
is duplicated by ZBX-2725 polish editing of screens Closed
is duplicated by ZBX-4604 Cannot add screen on screen Closed
is duplicated by ZBX-4649 Editing screen doesn't work properly ... Closed
is duplicated by ZBX-1213 column span for screen element lower ... Closed

 Description   

Edit form and screen visual constructor



 Comments   
Comment by Eduards Samersovs (Inactive) [ 2012 Feb 24 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-904

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(1) [GUI]
Js error In ie8 after any element drag.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(2) [GUI]
Have one element in row, edit it, move it to another row, try to delete now empty row, alert appears with warning that row is not empty.
Probably that caused because element moving is done with ajax, but alerts are attached on page refresh.

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(3) [GUI]
Now rowspan and colspan cannot be 0, but it was allowed before, so now it show errors when update element on old screens. Maybe db patch should be added.

also even if we set rowspan/colspan to 1, but then move element to another empty cell, they are set to 0.

<Eduard> RESOLVED, Reverted validation on rowspan and colspan.. allow 0 values.

<richlv> dev branch rev 25776. attempting to save screen element with 0/0 colspans still fails :

Warning. Incorrect value for field "colspan".
Warning. Incorrect value for field "rowspan".

also the mentioned reseting of span from 1 to 0 is still there

<Eduard> Retry Now

<Vedmak> rowspan/colspan still resets to 0 if we move element with rowspan/colspan 1.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(4) [GUI]
Cannot switch screen elements places if they have aligned not to center/middle.

<Eduard> RESOLVED

<Vedmak> now when you switch element with places, alignment is not switched.

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(5) [GUI]
In screen element "Server info" remove row with "refresh now" link, and make link to zabbix server status to be shown only for super admins.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 01 ]

(6) [GUI]
Now we cannot switch screen elements coordinates via API.

<Eduard> RESOLVED

<Vedmak> let's better separate validation to methods instead of long additional options to one method

<Vedmak> CLOSED

Comment by richlv [ 2012 Mar 03 ]

(7) server info element doesn't seem to have "Vertical align" options styled like the other screen elements

hmm, this seems to depend either on other elements/their layout or editing sequence, can't reproduce reliably... CLOSED for now

Comment by richlv [ 2012 Mar 03 ]

(8)

[03/03/2012 05:57:58 AM] JavaScript - http://localhost:8883/dev/ZBXNEXT-904/screenedit.php?screenid=5&sid=96e83c42e664b647
Event thread: DOMContentLoaded
Uncaught exception: TypeError: 'jqBlink.init' is not a function
Error thrown at line 6, column 0 in <anonymous function>() in http://localhost:8883/dev/ZBXNEXT-904/screenedit.php?screenid=5&sid=96e83c42e664b647:
jqBlink.init();
called via Function.prototype.apply() from line 4978, column 29466 in <anonymous function: f.Callbacks>(b, f) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
if(c[l].apply(b,f)===!1&&a.stopOnFalse)
called from line 4978, column 31004 in <anonymous function: fireWith>(b, c) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
d&&(i?a.once||d.push([b,c])!a.once||!e)&&n(b,c));
called from line 4978, column 19394 in <anonymous function: ready>(a) in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
A.fireWith(c,[e]),e.fn.trigger&&e(c).trigger("ready").off("ready")
called from line 4978, column 28585 in <anonymous function: B>() in http://localhost:8883/dev/ZBXNEXT-904/jsLoader.php?ver=1.9.10&lang=en_GB:
c.removeEventListener("DOMContentLoaded",B,!1),e.ready()

<Eduard> It's a different issue, after merging from upstream problem resolves.

Comment by richlv [ 2012 Mar 03 ]

(9) adding history of events seems to break screen configuration.
a) it is not possible to drag any cell contents anymore;
b) other elements (in this case, graphs) do not appear at all

see the screenshot. while event history element is being edited (thus history itself is not visible), elements can be seen and dragged.
when history is visible, other elements disappear and history or empty cells can't be dragged anymore

https://support.zabbix.com/secure/attachment/18293/history_not_visible.png
https://support.zabbix.com/secure/attachment/18294/history_visible.png

<Eduard> Same es (8) It's a different issue, move to ZBX-4730

Comment by richlv [ 2012 Mar 03 ]

(10) if screen does not fit horizontally in the browser window, 'select' button for the element (while editing it) is wrapped and the input field bleeds over other columns

https://support.zabbix.com/secure/attachment/18295/screen_element_selection.png

<Eduard> CLOSED. Moved to ZBXNEXT-1140

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 05 ]

trunk r.25808 version pre-1.9.10

Comment by richlv [ 2012 Mar 12 ]

(11)
$ svn diff -c 25808 frontends/php/include/locales/en_gb.inc.php | grep S_ALREADY_EXISTS_SMALL

  • 'S_ALREADY_EXISTS_SMALL'=> _('already exists'),

$ svn up
At revision 25957.
$ grep S_ALREADY_EXISTS_SMALL frontends/php/api/classes/CTriggerPrototype.php
self::exception(ZBX_API_ERROR_PARAMETERS, S_TRIGGER.' ['.$trigger['description'].'] '.S_ALREADY_EXISTS_SMALL);

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 14 ]

trunk r.26075 version 2.0.0rc2





Redesign forms to MVC rails and migrate javascript from Prototype to jQuery (ZBXNEXT-870)

[ZBXNEXT-903] Redesign Configuration->Items Created: 2011 Aug 24  Updated: 2017 May 31  Resolved: 2012 Mar 22

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Blocker
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: itemconfigform
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File item-interface.png    
Issue Links:
Duplicate
is duplicated by ZBX-4596 Error in Details when deleting trigge... Closed
is duplicated by ZBX-2631 confusing flexible interval configura... Closed
is duplicated by ZBX-1601 Clear history of items in templates d... Closed
is duplicated by ZBX-2071 Zabbix frontend fails on IPMI sensors... Closed
is duplicated by ZBX-2662 mass actions partially reset item filter Closed
is duplicated by ZBX-3330 excessive remembering of item filter ... Closed
is duplicated by ZBX-1335 Item filter related issues Closed
is duplicated by ZBX-3304 item filter control visual discrepancy Closed
is duplicated by ZBX-3373 Multiple host interfaces. GUI improve... Closed
is duplicated by ZBX-3466 no error message when creating an ite... Closed
is duplicated by ZBX-4280 Incorrect behavior filter for items Closed
is duplicated by ZBX-4110 ssh key auth form field "password" sh... Closed
is duplicated by ZBX-4588 Unused SNMPv3 fields are left when ch... Closed

 Description   

Specification http://zabbix.org/wiki/Docs/specs/ZBXNEXT-903



 Comments   
Comment by richlv [ 2011 Sep 02 ]

if this refers to item config form, would be nice to take ZBX-3373, ZBX-3402, ZBX-3466, ZBX-3881 and ZBX-4110 into account

Comment by richlv [ 2012 Jan 20 ]

(1) redesign seems to be fairly nice, but there seems to be no design document at all. current implementation should be documented on the specification wiki and basically describe how it works now (field order, value mappings and applications being sorted alphabetically etc etc)
otherwise it's not really possible for testers/reviewers to know for sure that it works as expected (for example, data type currently being sorted by base)

<alexei> We need design doc! I have so many ideas for this form.

<richlv> just to note down that current spec is seriously lacking - doesn't list field ordering, field visibility depending on contents of other fields etc
<richlv> spec does not conform to what is in the dev branch at all... things like how history clearing buttons are implemented and loooots of other things. not sure how testing or developing can happen without doing lots of redundant work.

<richlv> sorry, this doesn't work. i don't know how should i put it. THIS DOESN'T WORK.
there is no f-ing way anybody can determine whether item config form works according to the specification. oh, wait, let me try it differently - ti doesn't.
how can tests be created ? how could it be tested ? by word of mouth rumours ?

Comment by dimir [ 2012 Jan 25 ]

(2) When doing "mass update" of SNMPv3 (authPriv) item to change it to SNMPv2c the "SNMPv3 auth passphrase" and "SNMPv3 priv passphrase" fields are left in the form after update. The bug is not reproduced with direct item edit, only when doing mass update.

FYI in 1.8 it's reproduced in both cases.

<dimir> CLOSED. Moved to a separate issue ZBX-4588 .

Comment by richlv [ 2012 Jan 26 ]

item filter issues are also being looked at. as such, the following would be nice to consider :
ZBX-1335, ZBX-3330, ZBX-3982, ZBX-4280

lower priority :
ZBX-3304, ZBX-3982

Comment by Eduards Samersovs (Inactive) [ 2012 Jan 28 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-903

Comment by Oleksii Zagorskyi [ 2012 Jan 29 ]

(3) [Usability] I need to scroll page vertically to save an item changes -> unexpected.
My monitor height is 1050 pixels, btw
Is it ok?

<Eduard> Have decided not create new Tab, because all fields are important.. So it's ok.

<alexei> Yes, it is ok. We decided not to introduce any new tabs for now. CLOSED

Comment by Oleksii Zagorskyi [ 2012 Jan 29 ]

At least the ZBX-3373 is not implemented at all. Seems all other linked "duplicates" could/should be reviewed.
REOPENED.

<Eduard> RESOLVED

Comment by Alexei Vladishev [ 2012 Jan 30 ]

(4) Connect as an user having read-write permission to a host

Configuration->Hosts->Items (click on a host having templated items), click on a template item. See errors below the form:

reset() expects parameter 1 to be array, null given [include/forms.inc.php:951]
Undefined index: discoveryRule [include/forms.inc.php:958]
Undefined index: itemid [include/forms.inc.php:965]
Undefined index: templateid [include/forms.inc.php:967]

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexei Vladishev [ 2012 Jan 30 ]

(5) Configuration->Templates, click on template items

You will see list of items of a host, not template. It seems host selection is remembered in item filter.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexei Vladishev [ 2012 Jan 30 ]

(6) Configuration->Hosts->Items

Click on a template Template_Linux in item name "Template_Linux:Buffers memory". You are supposed to see list of Template_Linux items, however host items are displayed. Probably related to (5).

<Eduard> (5) RESOLVE this issue

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ]

(7) If the host doesn't have any available interfaces for the selected item type, the interface select element breaks (tested in Firefox). https://support.zabbix.com/secure/attachment/17947/item-interface.png

<Eduard> RESOLVED ))

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ]

(8) when selecting some SNMP or IPMI type, the select key button becomes disabled, but the input itself is still editable.

<Eduard> It's ok, for SNMP and IMPI user type key by hands..

<pavels> Oh, OK. CLOSED.

Comment by Alexei Vladishev [ 2012 Jan 31 ]

(9) Configuration->Hosts->Items

Look at the debug information. The amount of API calls, permission checks and unnecessarily data exchange kills performance. It has to be fixed.

<Eduard> RESOLVED

<Vedmak> There is still quite a lot sqls.. ~130 more than in trunk. Maybe we should discuss that problem together.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ]

(10) It would be nice to vertically align the custom multiplier checkbox, in firefox it's shifted to the top.

<Eduard> RESOLVED, still not in css at this time..

<pavels> Ok, CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ]

(11) Maybe we should group the input fields into several logical groups (e.g. type specific fields, intervals and history, applications) and add a margin between them? The form would be more usable, and it will be clearer, how the fields depend on each other.

<pavels> After some discussion with Eduards and Sasha we've decided not to do that now. CLOSED.

Comment by Alexei Vladishev [ 2012 Jan 31 ]

(12) Applications not sorted in the list of item prototypes "CPU, Availability", must be "Availability, CPU".

<Eduard> RESOLVED

<Vedmak> Sorting is not natural: 1, 12, 2.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 31 ]

(13) In configurations.item.edit.php:
1. there are a lot of really long lines, that are hard to read. Remember, that we have a 120 symbol limit;
2. I suggest you move all of the "insert_post_js" code to configuration.item.edit.js.php to avoid mixing PHP and JS.

<Eduard> RESOLVED

<pavels> I don't think that using large ternary operators in function calls is a good idea. I mean blocks like:

$itemFormList->addRow(_('Host'), array(
new CTextBox('hostname', $this->data['hostname'], ZBX_TEXTBOX_STANDARD_SIZE, true),
empty($this->data['itemid'])
? new CButton('btn_host', _('Select'),
"return PopUp('popup.php?dstfrm=".$itemForm->getName().'&dstfld1=hostname&dstfld2=form_hostid'.
"&srctbl=hosts_and_templates&srcfld1=name&srcfld2=hostid&noempty=1&submitParent=1', 450, 450);",
'formlist'
)
: null
));
<Eduard> After some discussion with Pavels we decided not to do this. CLOSED

Comment by Alexei Vladishev [ 2012 Jan 31 ]

(14) Please fix ZBX-3304 in other places as well (list of hosts, somewhere else?) to make it consistent.

<Eduard> RESOLVED also in Hosts and Host inventories.

<alexei> please make 'Filter' preferred action, i.e. mark it with yellow border

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexei Vladishev [ 2012 Feb 01 ]

(15) Only interfaces matching item type must be displayed. If no interfaces found then empty (or 'none') drop-down should be displayed with red message 'No interface found' on the right side.

<Eduard> RESOLVED

<alexei> it is not correct, the logic must be as follows:

case ITEM_TYPE_ZABBIX:
return INTERFACE_TYPE_AGENT;
case ITEM_TYPE_SNMPv1:
case ITEM_TYPE_SNMPv2c:
case ITEM_TYPE_SNMPv3:
case ITEM_TYPE_SNMPTRAP:
return INTERFACE_TYPE_SNMP;
case ITEM_TYPE_IPMI:
return INTERFACE_TYPE_IPMI;
case ITEM_TYPE_JMX:
return INTERFACE_TYPE_JMX;
case ITEM_TYPE_SIMPLE:
case ITEM_TYPE_EXTERNAL:
case ITEM_TYPE_SSH:
case ITEM_TYPE_TELNET:
return INTERFACE_TYPE_ANY;
default:
return INTERFACE_TYPE_NONE;

<Eduard> RESOLVED"

<pavels> I think the message should read "No interfaceS found". Plus, when we try to submit a form with that message, it still submits some interface ID and the error message reads "Item uses incorrect interface type" instead of "No interface for item".

<Eduard> After discussion with Pavels we decided not to do this. CLOSED

<pavels> Wait, we've decided no to change the "No interface found" message, the part about the error remains. REOPENED.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(16) Regarding itemTypeInterface() in functions.js. It's not a good idea to duplicate this logic on the client side. I think we should pass the interface mapping rules as an associative array from the PHP side.

<Eduard> RESOLVED, impl. without any array..

<Vedmak> I'm not sure what it was about initially, but "insert_javascript_itemTypeInterface" must be removed from CItemGeneral class And i think Pavel's idea about implementation was that we should not change more than one function/method if we add new interface.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(17) In the item mass update form the "show value mappings" link should not be displayed if the value "show value" checkbox is unchecked.

<Eduard> RESOLVED

<pavels> The "show value mapping" link is broken (leads to config.php)

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexei Vladishev [ 2012 Feb 03 ]

(18) Please fix ZBX-1601 as well. Remove the history button for items from templates.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 03 ]

(19) "Log time format" field should be visible only with "Type of information" = "Log"

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 03 ]

(20) "SNMP OID", "SNMP community" and "Port" fields should not be visible with "Type of information" = "Character"

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(21) in the "copy to" form in FireFox there is no margin between the "target" label and the lower border.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(22) The "Group" drop down is not working in firefox in the "copy to" form.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(23) In configuration.item.edit.js the two jQuery.ready blocks should be united in one.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 03 ]

(24) In configuration.item.edit.php the numerous zbx_subarray_push should be somehow restructured to be more maintainable.

<Eduard> After discussion with Pavels we decided optimize it not in this time. CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(25) [GUI]
In items.php there were two places where variable in "foreach" is used as reference and not unset afterwards.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(26) [GUI]
Go to any templated item configuration form, change for example "Populates host inventory field" value, then add new flexible interval, after page reload, "Populates host inventory field" value is reset.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(27) [GUI]
Applications subfilter for items list seems broken.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(28) [GUI]
Button "Select" near "key" input in item form is enable for JMX items and disabled for SNMP trap, not sure but it probably should be enabled for all types that are in keys popup and disabled for others.

Also that button has "hand" cursor even if disabled.

<Eduard> Cursor RESOLVED

<Vedmak> "Select" button should be disabled also for "Zabbix trapper", "External check", "Database monitor", "SSH agent", "TELENT agent", "JMX agent", "Calculated" item types.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(29) [GUI]
In mass update form interfaces can be updated even if items are from different hosts.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(30) [GUI]
In item list if we filter not by host, but by group, then host column is missing.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(31) [GUI]
In item mass update form, try to add 3 new flexible intervals then delete one of them, 2 are deleted instead of one. All the time random intervals are deleted..
And Undefined offset: 1 [include/views/configuration.item.massupdate.php:243] is shown.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(32) [GUI]
After adding flexible interval in item mass update form application list becomes empty.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 03 ]

(33) [GUI]
If we mass update item with incorrect type/interface pair, error is shown in item list (update form closes) and without any success/fail message.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexander Vladishev [ 2012 Feb 03 ]

(34) [GUI] flexible intervals in "Mass update" and "Item" forms should be unified.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 06 ]

(35) [GUI]
In item form only 7 flexible intervals can be added, but in mass update form 8.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 06 ]

(36) [GUI]
"Delete history and trends" button appears for items in template, but not appears for host inherited items, i think it should be otherwise.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by richlv [ 2012 Feb 07 ]

(37) add an application to an item that has a name :
'
(single quote).

try to use it in item subfilter :

[02/07/2012 12:59:18 AM] JavaScript - items.php?sid=df9ac3e9bc8c64ca&form_refresh=4&filter_groupid=0&filter_hostid=0&filter_group=&filter_hostname=2&filter_application=&filter_name=&filter_key=&filter_type=-1&filter_delay=&filter_value_type=-1&filter_history=&filter_trends=&filter_status=-1&filter_with_triggers=-1&filter_templated_items=-1&subfilter_apps%5BU%23%25%40%26*%23%24%40%26*%23%24%26%24%40%232%5D=U%23%25%40%26*%23%24%40%26*%23%24%26%24%40%232
Script compilation
Syntax error at line 1 in event handler: expected ')', got ']'
', 'subfilter_apps[']', ''', true);
--------------------^

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Feb 07 ]

(38) [GUI]
Some fields are now not correctly hidden/shown, also when item type "Database monitoring" selected "Additional parameters" field is empty, but it should contain basic params as in trunk.

<Eduard> RESOLVED

<Vedmak> Previous fixed, but i found one more case. When select "Type of information" numeric unsigned and "Data type" boolean, multiplier fields are hidden, then change
"Type of information" to numeric float and then back to numeric unsigned, now multiplier fields are shown though boolean data type is selected.

<Vedmak> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Feb 08 ]

trunk r.25256 version pre-1.9.10

Comment by richlv [ 2012 Mar 21 ]

(39) the merge has resurrected hosts_mon.php file, which was deleted in rev 24986
this has happened before already, so i'd strongly suggest figuring out what goes wrong with merges...

<Eduard> Out of ZBXNEXT-903 problem, CLOSED !





[ZBXNEXT-863] Rename "profile" to "inventory" for host inventories Created: 2011 Jul 26  Updated: 2011 Dec 22  Resolved: 2011 Aug 05

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Agent (G), Frontend (F), Server (S)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Minor
Reporter: dimir Assignee: dimir
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Rename "profile" to "inventory" for host inventories in:

  • the schema
  • server code
  • frontend code
  • API
  • documentation

Document API changes.

We agreed not to apply any changes to XML Export/Import as it's currently broken and would require a somewhat re-write.



 Comments   
Comment by dimir [ 2011 Jul 29 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-863 .

Comment by dimir [ 2011 Jul 29 ]

(2) Documentation is yet to fix.

<dimir> Updated:

http://www.zabbix.com/documentation/2.0/manual/appendix/macros/supported_by_location

http://www.zabbix.com/documentation/2.0/manual/appendix/api/host
http://www.zabbix.com/documentation/2.0/manual/appendix/api/host#inventory_fields
http://www.zabbix.com/documentation/2.0/manual/appendix/api/host/create
http://www.zabbix.com/documentation/2.0/manual/appendix/api/host/get
http://www.zabbix.com/documentation/2.0/manual/appendix/api/host/massupdate
http://www.zabbix.com/documentation/2.0/manual/appendix/api/host/update

http://www.zabbix.com/documentation/internal/database_2.0/host_inventory
http://www.zabbix.com/documentation/internal/database_2.0/hosts
http://www.zabbix.com/documentation/internal/database_2.0/items

http://www.zabbix.com/documentation/2.0/manual/appendix/api/changes_1.8_-_2.0?&#host
http://www.zabbix.com/documentation/2.0/manual/installation/upgrade_notes

<dimir> RESOLVED
<sasha> fixed http://www.zabbix.com/documentation/2.0/manual/appendix/api/changes_1.8_-_2.0

<dimir> Thanks, CLOSED

Comment by dimir [ 2011 Aug 03 ]

Do we need to fix translations within this issue?

<richlv> if that refers to updating translations for changes made, then no

Comment by dimir [ 2011 Aug 05 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-863

Comment by dimir [ 2011 Aug 08 ]

(6) Will fix the 2.0 docs to list only those

{PROFILE.*}

that are in 1.8 as deprecated.

<dimir> RESOLVED
<sasha> CLOSED

Comment by dimir [ 2011 Aug 09 ]

(7) One last thing, add "inventory_link" parameter to API.

<dimir> Tested, it actually works.
<dimir> RESOLVED http://www.zabbix.com/documentation/2.0/manual/appendix/api/item?&#object_details and example at http://www.zabbix.com/documentation/2.0/manual/appendix/api/item/create?&#create_new_item_for_host_with_host_id_10057_to_update_host_inventory_field_os

<dimir> (on behalf of sasha) CLOSED

Comment by dimir [ 2011 Aug 10 ]

Fixed in trunk r21072 .

Comment by richlv [ 2011 Aug 30 ]

one more potentially missed variable reported as ZBX-4088





[ZBXNEXT-674] Support of displaying all hosts of a given host group in maps Created: 2011 Feb 24  Updated: 2011 Aug 03  Resolved: 2011 Jun 22

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexander Vladishev Assignee: Aleksandrs Saveljevs
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug_10.png     PNG File bug_12.png     PNG File bug_16.png     PNG File bug_3.png     PNG File bug_32.png     PNG File bug_34.png     PNG File bug_37.png     PNG File bug_39.png     PNG File bug_4.png     PNG File bug_47.png     PNG File bug_5.png     PNG File bug_6.png     PNG File bug_7.png     PNG File bug_8.png     PNG File bug_9.png    

 Description   

Zabbix should support automatic placing of discovered devices or all devices of a given group on a map. It would simplify maintenance very much.



 Comments   
Comment by Alexander Vladishev [ 2011 Feb 24 ]

It will be implemented the following way:

1) ''Host group' element will support new option "Show" having two possible values: 'Host group' and 'Host group elements'

In case if 'Host group elements' option selected:

2) Host Group is a map region of NxM pixels or size of an entire map

3) All hosts of the selected host group will be displayed in the defined region.

Host Group label will be used for each individual host displayed in the region. No border is displayed for the region, no region-level labels supported.

4) Initially the only supported placing algorithm will be 'left->right, top->bottom' evenly aligned. Hosts must not intersect if possible.

Map grid alignment is ignored.

5) All displayed hosts will use icons defined for the Host Group

6) Host Group element can be linked to another map element. In this case the link will be automatically displayed for all elements of the Host Group.

Host Group Region to Host Group Region linkage is allowed and will be displayed as a line connecting centers of these regions. It might be improved later on.

7) New fields should be added to table 'sysmaps_elements':

FIELD |elementsubtype |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |areatype |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |width |t_integer |'200' |NOT NULL |ZBX_SYNC
FIELD |height |t_integer |'200' |NOT NULL |ZBX_SYNC
FIELD |viewtype |t_integer |'0' |NOT NULL |ZBX_SYNC

elementsubtype: 0 - host group, 1 - host group elements
areatype: 0 - fit to map, 1 - custom size
viewtype: 0 - 'left->right, top->bottom, evenly aligned'

8) API must be updated to support new element type as well as the new fields. Affected API methods: map.create, map.update, map.addElement, map.updateElement and map.get.

9) Map XML import/export must be updated accordingly

Requirements update:

  • Map areas are aligned by same algorithm as icons (center align)
  • between two maps, only one link is drawn, disregarding host group hosts
  • between element and area, link is drawn for each host group host
  • in configuration, area contains only one host group icon
  • in configuration, status messages are not shown and macros are not calculated
  • in configuration, only iconid_off is used to represent elements
  • when select triggers for link, first popup is removed
Comment by richlv [ 2011 Feb 24 ]

when editing a map, how will such an element be displayed ?
how will this element be movable around the map by dragging (as in, which areas will start drag action) ?
what happens if two hostgroup areas overlap ?
how will dimensions of such an element be specified (only x/y coordinates or draggable on the map) ?
will object x/y coordinate represent left topmost corner of the area ?
what happens if all objects don't fit in the chosen area ?
what spacing will be used for individual hosts ? will it be taken from the saved map grid or will it be possible to specify per hostgroup area ?

Comment by Alexander Vladishev [ 2011 Feb 25 ]

Rich, the logic will be very similar to processing of images:

>when editing a map, how will such an element be displayed ?
>what spacing will be used for individual hosts ? will it be taken from the saved map grid or will it be possible to specify per hostgroup area ?

Evenly distributed, there is a sketch.

>how will this element be movable around the map by dragging (as in, which areas will start drag action) ?
>what happens if two hostgroup areas overlap ?
>how will dimensions of such an element be specified (only x/y coordinates or draggable on the map) ?
>will object x/y coordinate represent left topmost corner of the area ?
>what happens if all objects don't fit in the chosen area ?

Same logic as for element type 'Image'. No processing of complex cases, it is up-to an user to deal with overlapping.

<Richlv> hmm. is there some special logic for auto-aligning images ? or would host elements then just start overlapping if they don't fit neatly in the area ?

Comment by richlv [ 2011 Feb 25 ]

xml import/export ?

Comment by Konstantin Buravcov (Inactive) [ 2011 Jun 20 ]

(14) [GUI] Buttons "remove" and "-" does not work for me in IE8. Same is for links.

<KB> Seems like a bug in IETester. Works in normal IE8. CLOSED.

Comment by Konstantin Buravcov (Inactive) [ 2011 Jun 20 ]

(15) [GUI] Trying to select host from a popup (creating element with type "host") gives me "'null' is null or not an object" in IE8

<KB> Seems like a bug in IETester. Works in normal IE8. CLOSED.

Comment by Alexey Fukalov [ 2011 Jul 07 ]

trunk 20458

Comment by richlv [ 2011 Aug 01 ]

(51) regression - map border is not drawn anymore. see ZBX-3999

Comment by richlv [ 2011 Aug 03 ]

also see ZBX-4009 regarding loss of macro resolving in the edit mode (related to 45)





[ZBXNEXT-673] Support of users scripts on Zabbix Agent and IPMI-based remote commands Created: 2011 Feb 24  Updated: 2011 Dec 22  Resolved: 2011 Mar 08

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Agent (G), Frontend (F), Server (S)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexander Vladishev Assignee: Alexei Vladishev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate

 Description   

Currently Zabbix supports execution of user scripts (defined in WEB GUI) on Zabbix Server or IPMI only. Also it would be nice to have an option for execution of the scripts on monitored hosts by Zabbix agents.



 Comments   
Comment by Alexander Vladishev [ 2011 Feb 24 ]

The following changes must be implemented:

1) Database changes for table 'scripts', new fields must be added:

FIELD |type |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |execute_on |t_integer |'1' |NOT NULL |ZBX_SYNC

type: 0 - script, 1 - IPMI
execute_on (script only): 0 - execute on agent, 1 - execute on Zabbix server

2) User script configuration form must be modified according to provided sketch.

3) Database patch for converting existing IPMI commands to new DB structure

4) Server side must be modified to support execution of scripts by Zabbix agents.

5) Commands executed by Zabbix Agents will be based on system.run[], which can be enabled or disabled by EnableRemoteCommands

6) Server must validate Host Group defined for a Script. If a host is not in the specified host group, the command will not be executed on the host.

7) API methods script.get, script.create and script.update will be updated to support new fields 'type' and 'execute_on'.

Comment by richlv [ 2011 Feb 24 ]

does 6 mean ability to specify single group only or multiple groups ?

Comment by Alexander Vladishev [ 2011 Feb 25 ]

Just one host group. (6) fixed.

Comment by Alexey Fukalov [ 2011 Mar 08 ]

trunk 18311





[ZBXNEXT-672] Advanced options for remote commands Created: 2011 Feb 24  Updated: 2011 Dec 22  Resolved: 2011 May 13

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Agent (G), Frontend (F), Server (S)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexander Vladishev Assignee: Alexey Fukalov
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug_1.png     PNG File bug_11.png     PNG File bug_13.png     PNG File bug_2.png     PNG File bug_3.png     PNG File bug_3b.png     PNG File bug_5.png     PNG File bug_6.png    

 Description   

Remote command should be extended to support number of additional options:

  • remote commands based on Telnet, SSH and Zabbix Agent commands
  • use of existing user scripts for automated remote commands


 Comments   
Comment by Alexander Vladishev [ 2011 Feb 24 ]

The following changes must be implemented:

1) Database changes for tables opcommand_hst and opcommand_grp. New fields:

FIELD |type |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |scriptid |t_id | |NULL |ZBX_SYNC |3|scripts | |RESTRICT
FIELD |execute_on |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |port |t_varchar(64) |'' |NOT NULL |ZBX_SYNC
FIELD |authtype |t_integer |'0' |NOT NULL |ZBX_SYNC
FIELD |username |t_varchar(64) |'' |NOT NULL |ZBX_SYNC
FIELD |password |t_varchar(64) |'' |NOT NULL |ZBX_SYNC
FIELD |publickey |t_varchar(64) |'' |NOT NULL |ZBX_SYNC
FIELD |privatekey |t_varchar(64) |'' |NOT NULL |ZBX_SYNC

type: 0 - script, 1 - IPMI, 2 - SSH, 3 - Telnet, 4 - user script
execute_on: 0 - execute on agent, 1 - execute on Zabbix server

During development process, we decided to change schema requirements:
All new fields are moved to opcommand table leaving opcommand_hst and opcommand_grp only with operation id and hostid/groupid.

other fields have same definition as for table 'items'

2) User script cannot be removed if used for actions. A clear error message should be given.

3) Action permissions must take into account user scripts.If no RW permissions for a user script, the action is not accessible in the GUI.

4) Selection of user scripts in action form should respect permissions.

Can be a security issue if a script is for execution on RW hosts.

5) Action form must be modified according to provided sketch.

6) Database patch for converting existing IPMI commands to new DB structure

7) For Telnet and SSH checks username, password are used for authentication purposes. For SSH authtype, publickey, privatekey can be used as well.

8) Username, password,publickey, privatekey must support user macros. The macros are based on the target host.

9) Server side must be modified to support new command types.

10) Commands executed by Zabbix Agents will be based on system.run[], which can be enabled or disabled by EnableRemoteCommands

11) Server must validate Host Groups defined for a Script. If a host is not in the specified host group, the command will not be executed on the host.

Comment by Alexander Vladishev [ 2011 Feb 25 ]

12) API methods action.get, action.create and action.update will be extended to support new opcommand_hst/opcommand_grp fields.

Comment by Alexey Fukalov [ 2011 Apr 08 ]

trunk 18964

Comment by richlv [ 2011 Apr 08 ]

database changes have not been implemented according to the specification (which in this case probably means that specification was never updated as it was changed during the development...)





[ZBXNEXT-647] Automatic population of hardware profiles Created: 2011 Feb 02  Updated: 2011 Dec 22  Resolved: 2011 May 09

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: 1.9.1 (alpha)
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexander Vladishev Assignee: Unassigned
Resolution: Fixed Votes: 4
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug_11.png     PNG File bug_16.png     PNG File bug_22.png     PNG File bug_24.png     PNG File bug_26.png     PNG File bug_27.png     PNG File bug_4.png     PNG File bug_5.png     PNG File bug_9.png     XML File import_test_host.xml    
Issue Links:
Duplicate
is duplicated by ZBXNEXT-616 Automatically fill host profile data ... Closed
is duplicated by ZBXNEXT-63 Automate Inventory Population by SNMP... Closed

 Description   

Zabbix should automatically fill host profiles by the information collected by Zabbix Server and Proxies. It would be nice to have both automatic and manual filling of profile details or a combination of both.



 Comments   
Comment by richlv [ 2011 Feb 02 ]

also see ZBXNEXT-616 and ZBXNEXT-294
additional keyword : inventory

Comment by Alexander Vladishev [ 2011 Feb 02 ]

1. Database changes:

Table 'items':

FIELD |profile_link |t_integer |'0' |NOT NULL |ZBX_SYNC

profile_link: pointer to one of profile fields, 1-N. 0 - not used for profiles. Numbering will match field number in table structure.

Table 'hosts_profiles':

FIELD |profile_mode |t_integer |'0' |NOT NULL |ZBX_SYNC

profile_mode: 0 - manual, 1 - automatic

2. Configuration of item form will be extended to have an optional selection of a host profile field. If set, the item value will overwrite information stored in the corresponding profile field (for example, Device type, MAC Address, etc)

The selection will be available for items of any type except of value type 'Log'.

It will look like:

Use in profiles [X]
Update profile field [<here is a drop-down of all profile fields>]

This selection will be located before Description field

3. Template linkage should be extended to verify that there are no two items pointing to the same profile field.

4. It should be possible to change profile linkage even if an item is linked to a template.

5. Host profile may have the following states: Disabled - no host profile information available, Manual - manually entered host profile information, Automatic - linked fields are updated automatically, other fields can be manually modified.

The profile state is configurable on per host level as it is in 1.8.x

6. Host mass-updated will be extended to support setting of different profile modes (manual, automatic, disabled).

7. Not supported and Disabled items are treated as a normal items, i.e. the linkage will be preserved.

8. Item prototypes are not affected

9. If a host profile in Automatic mode and a profile field has a linkage, the profile field should be disabled, show actual value and display information about linked item (as a item name linked to configuration of the item).

----------------------------------
TODO later:

N. New report will be introduced to display inventory information and number of hosts grouped by one of inventory fields.For example, grouping by OS: Linux: 450 hosts, Windows: 5 hosts.

The existing Inventory report will be extended to support this. Additional drop-down "Aggregate by" will be introduced to select a host profile field for grouping purposes. Only fields having varchar() type can be used due to performance considerations. By default, drop-down selection is set to <no aggregation>.
---------------------------------- will be introduced later

Comment by richlv [ 2011 Feb 03 ]

maybe "Update profile field" ? just "Update profile" might be confusing

additional data, supported by the linux agent, will be available as items, right ?

Comment by richlv [ 2011 Feb 28 ]

4. seemingly split out as ZBXNEXT-677

Comment by richlv [ 2011 Feb 28 ]

7. also listed at ZBXNEXT-676

Comment by Alexander Vladishev [ 2011 Apr 19 ]

(1) [DB] Error while upgrading database (MySQL):
ERROR 1136 (21S01) at line 260: Column count doesn't match value count at row 1

<KB> Fixed
<sasha> also fixed errors in PostgreSQL upgrade path. Please review.

ERROR: insert or update on table "opgroup" violates foreign key constraint "c_opgroup_1"
DETAIL: Key (operationid)=(5) is not present in table "operations".
UPDATE 0
ERROR: insert or update on table "optemplate" violates foreign key constraint "c_optemplate_1"
DETAIL: Key (operationid)=(6) is not present in table "operations".
UPDATE 0

<KB> Looks good, CLOSED.

Comment by Alexander Vladishev [ 2011 Apr 26 ]

(3) [DB] Please see my changes in db schema. Now the 'profile_mode' field location after the 'hostid' field

<KB> Tested, works good. CLOSED.

Comment by Gergely Czuczy [ 2011 May 03 ]

If i may suggest, it'd be very nice, if this profile filling could work from SNMP OIDs as well.

Some information also available over snmp, a few for an example:
sysDescr.0
sysName.0
sysLocation.0
sysContact.0

And a few vendor-specific extensions, like cisco exports the running image's name, which is the software version practically.

Would be very nice if some of the profile could be populated using SNMP information.

Comment by richlv [ 2011 May 03 ]

i believe that any item would be able to be set as a source for profile field data, which does not exclude snmp items

Comment by Konstantin Buravcov (Inactive) [ 2011 May 09 ]

Merger to trunk rev 19442





[ZBXNEXT-636] improve zabbix login screen Created: 2011 Jan 26  Updated: 2012 Apr 28  Resolved: 2011 Feb 21

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 1.9.1 (alpha)
Fix Version/s: 2.0.0

Type: Change Request Priority: Major
Reporter: Artem Suharev (Inactive) Assignee: Artem Suharev (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-2873 some elements of dark orange theme ar... Closed

 Comments   
Comment by Alexander Vladishev [ 2011 Feb 03 ]

1. Restyle login screen (API wrapper)
2. Restyle global search input
3. GUI table list redesign
4. Fix GUI themes

Comment by Artem Suharev (Inactive) [ 2011 Feb 21 ]

Merged

Comment by Oleksii Zagorskyi [ 2012 Apr 28 ]

Fixed actually in v 1.9.2





[ZBXNEXT-628] Support of different label format for different types of map elements Created: 2011 Jan 19  Updated: 2011 Dec 22  Resolved: 2011 Feb 10

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexei Vladishev Assignee: Artem Suharev (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

It would be nice to specify icon label formats for each element type (host, host group, image, map, trigger) individually.



 Comments   
Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 09 ]

(2)
Documentation:
New parameters should be described here in "Zabbix API changes from 1.8 to 2.0": http://www.zabbix.com/documentation/2.0/manual/appendix/api/changes_1.8_-_2.0

Docs improved (Aly)
<rich> changed the layout slightly, please review
<konstantin> looks good!

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 10 ]

Testes and reviewed.

Comment by Artem Suharev (Inactive) [ 2011 Feb 10 ]

Merged





[ZBXNEXT-626] Remembering of map grid options for each map Created: 2011 Jan 19  Updated: 2011 Dec 22  Resolved: 2011 Feb 11

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexei Vladishev Assignee: Konstantin Buravcov (Inactive)
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates ZBXNEXT-404 save chosen map grid with the map Closed

 Description   

Map grid options (grid size, show/hide, align to grid) should be stored per each map individually.



 Comments   
Comment by Vladimir Barcevsky (Inactive) [ 2011 Feb 03 ]

sorry

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 07 ]

Added API parameters and basic unit tests for map creation using JSON

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 07 ]

Added saving new options through GUI and a Selenium test for it

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 08 ]

API Documentation updated:
http://www.zabbix.com/documentation/2.0/manual/appendix/api/map/get?&#example
http://www.zabbix.com/documentation/2.0/manual/appendix/api/map/create

Comment by richlv [ 2011 Feb 08 ]

what about http://www.zabbix.com/documentation/2.0/manual/appendix/api/changes_1.8_-_2.0 ?

konstantin> page updated

rich> thanks

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 08 ]

Import/export works with new parameters. When importing from 1.8, they are set to default values. Issue can be marked as resolved, when DB patches are checked.

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 09 ]

Development branch: ZBXNEXT-626

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 10 ]

Merged to trunk rev 17615

Comment by richlv [ 2011 Feb 11 ]

changelog entry seems to be missing

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 11 ]

Added changelog entry

Comment by richlv [ 2011 Feb 11 ]

changelog entry received





[ZBXNEXT-618] No IP Address Info for (read only users) Created: 2011 Jan 13  Updated: 2011 Dec 22  Resolved: 2011 Jan 17

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.9.1 (alpha), 1.9.2 (alpha), 1.9.3 (alpha), 2.0.0
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Blocker
Reporter: Sol Arioto Assignee: Alexei Vladishev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Ubuntu 10.04, Mysql5, zabbix 1.8.3



 Description   

I've just noticed recently; because i never typically log in as a basic user with only read access
information is limited; if a user wanted to know the IP ADDRESS of a host that went down they
would have to rely on the alert sent VIA email then the web interface.

I believe one of two ways would help fix this would be to either allow

{IPADDRESS} macro in trigger name example "Link to {HOSTNAME} Down @ {IPADDRESS}

"
this would show in the dashboard
or
allow the configuration>host (hosts.php) file browse-able; but limited to only read only with less information [Table Names] could include ( Name | DNS | Ip Address | Status | Availability )

Allowing the info in the inventory section might also make more use of that area..



 Comments   
Comment by richlv [ 2011 Jan 13 ]

this will be fixed in 2.0 by introducing monitoring -> hosts

Comment by Sol Arioto [ 2011 Jan 17 ]

Fix per version 2.0





[ZBXNEXT-592] Confirmation dialog for scripts Created: 2010 Dec 22  Updated: 2011 Jan 07  Resolved: 2011 Jan 03

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Alexey Fukalov Assignee: Alexey Fukalov
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Alexey Fukalov [ 2010 Dec 22 ]

In Script configuration two new fields are added:
Description - optional general script description for admins.
Question - optional question that appears in confirmation dialog before script execution. If question is empty, no confirmation dialog appears.

Confirmation dialog have two buttons: Execute and Cancel.

Comment by Alexey Fukalov [ 2010 Dec 27 ]

Two new fields added to scripts table:
description - text
question varchar(255)

Dialog minimum width is 200px, maximum width is 600px, if question is wider and has white spaces, it wraps.

Form redesigned according to scetch.

Comment by Alexey Fukalov [ 2011 Jan 03 ]

Buttons form row wider than form

Comment by Alexey Fukalov [ 2011 Jan 06 ]

trunk 16676

Comment by Oleksii Zagorskyi [ 2011 Jan 06 ]

FreeBSD8.1, MySQL 5.5
hmm. when i try to open the script settings or create script i receive the error:

include(./include/forms/script.edit.php) [<a href='function.include'>function.include</a>]: failed to open stream: No such file or directory[/usr/local/www/zabbix/include/classes/class.cgetform.php:41]
include() [<a href='function.include'>function.include</a>]: Failed opening './include/forms/script.edit.php' for inclusion (include_path='.:/usr/local/share/pear')[/usr/local/www/zabbix/include/classes/class.cgetform.php:41]

Comment by Oleksii Zagorskyi [ 2011 Jan 06 ]

and... php5-5.3.3_2

Comment by Alexei Vladishev [ 2011 Jan 07 ]

I see this error as well in trunk. It seems that merge went wrong for some reason. To be fixed asap.

Comment by Alexey Fukalov [ 2011 Jan 07 ]

Should be fixed. Some files didn't commit for some reason.





[ZBXNEXT-575] New database and GUI design for remote commands Created: 2010 Dec 07  Updated: 2012 Nov 20  Resolved: 2011 Feb 14

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: Change Request Priority: Major
Reporter: Alexander Vladishev Assignee: Artem Suharev (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug_28.png     PNG File bug_30.png     PNG File bug_31.png     PNG File bug_35.png     JPEG File bug_36.jpg     PNG File bug_44.png     PNG File bug_45.png     PNG File error-in-query.png     JPEG File operations.jpg     JPEG File screenshot-1.jpg     JPEG File screenshot-2.jpg    

 Comments   
Comment by Oleksii Zagorskyi [ 2010 Dec 17 ]

perhaps it makes sense to run simultaneously with ZBX-3055

Comment by Alexey Fukalov [ 2011 Jan 31 ]

fixed 1, 5, 7
changed default value for operations table esc_step_from field to 1

Comment by richlv [ 2011 Jan 31 ]

in the light of this, it would be nice to consider ZBXNEXT-643 for possible later implementation

Comment by richlv [ 2011 Jan 31 ]

"Ne oparations defined" - sounds more dutch to me

Comment by Konstantin Buravcov (Inactive) [ 2011 Feb 11 ]

(43)
Need to update /tests/data/data_test.sql or after merge all hudson builds will fail. Currently importing this sql gives: ERROR 1054 (42S22) at line 114: Unknown column 'object' in 'field list'

Comment by richlv [ 2011 Apr 09 ]

adding a "trigger value = problem" condition by default when creating a new action was not done, reported as ZBX-3704

Comment by richlv [ 2012 Nov 20 ]

this resulted in a minor regression in it service configuration : ZBX-5878





improvements to the user macro functionality (ZBXNEXT-353)

[ZBXNEXT-518] add usermacro support in snmp port field Created: 2010 Sep 22  Updated: 2017 May 31  Resolved: 2011 Feb 04

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request (Sub-task) Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File supported macros 2.0.txt    

 Description   

usermacros should be supported in snmp port field to allow for easy customisation of the port on lower level



 Comments   
Comment by Alexander Vladishev [ 2011 Feb 01 ]

Attached list of supported macros after "multiple interfaces" implementation

Comment by Alexander Vladishev [ 2011 Feb 04 ]

Available in version pre2.0.





[ZBXNEXT-512] unknown events should be redesigned Created: 2010 Sep 17  Updated: 2017 May 31  Resolved: 2010 Nov 03

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request Priority: Major
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 2
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The problems we currently have with UNKNOWN events:

(1) Complicated logic for acknowledges. For instance, if we have PROBLEM -> UNKNOWN -> PROBLEM -> UNKNOWN -> PROBLEM, then acknowledging one PROBLEM event has to copy acknowledges to other PROBLEM events as well.

(2) PROBLEM -> UNKNOWN -> PROBLEM is essentially a single PROBLEM.

(3) When deciding if we need to add an event or not, we have to look into "events" table which slows down processing.

(4) Complicated logic for calculating durations in GUI.

(5) UNKNOWN events can mean different things that cannot be distinguished between. For instance: a trigger has just been created, one of the items became unsupported, trigger cannot be evaluated, a server has just been restarted.

(6) UNKNOWN events hide the previous meaningful status: if a trigger was in the PROBLEM state before becoming UNKNOWN, then we have to look for the PROBLEM state manually.



 Comments   
Comment by Oleksii Zagorskyi [ 2010 Sep 17 ]

Regarding the transfer all triggers status to UNKNOWN when you restart the zabbix_server (5).
For example I have to sometimes restart zabbix_server.
For example I have a Item with key "eventlog[System,,,,888]". Data for this Item may come once in six months (real).
I would like to see a Trigger for this Item in the state of OK, but not UNKNOWN during these six months.
This is true for any historical data that do not come regularly, but sometimes.
What do you say?
p.s. I do not want to use the function "nodata"

Comment by Aleksandrs Saveljevs [ 2010 Sep 17 ]

After the new design is implemented, users in the GUI will only see OK and PROBLEM events. If something is wrong with the trigger (everything that would cause a generation of UNKNOWN events in the current design), then something like a "?" mark will be shown next to the trigger value: e.g., "OK". So after restarting zabbix_server you will see "OK" rather than UNKNOWN.

Comment by Alexander Vladishev [ 2010 Nov 03 ]

Available from version pre1.9.1, r15246.





[ZBXNEXT-511] items should have a description field Created: 2010 Sep 16  Updated: 2011 Dec 22  Resolved: 2011 Apr 05

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Server (S)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: New Feature Request Priority: Major
Reporter: Aleksandrs Saveljevs Assignee: Aleksandrs Saveljevs
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug_14.png     PNG File bug_15.png     PNG File bug_2.png     PNG File bug_3.png     PNG File bug_4.png     PNG File bug_5.png    

 Description   

Similarly to triggers that have comments and maintenances that have descriptions, items should have descriptions too.



 Comments   
Comment by richlv [ 2010 Sep 16 ]

partially duplicates ZBXNEXT-337 and ZBX-2755

Comment by Alexey Fukalov [ 2010 Sep 22 ]

fixed

Comment by Aleksandrs Saveljevs [ 2010 Sep 23 ]

Available in development branch svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description.

Comment by Aleksandrs Saveljevs [ 2010 Sep 29 ]

Some of the changes to be made to database schema:

  • items.description => items.name
  • items.description_details => items.description (also blob => text)
  • triggers.description => triggers.name
  • triggers.comments => triggers.description (also blob => text)
  • maintenances.description: blob => text
  • media_type.description => media_type.name

Will have to check whether other tables should be updated as well.

Comment by richlv [ 2010 Sep 29 ]

item multiplier/formula is very confusing, but it should also be taken in context of xml export, where field names sometimes can be matching, and sometimes - not

Comment by Konstantin Buravcov (Inactive) [ 2010 Oct 19 ]

DB patches and schema committed to svn://svn.zabbix.com/branches/dev/zbxnext-511-item-description

Comment by richlv [ 2011 Jan 25 ]

looks like this was never finished/merged ?

Comment by Aleksandrs Saveljevs [ 2011 Jan 25 ]

It will have to be done once again.

Comment by Alexander Vladishev [ 2011 Feb 24 ]

All right, we have to finish this task.

Here is list of things to be done:

  • the branch should probably be recreated, it is just too old
  • items.description => items.name, items.description (text)
  • add support of {ITEM.DESCRIPTION<1-9>}
  • GUI form for items should be changed (Description -> Name)
  • GUI item mass updated should be changed as well (add support for the new Description field)

Re-naming of other table fields is out of scope.

Comment by richlv [ 2011 Mar 22 ]

(1) something to pay attention to : when attempting to create a discovery rule w/o name error message says :

Incorrect value for field "description".

the field is named "Name"

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(2) Undefined index when creating an item. The error message about item key is not helpful either. See bug_2.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(3) The description text area does not look good in mass update. See bug_3.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(4) When saving an item prototype, description is saved as its name. See bug_4.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(5) On the trigger prototype page, it shows discovery rule's description instead on name. See bug_5.png.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

(6) Saving a trigger without name complains about incorrect value for field "description".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 30 ]

Documented

{ITEM.DESCRIPTION}

and

{ITEM.KEY}

macros at http://www.zabbix.com/documentation/2.0/manual/appendix/macros/supported_by_location.

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(7) In trigger list, triggers that are created by low-level discovery from trigger prototypes have links to discovery rules. These links are descriptions of discovery rules, not their names.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(8) In "Latest data" filter it says: "Show items with description like".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(9) I propose we replace 'description_expanded' with 'name_expanded'. Similarly, variable $item_description should be renamed to $item_name. Also, $max_desc_len should be $max_name_len.

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(10) In item list, filtering by name yields "Undefined index: filter_name[/home/asaveljevs/zabbix-svn/branches/dev/ZBXNEXT-511/frontends/php/items.php:860]".

<Vedmak> FIXED
<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(11) Different issue, but configuration of discovered triggers can be accessed through "Triggers top 100" report.

<Vedmak> it's not connected to this issue
<asaveljevs> Moved to ZBX-3674. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(12) It is possible to create a trigger that references an item that does not exist.

<Vedmak> FIXED

<asaveljevs> Perfect. But since we started messing with invalid trigger expressions, could you please take a look at why we have an undefined index when switching trigger expression to "

{Zabbix server: .last(0)}

=0" (note the space in place of item key).

<Vedmak> FIXED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(13) It is possible to create a trigger that references a discovery rule. If we then click on that discovery rule in the trigger expression, we get no permissions error.

<Vedmak> it's not connected to this issue
<asaveljevs> Moved to ZBX-3674. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(14) Undefined index when accessing "Configuration" -> "Actions". See bug_14.png.

<asaveljevs> Moved to ZBX-3678. CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Mar 31 ]

(15) The popup in bar reports does not close itself when clicking on an item. See bug_15.png.

<asaveljevs> Disregard that. This problem occurs in 1.8, too.
<asaveljevs> Moved to ZBX-3676. CLOSED

Comment by Alexander Vladishev [ 2011 Apr 01 ]

Server side tested.

Comment by Aleksandrs Saveljevs [ 2011 Apr 05 ]

(16) [API] Should rename "description" to "name" on http://www.zabbix.com/documentation/2.0/manual/appendix/api/item/get. The examples with "description" are probably still valid, but they are not as natural anymore.

<Vedmak> changed, but as mentioned, it was valid

<asaveljevs> I have also renamed "description" to "name" in "sortfield" row. If you like it, please close this comment and merge the branch.

<Vedmak> Like it, CLOSED

Comment by Alexey Fukalov [ 2011 Apr 05 ]

trunk 18905





[ZBXNEXT-502] Need a feature to easily find new lines when editing the localization Created: 2010 Aug 31  Updated: 2011 Mar 16  Resolved: 2011 Mar 16

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 1.8.4
Fix Version/s: 2.0.0

Type: Change Request Priority: Minor
Reporter: Oleksii Zagorskyi Assignee: Alexei Vladishev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

last trunk rev.



 Description   

One feels that the recently improved interface to create a localization, but here to update the localization of something missing.

Well, I like never translate new added lines in the interface Zabbix because they find very difficult - almost impossible. I am using for this TurtoiseMerge utility . I opened an old file and a new downloaded and easy to move only on the changes.
I mean, that if the interface on the locale edit page was added the navigation for added and a blank value, then virtually anything can be done directly in the interface without using other utility.

I think you can add a up and down buttons (centered always on top) to scroll the window and switch the input focus on the rows that are empty or filled in by default value (english usual). Thus, these lines can highlight a different color.



 Comments   
Comment by richlv [ 2010 Aug 31 ]

it is planned to move to gettext for 2.0, so it probably wouldn't make much sense to put lot of work into polishing current custom interface.
once gettext is used, it should be possible to use all kinds of tools, including poedit, pootle etc

Comment by Oleksii Zagorskyi [ 2010 Aug 31 ]

I have already used Pootle - this is nice solutions. I vote to move to it

Comment by richlv [ 2011 Mar 16 ]

with gettext for 2.0, can this be closed ?

Comment by Oleksii Zagorskyi [ 2011 Mar 16 ]

Of course, it seems "Fixed" for 2.0 resolution is optimal.
Closed !





[ZBXNEXT-457] Support of nanoseconds for history tables Created: 2010 Jul 23  Updated: 2023 Mar 04  Resolved: 2010 Aug 02

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F), Proxy (P), Server (S)
Affects Version/s: 2.0.0
Fix Version/s: 2.0.0

Type: Change Request Priority: Major
Reporter: Alexander Vladishev Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File report-457-windows-agent-bug.txt    
Issue Links:
Duplicate
is duplicated by ZBX-2776 Macros in the notifications are calcu... Closed
is duplicated by ZBX-5341 mail actions will send the first and ... Closed

 Description   

If the historical information (for example log monitoring) comes very intensively, i.e. some values in a second, macro

{ITEM.VALUE}

work incorrectly.



 Comments   
Comment by Oleksii Zagorskyi [ 2010 Jul 29 ]

Alexander, I was testing a nano-second and I'm starting to like it.
Can you also compile agent for windows for testing? I want to hurry up to test it.

Comment by Alexander Vladishev [ 2010 Jul 30 ]

Windows agents is available in svn://svn.zabbix.com/branches/dev/zbxnext-457 branch.

Comment by Oleksii Zagorskyi [ 2010 Jul 30 ]

Bug founded for windows agent. Windows not like nanoseconds IMHO
i attached text file for better view

Comment by Aleksandrs Saveljevs [ 2010 Jul 30 ]

Can we add some dummy nanoseconds if the clock+ns pairs turn out to be identical? In the attachment above, if we are about to send several items with clock=1280483969 and ns=711000000, can we change the second ns to 711000001, etc.? We will not get real nanosecond precision anyway.

Comment by Alexei Vladishev [ 2010 Jul 30 ]

Good point!

Comment by Oleksii Zagorskyi [ 2010 Jul 30 ]

FreeBSD8.0 also not get REAL nanosecond (maybe is normally - i don't now).
Zabbix server calculated only MICROsecond !!!
If i send with zabbix_sender (not this 457) simple data server write to db 'ns':
147491000
186395000
166976000
186594000
395702000
995246000
474586000
Last three digits - always ZERO.
It's just simply information - not bug.

Comment by Alexei Vladishev [ 2010 Jul 30 ]

Note that not all platforms support nanoseconds. It is a platform specific feature.

Comment by Alexander Vladishev [ 2010 Jul 30 ]

Added support nanoseconds for BSD and Linux platforms. Windows later.

Comment by Alexander Vladishev [ 2010 Jul 30 ]

r13724 - added support of nanoseconds under Windows.

Comment by Oleksii Zagorskyi [ 2010 Jul 31 ]

Tested. Now it seems everything is normal - windows agent generates the 'ns' of 9 digits. FreeBSD 8.0 also - 9 digits.
But he wanted to draw attention - the old agent (not this ZBXNEXT-457) sends the data without the 'ns' and in this case, the zabbix server does not compute the 'ns' and always write ZERO into database 'ns' value. End problem in result as in my previous example.
I think need to support compatibility with older agents in this regard.

Comment by Alexander Vladishev [ 2010 Aug 02 ]

Added support of nanoseconds in ver. pre2.0 r13742.

Comment by Oleksii Zagorskyi [ 2012 Jan 29 ]

Just for record: available in first alpha 1.9.0

Comment by Oleksii Zagorskyi [ 2023 Feb 28 ]

Just an update after ... 11 years

Now zabbix server generates nanoseconds consequently with step just 1, not 9 digits as before.
So, when sending data by zabbix_sender with timestamps and it's the same for a few values of an item key, nanoseconds will be 1 byte values "0" ..... "N".

If send the same data again, it will generate SQL errors, which is expected in zabbix 6.0 due to primary keys (itemid-clock-ns):

227944:20230228:162907.374 [Z3008] query failed due to primary key constraint: [1062] Duplicate entry '42741-1677593860-1' for key 'history_str.PRIMARY'
227944:20230228:162907.374 skipped 1 duplicates
227944:20230228:162907.374 [Z3008] query failed due to primary key constraint: [1062] Duplicate entry '42741-1677593860-2' for key 'history_str.PRIMARY'
227944:20230228:162907.374 skipped 1 duplicates
227944:20230228:162907.375 [Z3008] query failed due to primary key constraint: [1062] Duplicate entry '42741-1677593860-3' for key 'history_str.PRIMARY'
227944:20230228:162907.375 skipped 1 duplicates
227944:20230228:162907.375 [Z3008] query failed due to primary key constraint: [1062] Duplicate entry '42741-1677593860-4' for key 'history_str.PRIMARY'
227944:20230228:162907.375 skipped 1 duplicates

<sasha> This is because of the unique primary keys added in scope of ZBXNEXT-6921. Such history values will be re-saved with an incremented "ns" field value.

 

<zalex_ua> That's right and that's ok. I left the comment as just a note, it might help in future. I had a case where such SQL errors have been logged on a production installation, so we figured out that the same data with timestamps has been sent a few times by mistake.





[ZBXNEXT-286] Configuring templates does not provide good navigation/overview Created: 2010 Feb 18  Updated: 2014 Jan 14  Resolved: 2014 Jan 14

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Change Request Priority: Minor
Reporter: svenw Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: frontend, trivial, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

i am editing the items of a template, and i get a navigation bar like this:

Templates list Applications (0) Triggers (28) Graphs (10) Template: Template_xxx_Linux

whatever category (items/triggers/..) i edit, this display changes. i never have a link to modify the template itself (like template name) from there.

i'd suggest having a fixed line there, with elements in fixed order, just current view being no link and bold or smth.

also the page titel "Configuration of items" could mention the context like "configuration of items of Template_Linux"



 Comments   
Comment by richlv [ 2010 Mar 31 ]

note that displayed items are affected by the filter and subfilter, thus "configuration of items of Template_Linux" might not be feasible - and would be visible in the row header and filter itself already

Comment by Marc [ 2013 Dec 22 ]

Isn't it already implemented?

Comment by richlv [ 2014 Jan 13 ]

this is available now, but to close this issue we should find out which exact version offered this functionality

Comment by Oleksii Zagorskyi [ 2014 Jan 14 ]

note - it has been implemented in 2.0.0 !

Comment by richlv [ 2014 Jan 14 ]

should be fixed in 2.0.0, closing





Generated at Thu Mar 28 18:20:39 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.