[ZBX-4015] Persistent Cross Site Scripting Vulnerabilities Created: 2011 Aug 04  Updated: 2020 Jul 16  Resolved: 2011 Dec 08

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.5
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Defect (Security) Priority: Blocker
Reporter: Martina Matari Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: security
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Debian GNU/Linux 5.0.8 (Lenny)
Apache 2.2.16
PHP 5.3.3

Tested with:
Mozilla Firefox 5.0


Attachments: PNG File 1.png     PNG File 2.png     PNG File 3.png     PNG File 4.png     JPEG File link_indicator.jpg     JPEG File monitoring_dashboard.jpg     JPEG File monitoring_maps.jpg     JPEG File timeperiod.jpg     JPEG File triggers_items.jpg    
Issue Links:
Duplicate
is duplicated by ZBX-4413 nbsp in "event generation" dropdown Closed

 Description   

These URL's are vulnerable to persistent XSS attacks due to improper sanitation of gname variable when creating user and host groups.

URL:
hostgroups.php
usergrps.php

Vulnerable parameter:
gname

Method:
POST

Injected:
"</options><script>alert('XSS')</script>

Persists in:
http://test/zabbix/hostgroups.php
http://test/zabbix/users.php
http://test/zabbix/hosts.php?form=update&hostid=N (where N is a valid hostid)
http://test/zabbix/scripts.php?form=1&scriptid=N (where N is a valid scriptid)
http://test/zabbix/maintenance.php



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 02 ]

RESOLVED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 29 ]

Merged to /branches/1.8 revision r23578.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 29 ]

(4) Fixed another issue in /branches/dev/ZBX-4015 r23588. Please review.

<sasha> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 29 ]

(5) Added a fix for the trunk to /branches/dev/ZBX-4015-trunk. Please review.

<sasha> CLOSED

Comment by richlv [ 2011 Dec 01 ]

(6) see ZBX-4413 for a regression, caused by this

<pavels> RESOLVED in branches/dev/ZBX-4015 r23697.

<richlv> wouldn't this change it functionally (remove those spaces, making it look worse ?), and i believe spacing at the end of the line has not been updated according to the guidelines

  • $type_select->additem(TRIGGER_MULT_EVENT_ENABLED,S_NORMAL.SPACE.'+'.SPACE.S_MULTIPLE_PROBLEM_EVENTS,(($type == TRIGGER_MULT_EVENT_ENABLED)? 'yes':'no'));
    + $type_select->additem(TRIGGER_MULT_EVENT_ENABLED,S_NORMAL.' + '.S_MULTIPLE_PROBLEM_EVENTS,(($type == TRIGGER_MULT_EVENT_ENABLED)? 'yes':'no'));

<pavels> It doesn't change anything, I just replaced the   character with a literal space. Fixed the spacing.
<sasha> CLOSED
<richlv> huh, sorry about that "functionality" part - lack of sleep did it's part. still CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

(7) Fixed XSS in the profiler and some HTML entity issues in branches/dev/ZBX-4015-trunk. Please review.

<sasha> REOPENED
(7.1) Monitoring->Dashboard - hints
https://support.zabbix.com/secure/attachment/17578/monitoring_dashboard.jpg
(7.2) Monitoring->Maps - Element menu
https://support.zabbix.com/secure/attachment/17579/monitoring_maps.jpg

<pavels> RESOLVED.
<sasha> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 02 ]

Merged to 1.8 revision r23754.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 06 ]

Merged to trunk revision 23800.

CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 08 ]

(8) [GUI] Rich suggested, that using non ASCII characters in the code may cause problems, so I changed the HTML encoding strategy to ignore ampersands. This will allow us to use HTML encoded characters in the code.

Please review my commit to /branches/dev/ZBX-4015-trunk r23855.

REOPENED and RESOLVED.
<sasha> CLOSED

Comment by Alexander Vladishev [ 2011 Dec 08 ]

branches/dev/ZBX-4015 (1.8) Successfully TESTED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 08 ]

Updated trunk r23875 and 1.8 r23878.

CLOSED.

Comment by richlv [ 2012 Jan 03 ]

this resulted in a regression : ZBX-4506





[ZBX-3074] in item list move status column to the left Created: 2010 Oct 05  Updated: 2017 May 30  Resolved: 2012 Mar 10

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.4rc1
Fix Version/s: 1.8.10, 2.0.0rc1

Type: Incident report Priority: Minor
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: trivial, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

It has been suggested that the "Status" column in item list be moved to the left, similarly to as it was done for trigger list.



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2011 Oct 27 ]

Done. [RESOLVED]

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 02 ]

Merged to /branches/1.8 revision r22874. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 02 ]

Merged to trunk revision r22876.

Comment by Vjacheslav Shipillo (Inactive) [ 2011 Dec 01 ]

in item and trigger list move status column to the right side in trunk

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

(1) the 'Status' column in the item table should be right from the 'Application' column.

<slava> in this case it's not rollback RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

(2) I've replaced some old translation string. Please review my commit r23683. After that you can merge.
<slava> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

1.8 fix is TESTED.

Comment by richlv [ 2011 Dec 01 ]

(3) merge to 1.8 in rev 23694 added duplicate changelog entries that are not related to this branch. both merges should be carefully reviewed for other potential cases like that.
<Slava>CLOSED
also, (2) above has not been reviewed

<richlv> this has not been resolved. reason for unrelated changelog entries appearing should be found, and trunk merge should be reviewed

<Sasha> fixed in r23755 by Pave.l CLOSED

Comment by richlv [ 2011 Dec 11 ]

i was unsure what do about this issue, but i believe we can do slightly better with it

(4) changelog entry has not been added to the trunk changelog
or maybe it was... current trunk changelog contains 3 references to this issue, two of them exactly the same. 1.8 branch changelog entry for 1.8 is different from trunk changelog entry. i can't figure this all out
<Slava>This change we can found in Changes for 1.8.10rc1 . As i understand, if fixed both 1.8 and trunk version, in trunk we must write changes in 1.8 version changes ...??

<richlv> basically, the changelog part before 1.9 versions must match for trunk & 1.8 branch

<Sasha> CLOSED In rev. 25953 sections 1.8.10rc1 are identical

Comment by richlv [ 2011 Dec 12 ]

points (3), (4) and (5) must be resolved & verified still

Comment by Alexander Vladishev [ 2012 Mar 10 ]

Fixed in versions 1.8.10 r22876 and pre-1.9.10 r22875.





[ZBX-4351] French translation for 1.8.9rc1 Created: 2011 Nov 12  Updated: 2017 May 30  Resolved: 2011 Nov 22

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: None
Affects Version/s: 1.8.9rc1
Fix Version/s: 1.8.10

Type: Incident report Priority: Blocker
Reporter: Joseph Bueno Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: translation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File fr_fr.inc.php    

 Description   

I have attached an updated french translation.
It is based on 1.8.9rc1



 Comments   
Comment by richlv [ 2011 Nov 22 ]

committed to 1.8 branch in rev 23407, thanks





[ZBX-4353] update Japanese translation for 1.8.9rc1 Created: 2011 Nov 14  Updated: 2017 May 30  Resolved: 2011 Nov 22

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.9rc1
Fix Version/s: 1.8.10

Type: Incident report Priority: Blocker
Reporter: Kodai Terashima Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: translation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File zabbix-1.8.9-ja_jp.inc.php    

 Description   

update Japanese translation for 1.8.9rc1



 Comments   
Comment by richlv [ 2011 Nov 22 ]

committed to 1.8 branch in rev 23406, thanks





[ZBX-4524] Brazilian Portuguese translation update for 1.8.10 Created: 2012 Jan 09  Updated: 2017 May 30  Resolved: 2012 Jan 09

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 1.8.8, 1.8.10

Type: Incident report Priority: Trivial
Reporter: Murilo Moreira de Oliveira Assignee: Unassigned
Resolution: Incomplete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Zabbix 1.8.7 on CentOS 5.5
Postgresql 9.0.4 on CentOS 6 x64



 Description   

I've updated Brazilian Portuguese translation for zabbix 1.8.7.



 Comments   
Comment by Murilo Moreira de Oliveira [ 2012 Jan 09 ]

Incorrect description.





[ZBX-3081] The problem with logrt and russian utf8 Created: 2010 Oct 06  Updated: 2017 May 30  Resolved: 2012 Jan 03

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 1.8.3
Fix Version/s: 1.8.10

Type: Incident report Priority: Major
Reporter: Dmitry Samoylov Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: logmonitoring, utf8
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Fedora 10, PostgreSQL 8.3.4, Zabbix 1.8.3



 Description   

google translate result :
-----------------------------------------------------------------------
Monitoring logs used by logrt.

In a controlled log found this line:

Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen (/ lib64/security/pam_gnome_keyring.so): / lib64/security/pam_gnome_keyring.so: can not open shared object file: No such file or directory

In the server log file Zabbix (zabbix_server.log) on ??this line we get:

12754:20101005:151411.938 [Z3005] Query failed: [0] PGRES_FATAL_ERROR: ERROR: invalid byte sequence for encoding "UTF8": 0xd027
HINT: This error can also happen if the byte sequence does not match the encoding expected by the server, which is controlled by "client_encoding".
[Update items set lastclock = 1286277245, prevvalue = lastvalue, lastvalue = 'Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen (/ lib64/security/pam_gnome_keyring.so): / lib64/security/pam_gnome_keyring.so : can not open shared object file: No such file. ', lastlogsize = 4524, mtime = 1285754770 where itemid = 24 998;
]
12754:20101005:151411.939 [Z3005] Query failed: [0] PGRES_FATAL_ERROR: ERROR: current transaction is aborted, commands ignored until end of transaction block
[Insert into history_log (id, itemid, clock, timestamp, source, severity, value, logeventid) values ??(74,24998,1286277245,0,'', 0, 'Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen (/ lib64/security/pam_gnome_keyring.so): / lib64/security/pam_gnome_keyring.so: can not open shared object file: No such file or directory ', 0);
]
12754:20101005:151411.939 [Z3005] Query failed: [0] PGRES_FATAL_ERROR: ERROR: current transaction is aborted, commands ignored until end of transaction block
[Select distinct t.triggerid, t.type, t.value, t.error, t.expression, f.itemid from triggers t, functions f, items i where i.status not in (3) and i.itemid = f . itemid and t.status = 0 and f.triggerid = t.triggerid and f.itemid in (24 998) order by t.triggerid]

Judging from the log, the server Zabbix cut Russian letter 'l' (utf8 code 0xd0bb) in half, then attributed to the first 0xd0 single quotation mark (code 0x27) and got the code 0xd027, which is not a valid code utf8.

As a result, the lines similar to those specified in the journal Zabbix does not fall.

original :
-----------------------------------------------------------------------
???????????? ?????????? ????? ? ??????? logrt.

? ?????????????? ???? ??????????? ????? ??????:

Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen(/lib64/security/pam_gnome_keyring.so): /lib64/security/pam_gnome_keyring.so: ?????????? ??????? ??????????? ????????? ????: ??? ?????? ????? ??? ????????

? ???? ??????? Zabbix (zabbix_server.log) ?? ??? ?????? ????????:

12754:20101005:151411.938 [Z3005] Query failed: [0] PGRES_FATAL_ERROR:ERROR: invalid byte sequence for encoding "UTF8": 0xd027
HINT: This error can also happen if the byte sequence does not match the encoding expected by the server, which is controlled by "client_encoding".
[update items set lastclock=1286277245,prevvalue=lastvalue,lastvalue='Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen(/lib64/security/pam_gnome_keyring.so): /lib64/security/pam_gnome_keyring.so: ?????????? ??????? ??????????? ????????? ????: ??? ?????? ????? ?.',lastlogsize=4524,mtime=1285754770 where itemid=24998;
]
12754:20101005:151411.939 [Z3005] Query failed: [0] PGRES_FATAL_ERROR:ERROR: current transaction is aborted, commands ignored until end of transaction block
[insert into history_log (id,itemid,clock,timestamp,source,severity,value,logeventid) values (74,24998,1286277245,0,'',0,'Sep 29 14:05:53 zabbix-160 passwd: PAM unable to dlopen(/lib64/security/pam_gnome_keyring.so): /lib64/security/pam_gnome_keyring.so: ?????????? ??????? ??????????? ????????? ????: ??? ?????? ????? ??? ????????',0);
]
12754:20101005:151411.939 [Z3005] Query failed: [0] PGRES_FATAL_ERROR:ERROR: current transaction is aborted, commands ignored until end of transaction block
[select distinct t.triggerid,t.type,t.value,t.error,t.expression,f.itemid from triggers t,functions f,items i where i.status not in (3) and i.itemid=f.itemid and t.status=0 and f.triggerid=t.triggerid and f.itemid in (24998) order by t.triggerid]

???? ?? ??, ?????? Zabbix ??????? ??????? ?????? '?' (utf8 ??? 0xd0bb) ??????, ????? ? ??????? 0xd0 ???????? ?????? ????????? ??????? (? 0x27) ? ??????? ??? 0xd027, ??????? ?? ???????? ?????????? ????? utf8.

? ?????, ??????, ??????????? ?????????, ? ?????? Zabbix ?? ????????.



 Comments   
Comment by Aleksandrs Saveljevs [ 2010 Oct 06 ]

Related issue: ZBX-3043.

Comment by Alexander Vladishev [ 2012 Jan 03 ]

Already fixed in version 1.8.10. See ZBX-4424 for more details.





[ZBX-3104] Clock element with 'Host time' mode for templated screens. And other errors in screen. Created: 2010 Oct 16  Updated: 2017 May 30  Resolved: 2011 Nov 24

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.9.0 (alpha)
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Blocker
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: screens, templates
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

from trunk rev 14910. [DEV-483] added templated screens.
my DB schema always correctly updated to corresponding revision.



 Description   

Generally this is very nice feature, thanks.
(3) But try set 'Host time' mode for Clock element for templated screens without selecting Parameter field and save. In bottom of page see error in editor and also in view mode (Monitoring -> Hosts -> Screens).
(1) I think for templated screens this Parameter should be hided.

(4) For not templated screens need to check user select this parameters or not before saving. Try to save without selected host now.
(5) And in pop-up window need filter to real hosts only without templates.

(6) And second serious new problem - now after save element is not updated on screen immediately. It need to click something and return back or refresh page to see changes. The same behavior for column, line add/remove.

(7) In Monitoring -> Hosts need to add single space symbol between Hostname and DNS-name.

(2) And not related only to trunk rev 14910 (something early revision):
In not templated screens "Hostname:" is not presented in Parameter field if you open elements (Simple graph, clock and maybe other). It presented for element Graph and maybe other (but only after save and open element settings again). Try to choose Graph, Simple graph then save and open again and you will understand me.
If you open pop-up window for host selection and try to change host group then you receive error "Warning. Field [submitParent] is not integer".

heh



 Comments   
Comment by Oleksii Zagorskyi [ 2010 Oct 16 ]

Correcting:
In Monitoring -> Hosts need to add single space symbol between IP and DNS-name.

Comment by Oleksii Zagorskyi [ 2010 Oct 16 ]

Templated screen added by "+" button is not presented on Dashboard in 'Favourite screens' widget. And templated screen cannot be added in this widget by using pop-up menu.
And may be templated screen should be available directly in Monitoring -> Screens with filter like an templated graph?

<zalex> answer in the ZBX-3129
CLOSED

Comment by Oleksii Zagorskyi [ 2010 Oct 26 ]

some parts from this is issue request now is resolved in ZBX-3129
and error about "Warning. Field [submitParent] is not integer" (last my sentence in this is issue Description) is not reproducible now.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 17 ]

(1) "I think for templated screens this Parameter should be hided. "
Why? What if I want to create a screen item that displays some data from an item in the same template?

<zalex> Hmm, how the Clock element is able to display some data?
Hard to recall currently what I meant when I created this issue. I guess to hide from the GUI all related to "select "Parameter"".

As you see any templated screen resources (Graph, Plain text, Simple graph) are limited to select "Parameter" only from the same template.
Why the Clock resource doesn't limited in the same way?
I don't have strong opinion in this case. Seems currently I even don't know what "Host time" mode should display

<pavels> The host time displays the local time on the monitored host. It receives data from some special item (can't recall the key), that's why it needs the parameter field. Guess that makes (1) CLOSED.

Regarding the limited choice of items, I posted a separate commend below.

<richlv> system.localtime, i guess

<asaveljevs> Item key is "system.localtime[local]", to be more precise.

<asaveljevs> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 17 ]

(2) "If you open pop-up window for host selection and try to change host group then you receive error "Warning. Field [submitParent] is not integer". "
I'm guessing it's already fixed?

<zalex> seems is not reproducible in the Zabbix 1.9.8 r23287

<richlv> this was fixed as ZBX-3042; also, as can be seen in zalex's comment above, dated 2010 Oct 26, he noted that this is not reproducible anymore

CLOSED

Comment by Oleksii Zagorskyi [ 2011 Nov 17 ]

added numbering to description

Comment by Oleksii Zagorskyi [ 2011 Nov 17 ]

(6) and (7) seems are not reproducible in the Zabbix 1.9.8 r23287
CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 21 ]

(3, 4). I've added validation rules for all screen elements with the "parameter" field. It's now mandatory. RESOLVED.

<asaveljevs> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 21 ]

(5) RESOLVED. Plus I've made, that the selection of items for a templated clock should be limited to the items from the template.

<asaveljevs> The popup for selecting an item for clock element shows template's technical name in the upper right corner. It should show the visible name instead.

<pavels> RESOLVED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(8) File include/screens.inc.php, line 603 puts technical host name into $caption. It should put visible host name instead.

<pavels> RESOLVED

<asaveljevs> OK, but after the item is chosen and the popup is closed, the "Parameter" field in "Screen cell configuration" contains host's technical name.

<pavels> Right. Fixed. RESOLVED.

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(9) Clock element links to zabbix.com. It probably shouldn't.

<asaveljevs> If clock element with "Host time" is present in a templated screen, then on the host level it will try to show data from the item in the template. It should show data from host's item.

<asaveljevs> Also, the clock element shows technical host name. It should show visible host name.

<pavels> i've created a separate issue for these problems ZBX-4378. CLOSED for now.

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(10) When selecting items for clock and plain text elements, item key column is not shown in the popup.

<pavels> It's never shown when the popup displays items from a single host. Should it be?

<asaveljevs> I think it should. As a server side developer, I don't care how my items are described - I do care about their keys. So when I search the popup, I search for the key, not description.

<pavels> My mistake, the "key" column is displayed for the clock popup, it was only missing in the plain text popup. Fixed it. RESOLVED.

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(11) New file frontends/php/api/classes/class.cscreenitem.php does not have any properties set. It should have svn:eol-style property set to native.

<pavels> RESOLVED

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(12) That new file has text indented with tabs in PHP doc comments. Is that our new convention?

<pavels> I think PHP doc wasn't mentioned in our coding style guidelines, but IMHO it's more readable that way.

<richlv> if something is missing in the conventions/guidelines, it must be added (preferably at https://zabbix.org/wiki/Docs/specs/coding_style)

<pavels> So which style do we choose? With aligned parameter description, or without?

<pavels> We discussed it yesterday and settled for aligned style. Added it to the docs https://zabbix.org/wiki/Docs/specs/coding_style#PHPDoc. RESOLVED.

<asaveljevs> Nice! CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 22 ]

(13) Class Screen uses "if(!is_null($options['countOutput']))" in method get(). However, class ScreenItem uses "if ($options['countOutput'])" directly. Is that OK?

<asaveljevs> Similarly, starting from line 424 and below the code uses different style for checking empty arrays: "if(!empty($hostgroups))" and "if ($hosts)".

<pavels> "is_null()" is not exactly the same as just "if()", but it seems weird, that if we pass, for instance, "countOutput = fallse", "!is_null" will return true, and the "countOption" will be executed.

"if(!empty($hostgroups))" and "if ($hosts)" is the same thing, as long as the $hosts variable is defined.

<asaveljevs> Oh, sure, but it would be nice to use the same style everywhere.

<pavels> I've replaced the API options checks for "is not null" to be consistent with other APIs, but I really see no reason to use the empty() and is_null() functions.

<richlv> ...and we should document in the guidelines which ones should be used

<asaveljevs> You have chosen to use "$var === null" style instead of "is_null($var)" style used elsewhere. Why?

$ grepphp options | grep null | grep -c is.null
1025
grepphp options | grep null | grep -vc is.null
24

<pavels> I, pesonally, think, that the === syntax is more readable, then is_null. E.g. if you check the return value of a function, foo() === null is much better then is_null(foo()) Plus, it's a bit faster then is_null: it doesn't have the overhead of calling a function.

<pavels> Added it to the style guidelines https://zabbix.org/wiki/Docs/specs/coding_style#PHP_conventions RESOLVED.

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 23 ]

(14) Function checkInput() in class ScreenItem does not validate host group for "Data overview" element.

<pavels> RESOLVED.

<asaveljevs> CLOSED

Comment by Aleksandrs Saveljevs [ 2011 Nov 23 ]

(15) Please review my changes regarding formatting and typos in r23453.

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 24 ]

Merged to trunk revision r23493.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 24 ]

I've backported the fix for 1.8. It's available at /branches/dev/ZBX-3104-18. Please review.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

Merged to trunk r23677 and 1.8 r23675.

CLOSED.

Comment by richlv [ 2012 Jan 27 ]

turns out this resulted in a regression for "triggers info" screen element validation, filed as ZBX-4593





[ZBX-3217] installation wizard fails to start without some modules Created: 2010 Nov 15  Updated: 2017 May 30  Resolved: 2011 Dec 15

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.4rc2
Fix Version/s: 1.8.10

Type: Incident report Priority: Major
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: configwizard
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File error-bcmath.png    

 Description   

For instance, it fails to start without bcmath installed. See error-bcmath.png.



 Comments   
Comment by richlv [ 2011 Dec 10 ]

note that the problem is config wizard not starting with bcmath missing. bcmath is not required for wizard, thus it should proceed and inform about missing functionality on step 3, requirement check
<Slava> As i understand, the wizard in step 3, if some modules are unavailable, should show to user warning about missing functionality and process to next step?? This apply only to bcmath module or can be applied to some other modules?

<richlv> it might be relevant with other modules too. basically, we should get to that step in the wizard with the absolute minimum of modules required.
if possible, not trying to use 'date.timezone' till that step also would be preferable

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 13 ]

(1) We shouldn't ignore the bc math check at that step, zabbix can't work without it. What we need to do is make sure the user can reach step 3 to figure out, what modules he needs, without causing a fatal error.
<SlaVa>RESOLVED

<pavels> Please, review my commits r23970 and r23971. After that you can merge. CLOSED.
<Slava> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 14 ]

TESTED.

Comment by Vjacheslav Shipillo (Inactive) [ 2011 Dec 15 ]

fixed in revision 23980





[ZBX-3244] dropdown changes its style when navigating menu Created: 2010 Nov 29  Updated: 2017 May 30  Resolved: 2011 Nov 23

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.4rc2
Fix Version/s: 1.8.10, 2.0.0

Type: Incident report Priority: Trivial
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: reports, trivial, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File mode-style-1.png     PNG File mode-style-2.png    

 Description   

Using the GUI as guest, go to "Reports" -> "Availability report". Observe in mode-style-1.png the style of the "Mode" dropdown. Now, move the mouse to point at "Inventory". Observe in mode-style-2.png that the dropdown changed its style.



 Comments   
Comment by richlv [ 2010 Nov 29 ]

quite wicked. happens also in opera 10.11

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 23 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-3244

Comment by Aleksandrs Saveljevs [ 2011 Nov 23 ]

(1) tagName is not guaranteed to be all uppercase, see http://reference.sitepoint.com/javascript/Element/tagName .

<asaveljevs> Also, the new JavaScript code uses "notactive" CSS class, but it does not seem to be defined anywhere.

<sanja> RESOLVED

<asaveljevs> We use toLowerCase() in the rest of our code:

$ grepjs tagname | grepjs tagName | grep toUpperCase | grep -Ev 'scriptaculous|prototype'
./frontends/php/js/main.js: if (menu_cell.tagName.toUpperCase() != 'SELECT') {
$ grepjs tagname | grepjs tagName | grep toLowerCase | grep -Ev 'scriptaculous|prototype'
./frontends/php/js/class.calendar.js: if(this.timeobjects[0].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[i].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[0].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[0].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[1].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[2].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[3].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.calendar.js: if(this.timeobjects[4].tagName.toLowerCase() == 'input'){
./frontends/php/js/class.cviewswitcher.js: switch(obj.tagName.toLowerCase()) {
./frontends/php/js/class.cviewswitcher.js: switch(obj.tagName.toLowerCase()) {
./frontends/php/js/class.cviewswitcher.js: switch(obj.tagName.toLowerCase()) {
./frontends/php/js/class.csuggest.js: if(is_null(row) || (row.tagName.toLowerCase() != 'tr') || !isset('id',row)) return true;

<sanja> RESOLVED

<pavels> CLOSED.

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 30 ]

Fixed in 1.8.10rc1 and trunk





[ZBX-2843] slideshow refresh time popup menu too wide Created: 2010 Aug 09  Updated: 2017 May 30  Resolved: 2011 Dec 21

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Trivial
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: slideshows, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File dashboard.jpg     PNG File menu-trunk.png     PNG File slideshow_refresh.png    
Issue Links:
Duplicate
is duplicated by ZBX-3087 Need a more wide pop-up for 'Create L... Closed

 Description   

see the screenshot. this menu should be half as wide as it currently is



 Comments   
Comment by richlv [ 2011 Nov 16 ]

(2) unfortunately, refresh menu now completely fails in opera 11.52 :

Uncaught exception: TypeError: Cannot convert 'get_style(test_element, 'font-size')' to object
Error thrown at line 11966, column 1 in get_real_text_width(text) in jsLoader.php?ver=1.8.9rc1&lang=en_gb:
var font_size = parseInt(get_style(test_element, 'font-size').split('px')[0]);
called from line 11987, column 2 in show_popup_menu(e, content, width) in jsLoader.php?ver=1.8.9rc1&lang=en_gb:
tmp_width = get_real_text_width(content[i][0]);
called from line 11838, column 1 in create_page_menu(e, id) in jsLoader.php?ver=1.8.9rc1&lang=en_gb:
show_popup_menu(e, dbrd_menu);
called from line 1, column 12 in <anonymous function>(event):
create_page_menu(event,"hat_slides");

<sanja> RESOLVED

<richlv> not sure about mozilla referenced in commit, but works fine in opera now -> CLOSED

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 16 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-2843

Comment by richlv [ 2011 Nov 16 ]

for the record, dev branch rev 23266 works fine in konqueror 4.6 as well

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 16 ]

Checked this change (from dev branch) for the v1.8 when using FF 7.0, IE 8.0, IE 9.0, Opera 11.01, Safari 5.0.3 and Chrome 15 browsers.

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 23 ]

<sanja> Fixed in 1.8 and trunk

Comment by Alexander Vladishev [ 2011 Dec 06 ]

(3) Not all menus are correctly displayed
https://support.zabbix.com/secure/attachment/17592/dashboard.jpg

<sanja> RESOLVED

<pavels> If item names will be too long, the menu won't fit on the screen. We should probably truncate them to some reasonable size. REOPENED.

<sanja> RESOLVED

<pavels> Please review my last commit r23946. After that you can merge. TESTED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 08 ]

(4) [GUI] The text in the menu in the trunk is truncated incorrectly.
https://support.zabbix.com/secure/attachment/17598/menu-trunk.png

<sanja> RESOLVED

<pavels> Merge to 1.8 and then, if there are no conflicts, to the trunk.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 13 ]

TESTED.

Comment by Alexander Sorokin (Inactive) [ 2011 Dec 14 ]

Merged to 1.8 and trunk

Comment by Alexander Vladishev [ 2011 Dec 19 ]

items.php: The menu of creation of trigger expressions isn't displayed

Comment by Alexey Fukalov [ 2011 Dec 20 ]

dev branch: svn://svn.zabbix.com/branches/dev/ZBX-2843

Comment by Alexander Vladishev [ 2011 Dec 20 ]

Tested successfully.

Comment by Alexey Fukalov [ 2011 Dec 20 ]

merged: svn://svn.zabbix.com/branches/1.8 24105

Comment by richlv [ 2011 Dec 21 ]

(5) changelog entry missing in trunk changelog
<Vedmak> thanks

Comment by Alexey Fukalov [ 2011 Dec 21 ]

merged: svn://svn.zabbix.com/trunk 24122





[ZBX-2419] IT Services: Calculation of availability is incorrect when uptimes are applied Created: 2010 May 11  Updated: 2017 May 30  Resolved: 2011 Nov 27

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.2
Fix Version/s: 1.8.10, 2.0.0

Type: Incident report Priority: Blocker
Reporter: jsteckel Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: itservices
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Apache/2.2.9 (Debian) PHP/5.2.6-1+lenny8 with Suhosin-Patch mod_perl/2.0.4 Perl/v5.10.0
mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (x86_64) using readline 5.2


Attachments: JPEG File screenshot-1.jpg     JPEG File screenshot-2.jpg     JPEG File screenshot-3.jpg    
Issue Links:
Duplicate
duplicates ZBX-2177 sla seems to be calculated incorrectly Closed

 Description   

The following service alarms have been recorded for service with serviceid = 3:

mysql> SELECT servicealarmid, serviceid, clock, from_unixtime( clock ), value FROM `service_alarms` where serviceid = 3;
--------------------------------------------------------------

servicealarmid serviceid clock from_unixtime( clock ) value

--------------------------------------------------------------

5 3 1273482450 2010-05-10 11:07:30 0
19 3 1273495024 2010-05-10 14:37:04 2
20 3 1273495662 2010-05-10 14:47:42 0
21 3 1273496261 2010-05-10 14:57:41 2
84 3 1273527437 2010-05-10 23:37:17 0

--------------------------------------------------------------
5 rows in set (0.00 sec)

Service with serviceid = 3 was configured according to picture 1.

The IT services report (report3.php) with Period = Daily executed on 11 May 2010, 11:00, states results according to picture 2.

With uptime defined only for mondays between 09:00 and 17:00 I would have expected the following results (10 May 2010 was on a monday):

--------------------------------------------------------+

Day OK Problems Downtime Percentage SLA

--------------------------------------------------------+

09 May 2010 0d 0h 0m 0d 0h 0m 1d 0h 0m N/A N/A
10 May 2010 0d 5h 47m 0d 2h 13m 0d 16h 0m 72.29% 98.50%
11 May 2010 0d 0h 0m 0d 0h 0m 1d 0h 0m N/A N/A

--------------------------------------------------------+

On 09 May and 11 May values for "OK" and "Downtime" are incorrect. On 10 May values for "OK", "Problems", "Downtime", "Percentage" as well as the font color of "SLA" are incorrect.

If I take out any uptime or downtime configuration I get results as expected for the same report (executed on 11 May 2010, 10:42, see picture 3).



 Comments   
Comment by jsteckel [ 2010 Sep 20 ]

Are there any plans to resolve this bug?

Comment by Alexei Vladishev [ 2011 Nov 16 ]

This issue is related to ZBXNEXT-913.

Comment by Alexander Vladishev [ 2011 Nov 27 ]

Fixed in the development branch, rev. 23557. Backport from trunk (ZBXNEXT-913)

Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 02 ]

Please review my r23716 commit. Otherwise TESTED.

Comment by Alexander Vladishev [ 2011 Dec 02 ]

Fixed in version pre-1.8.10, revision 23724





[ZBX-2859] possible to successfully delete zero regular expressions Created: 2010 Aug 11  Updated: 2017 May 30  Resolved: 2011 Nov 14

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.3rc4
Fix Version/s: 1.8.10, 2.0.0

Type: Incident report Priority: Trivial
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: globalregexps, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File regexp-deleted.png    

 Description   

Go to "Administration" -> "General" -> "Regular expressions". No regular expressions are defined. Press "Delete selected". Observe regexp-deleted.png. The frontend should instead say something like "No elements selected!" like it does in other places.



 Comments   
Comment by richlv [ 2011 Feb 07 ]

still the same in 1.8 branch rev 17474

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 14 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-2859

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 17 ]

<Igor> TESTED, in v1.8 when trying to delete non-existing regular expression on the screen appears error message "No elements selected!"

At this moment in the latest trunk (rev #23306) can reproduce the same problem, need to fix also in trunk branch.

Comment by Alexander Sorokin (Inactive) [ 2011 Nov 23 ]

<sanja> Fixed in 1.8





[ZBX-3397] map elements with missing image rendered as red squares Created: 2011 Jan 09  Updated: 2017 May 30  Resolved: 2011 Nov 22

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.6, 1.9.1 (alpha)
Fix Version/s: 1.8.10, 2.0.0

Type: Incident report Priority: Critical
Reporter: richlv Assignee: Unassigned
Resolution: Won't fix Votes: 0
Labels: maps, regression
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File no_icon.png    

 Description   

regression.

if a map element is configured to use an image that is missing, it shows up as "no icon" in configuration view. in monitoring view we only get red square



 Comments   
Comment by richlv [ 2011 Mar 29 ]

before, it rendered "No image" text (in two rows) instead for such an element - seems like an acceptable solution to me

Comment by richlv [ 2011 Aug 21 ]

for trunk this is solved by db integrity.

problem also present in 1.8 branch rev 21265 - and here it's actually worse, as the red square is shown in the monitoring section, but that element can not be edited in any way in configuration at all (no icon for it, thus no way to select it)

Comment by richlv [ 2011 Nov 22 ]

won't be fixed for 1.8 branch





[ZBX-4235] Graph axis labels incorrect in localized GUI Created: 2011 Oct 14  Updated: 2017 May 30  Resolved: 2011 Nov 25

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.9, 1.9.7 (beta)
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Blocker
Reporter: Jens Berthold Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: graphs
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Debian 6, MySQL


Attachments: JPEG File latest-data-english.jpg     JPEG File latest-data-german.jpg     PNG File zabbix_english.png     PNG File zabbix_german.png    
Issue Links:
Duplicate
duplicates ZBX-2582 division by zero when browsing latest... Closed

 Description   

With german localization, axis labels show zero instead of numbers, or show too much decimals with percent values.
Please see attachments for comparison between correct english version and faulty german version. (No changes between screenshots ecxept for changing language)



 Comments   
Comment by Oleksii Zagorskyi [ 2011 Oct 14 ]

I can confirm the same in Ukrainian and Russian locales in the latest trunk rev 22380.

Comment by Alexey Fukalov [ 2011 Nov 15 ]

Cannot reproduce this problem with default graphs from "Linux template", does this problem occur on all graphs or only specific ones?

<pavels> Can't reproduce it too.

<zalex> Still can reproduce in the rev 23335. Any idea how to check the differences in our systems?

<richlv> php versions, gd versions ?
on the second thought, gd version shouldn't matter

Comment by richlv [ 2011 Nov 22 ]

for the record, can't reproduce in trunk rev 23404.
php 5.3.3 and 5.3.5
tried both simple & custom graphs with ukrainian and german locales.
tried custom graphs with multiple items on same axis, with two axis.

just a quick idea, have mo files been remade recently ?

Comment by Oleksii Zagorskyi [ 2011 Nov 22 ]

Reproducible as mentioned above:

  1. uname -a
    Linux it0 2.6.32-5-amd64 #1 SMP Mon Oct 3 03:59:20 UTC 2011 x86_64 GNU/Linux
  1. cat /etc/debian_version
    6.0.3
  1. dpkg -l | grep php
    ii libapache2-mod-php5 5.3.3-7+squeeze3 server-side, HTML-embedded scripting language (Apache 2 module)
    ii php5 5.3.3-7+squeeze3 server-side, HTML-embedded scripting language (metapackage)
    ii php5-cli 5.3.3-7+squeeze3 command-line interpreter for the php5 scripting language
    ii php5-common 5.3.3-7+squeeze3 Common files for packages built from the php5 source
    ii php5-gd 5.3.3-7+squeeze3 GD module for php5
    ii php5-mcrypt 5.3.3-7+squeeze3 MCrypt module for php5
    ii php5-mysql 5.3.3-7+squeeze3 MySQL module for php5
    ii php5-pgsql 5.3.3-7+squeeze3 PostgreSQL module for php5
    ii php5-suhosin 0.9.32.1-1 advanced protection module for php5
  1. locale
    LANG=en_GB.UTF-8
    LC_CTYPE="en_GB.UTF-8"
    LC_NUMERIC="en_GB.UTF-8"
    LC_TIME="en_GB.UTF-8"
    LC_COLLATE="en_GB.UTF-8"
    LC_MONETARY="en_GB.UTF-8"
    LC_MESSAGES="en_GB.UTF-8"
    LC_PAPER="en_GB.UTF-8"
    LC_NAME="en_GB.UTF-8"
    LC_ADDRESS="en_GB.UTF-8"
    LC_TELEPHONE="en_GB.UTF-8"
    LC_MEASUREMENT="en_GB.UTF-8"
    LC_IDENTIFICATION="en_GB.UTF-8"
    LC_ALL=
  1. locale -a
    C
    en_GB.utf8
    POSIX
    ru_RU.utf8
    uk_UA.utf8

The problem ***NOT*** reproducible on:

  1. uname -a
    FreeBSD 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010
  1. pkg_info | grep php
    php5-5.3.6_1 PHP Scripting Language
    php5-bcmath-5.3.6_1 The bcmath shared extension for php
    php5-ctype-5.3.6_1 The ctype shared extension for php
    php5-dom-5.3.6_1 The dom shared extension for php
    php5-gd-5.3.6_1 The gd shared extension for php
    php5-gettext-5.3.6_1 The gettext shared extension for php
    php5-mbstring-5.3.6_1 The mbstring shared extension for php
    php5-mysql-5.3.6_1 The mysql shared extension for php
    php5-session-5.3.6_1 The session shared extension for php
    php5-snmp-5.3.6_1 The snmp shared extension for php
    php5-sockets-5.3.6_1 The sockets shared extension for php
    php5-xml-5.3.6_1 The xml shared extension for php
    php5-xmlreader-5.3.6_1 The xmlreader shared extension for php
    php5-xmlwriter-5.3.6_1 The xmlwriter shared extension for php
  1. locale
    LANG=uk_UA.UTF-8
    LC_CTYPE="uk_UA.UTF-8"
    LC_COLLATE="uk_UA.UTF-8"
    LC_TIME="uk_UA.UTF-8"
    LC_NUMERIC="uk_UA.UTF-8"
    LC_MONETARY="uk_UA.UTF-8"
    LC_MESSAGES="uk_UA.UTF-8"
    LC_ALL=
  1. locale -a | wc -l
    172
  1. locale -a | grep en_GB
    en_GB.ISO8859-1
    en_GB.ISO8859-15
    en_GB.US-ASCII
    en_GB.UTF-8
Comment by Jens Berthold [ 2011 Nov 22 ]

Could it have something to do with Suhosin patch?

Reproducible on:

  1. uname -a
    Linux sl04121 2.6.32-5-686 #1 SMP Fri Sep 9 20:51:05 UTC 2011 i686 GNU/Linux
  1. cat /etc/debian_version
    6.0.2
  1. dpkg -l | grep php
    ii libapache2-mod-php5 5.3.3-7+squeeze3 server-side, HTML-embedded scripting language (Apache 2 module)
    ii php5-cli 5.3.3-7+squeeze3 command-line interpreter for the php5 scripting language
    ii php5-common 5.3.3-7+squeeze3 Common files for packages built from the php5 source
    ii php5-gd 5.3.3-7+squeeze3 GD module for php5
    ii php5-mysql 5.3.3-7+squeeze3 MySQL module for php5
    ii php5-suhosin 0.9.32.1-1 advanced protection module for php5
  1. locale
    LANG=de_DE.UTF-8
    LC_CTYPE="de_DE.UTF-8"
    LC_NUMERIC="de_DE.UTF-8"
    LC_TIME="de_DE.UTF-8"
    LC_COLLATE="de_DE.UTF-8"
    LC_MONETARY="de_DE.UTF-8"
    LC_MESSAGES="de_DE.UTF-8"
    LC_PAPER="de_DE.UTF-8"
    LC_NAME="de_DE.UTF-8"
    LC_ADDRESS="de_DE.UTF-8"
    LC_TELEPHONE="de_DE.UTF-8"
    LC_MEASUREMENT="de_DE.UTF-8"
    LC_IDENTIFICATION="de_DE.UTF-8"
    LC_ALL=
  1. locale -a
    C
    de_DE.utf8
    en_GB.utf8
    POSIX
Comment by richlv [ 2011 Nov 22 ]

suhosin might be easy to test - uninstalling/disabling it & trying again should reveal that

Comment by Jens Berthold [ 2011 Nov 23 ]

Right
I tested it - no difference. So it's not related to suhosin.

Comment by Jens Berthold [ 2011 Nov 23 ]

Same error seems to be with latest data. I attached two more images with that view.
Maybe there is a hint where to look for the error (latest-data-german.jpg) - include/func.inc.php:499.

Comment by Oleksii Zagorskyi [ 2011 Nov 23 ]

I can confirm the same problems for latest data page as Jens mentioned.
But without php errors.

Comment by Oleksii Zagorskyi [ 2011 Nov 23 ]

Not reproducible (trunk r 23438):

  1. cat /etc/redhat-release
    CentOS release 5.5 (Final)
  1. rpm -qa | grep php
    php-mbstring-5.3.5-1.el5.remi.1
    php-cli-5.3.5-1.el5.remi.1
    php-xml-5.3.5-1.el5.remi.1
    php-pdo-5.3.5-1.el5.remi.1
    php-ldap-5.3.5-1.el5.remi.1
    php-mysql-5.3.5-1.el5.remi.1
    php-common-5.3.5-1.el5.remi.1
    php-sqlite-5.3.5-1.el5.remi.1
    php-snmp-5.3.5-1.el5.remi.1
    php-5.3.5-1.el5.remi.1
    php-gd-5.3.5-1.el5.remi.1
    php-mcrypt-5.3.5-1.el5.remi.1
    php-bcmath-5.3.5-1.el5.remi.1
  1. locale
    LANG=en_US.UTF-8
    LC_CTYPE="en_US.UTF-8"
    LC_NUMERIC="en_US.UTF-8"
    LC_TIME="en_US.UTF-8"
    LC_COLLATE="en_US.UTF-8"
    LC_MONETARY="en_US.UTF-8"
    LC_MESSAGES="en_US.UTF-8"
    LC_PAPER="en_US.UTF-8"
    LC_NAME="en_US.UTF-8"
    LC_ADDRESS="en_US.UTF-8"
    LC_TELEPHONE="en_US.UTF-8"
    LC_MEASUREMENT="en_US.UTF-8"
    LC_IDENTIFICATION="en_US.UTF-8"
    LC_ALL=
  1. locale -a | wc -l
    650
  1. locale -a | grep en_GB
    en_GB
    en_GB.iso88591
    en_GB.iso885915
    en_GB.utf8
Comment by Oleksii Zagorskyi [ 2011 Nov 23 ]

On Debian 6.0.3 (mentioned above) the problem is still reproducible after replacing "php5 5.3.3-7+squeeze3" to the "php5 5.3.8.0-1"

Comment by Alexey Fukalov [ 2011 Nov 23 ]

Does systems where error is reproducible has bcmath extensions for php? And are all required extensions installed (passed requirements test during installation)?

<zalex> On Debian 6.0.3 I have installed libapache2-mod-php5 ->
Description: The following extensions are built in: bcmath bz2 calendar Core ctype date dba dom ereg exif fileinfo filter ftp gettext hash iconv json libxml mbstring mhash openssl pcre Phar posix Reflection session shmop SimpleXML soap sockets SPL standard sysvmsg sysvsem sysvshm tokenizer wddx xml xmlreader xmlwriter zip zlib.
Of course during installation no any errors.

Comment by Aleksandrs Saveljevs [ 2011 Nov 24 ]

This looks similar to ZBX-2582, but I have not reproduced it so far using the scenario with Trac mentioned in that issue.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 24 ]

Zabbix uses the "en" locale for LC_NUMERIC, it seems it doesn't work on some of these machines. Is it possible that there is no "en" locale available? Could you run "locale -a"?

<zalex> output for all mentioned OS added. see comments above.

Comment by Oleksii Zagorskyi [ 2011 Nov 25 ]

What you say about these lines:

  1. grep -r LC_NUMERIC *
    include/views/administration.users.edit.php:setLocale(LC_NUMERIC, array('en', 'en_US', 'en_US.UTF-8', 'English_United States.1252')); // numeric Locale to default
    include/config.inc.php: setLocale(LC_NUMERIC, array('en', 'en_US', 'en_US.UTF-8', 'English_United States.1252'));
    jsLoader.php: setLocale(LC_NUMERIC, array('en', 'en_US', 'en_US.UTF-8', 'English_United States.1252'));

I'm and Jens we both had only "en_GB" locale installed but not the "en_US".
When I installed "en_US" locale the problem is gone!

In the Debian it's command "dpkg-reconfigure locales"
Apache has to be restarted to apply installed locales: service apache2 restart

Pavels, you know what to do next.
Thanks.

<pavels> Yeah, sorry, I forgot to mention, that we currently use en_US.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 25 ]

Please review the fix for 1.8 in branches/dev/ZBX-4235 and for the trunk in branches/dev/ZBX-4235-trunk.

RESOLVED.

Comment by Oleksii Zagorskyi [ 2011 Nov 25 ]

Note:
(1) If I removed both locales "en_GB" and "en_US" and restart apache, zabbix frontend still works correctly in English GUI.
But no any errors, warnings, etc to user that default locales are missing. Maybe it's ok and maybe not. It's up to you.
Tested Debian 6.0.3

<pavels> Then their default local must use periods as decimal points. I have an idea how to fix it without depending on locales, I'll give it a try Monday.

Comment by Oleksii Zagorskyi [ 2011 Nov 25 ]

Dev branch (for trunk) tester. Works as expected for non-english GUI with installed only one locale of "en_GB" or "en_US".
Thanks.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 28 ]

I've added the POSIX locale as an alternative LC_NUMERIC locale. It should be supported on all *nix systems and it also uses a dot as a decimal separator.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 30 ]

Merged to trunk revision r23618 and branches/1.8 revision r23615.

CLOSED.





[ZBX-4288] host macros are not deleted from the database when host is deleted Created: 2011 Oct 27  Updated: 2017 May 30  Resolved: 2011 Nov 25

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.8
Fix Version/s: 1.8.10

Type: Incident report Priority: Blocker
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: usermacros
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-4383 'host.delete' method in API v. 1.8.8 ... Closed

 Description   

create a host or template with usermacro. delete this host. usermacro is not deleted.

a unittest for this is required (both for template & host)



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 22 ]

RESOLVED for 1.8 in branches/dev/ZBX-4288.

It works correctly in the trunk, but I'll add a unit test to cover host deletion.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 22 ]

Added tests to check this behavior in the trunk. Available in branches/dev/ZBX-4288-trunk. RESOLVED.

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 23 ]

In trunk in dev branch "ZBX-4288-trunk" it is working fine for both hosts and templates.

In 1.8 dev branch "ZBX-4288" it is working fine for both host and template.

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 24 ]

Tested.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Nov 24 ]

Merged to trunk revision r23510 and 1.8 revision r23507. CLOSED.





[ZBX-4298] No messages in the LEVEL_WARNING log about deleted values by housekeeper (table "housekeeper") Created: 2011 Oct 31  Updated: 2017 May 30  Resolved: 2011 Dec 19

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 1.8.8
Fix Version/s: 1.8.10, 1.8.11, 1.9.9 (beta)

Type: Incident report Priority: Minor
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: housekeeper
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

DebugLevel=3



 Description   

When zabbix_server works with the DebugLevel=3 it reports to the log this message:
"Deleted <NNN> records from history and trends"

But here are not included values deleted by housekeeper for the items already deleted from configuration (table "housekeeper").
1. This lack of information could confuse when troubleshooting of DB performance.
2. It's not consistent that the housekeeper is reporting count of the deleted outdated values but does not report count of values for items already deleted from configuration.

Try to imagine a situation when some user has performed "Unlink and clear" action with some big template linked to the several hosts and in the nearest hour he felt some problem with the DB performance and he thinks - what happened ?

Here is part of DebugLevel=4 (I added several EOL for better view):

15500:20111031:150250.029 End of housekeeping_history_and_trends():0

15500:20111031:150250.029 Deleted 0 records from history and trends

15500:20111031:150250.029 In housekeeping_process_log()
15500:20111031:150250.029 query [txnlev:0] [select housekeeperid,tablename,field,value from housekeeper order by table name]
15500:20111031:150250.029 query without transaction detected

15500:20111031:150250.029 query [txnlev:0] [delete from history where itemid=22578 limit 100]
15500:20111031:150250.044 deleted 100 records from table 'history'

15500:20111031:150250.044 query without transaction detected

15500:20111031:150250.044 query [txnlev:0] [delete from history_uint where itemid=22577 limit 100]
15500:20111031:150250.060 deleted 100 records from table 'history_uint'

15500:20111031:150250.060 End of housekeeping_process_log():SUCCEED
15500:20111031:150250.060 In housekeeping_events() now:1320062561
15500:20111031:150250.060 query [txnlev:0] [select event_history from config]
15500:20111031:150250.060 query [txnlev:0] [select eventid from events where clock<1288526561]
15500:20111031:150250.060 End of housekeeping_events():SUCCEED

15500:20111031:150250.060 In housekeeping_alerts() now:1320062561
15500:20111031:150250.060 query [txnlev:0] [select alert_history from config]
15500:20111031:150250.060 query without transaction detected
15500:20111031:150250.060 query [txnlev:0] [delete from alerts where clock<1288526561]
15500:20111031:150250.060 deleted 0 records from table 'alerts'
15500:20111031:150250.060 End of housekeeping_alerts():SUCCEED

15500:20111031:150250.060 In housekeeping_sessions() now:1320062561
15500:20111031:150250.060 query without transaction detected
15500:20111031:150250.060 query [txnlev:0] [delete from sessions where lastaccess<1288526561]
15500:20111031:150250.061 deleted 0 records from table 'sessions'
15500:20111031:150250.061 End of housekeeping_sessions():SUCCEED
15500:20111031:150250.061 sleeping for 3600 seconds

(in this example "MaxHousekeeperDelete=100")

As you see in the function "housekeeping_process_log()", where the values are deleted from the tables history, history_uint (and not only), no messages are added for the LOG_LEVEL_WARNING.

I ask to add these messages to log. Maybe individually per each table, maybe summarize history+trends, I don't know how is better.

If any such values were not deleted then needn't to report any messages.



 Comments   
Comment by Oleksii Zagorskyi [ 2011 Oct 31 ]

(1) By the way, the name of function "housekeeping_process_log()" seems is not optimal.

I suggest to change it to "housekeeping_process_deleted_items()" or similar.

<dimir> I chose housekeeping_cleanup(), RESOLVED in r23553

<zalex> Excellent ! CLOSED

Comment by dimir [ 2011 Nov 25 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4298

Comment by dimir [ 2011 Nov 25 ]

I've chosen "housekeeping_cleanup()", if nobody minds. So the report will look like this:

11921:20111125:180134.824 housekeeper deleted 0 records from history and trends, 28561 records of deleted items, 0 events, 0 alerts and 0 sessions

This will be logged on every housekeeper step even if nothing was removed. Agreed with sasha that this way there will will be no questions whether it actually was or not an attempt to delete the data.

Comment by Oleksii Zagorskyi [ 2011 Nov 27 ]

Dev branch tested. Works as expected. Single line for report is very-very good.

(2) I would suggest to write that line as:
housekeeper deleted: 0 records from history and trends, 28561 records of deleted items, 0 events, 0 alerts, 0 sessions
It seems for me it will be in more readable form.

<dimir> RESOLVED in r23560

<zalex> Many thanks. CLOSED.

Comment by dimir [ 2011 Nov 30 ]

Fixed in pre-1.8.10 r23632, pre-1.9.9 r23633.

Comment by Alexander Vladishev [ 2011 Nov 30 ]

(1) Broken compilation of the latest trunk.

housekeeper.c: In function ‘housekeeping_cleanup’:
housekeeper.c:135: error: ‘ids_alloc’ undeclared (first use in this function)
housekeeper.c:135: error: (Each undeclared identifier is reported only once
housekeeper.c:135: error: for each function it appears in.)
housekeeper.c:135: error: ‘ids_num’ undeclared (first use in this function)
housekeeper.c: In function ‘housekeeping_alerts’:
housekeeper.c:186: warning: ‘return’ with a value, in function returning void
housekeeper.c: In function ‘housekeeping_events’:
housekeeper.c:213: warning: ‘return’ with a value, in function returning void
housekeeper.c: In function ‘main_housekeeper_loop’:
housekeeper.c:328: error: void value not ignored as it ought to be
housekeeper.c:331: error: void value not ignored as it ought to be

<dimir> sorry for the broken trunk, RESOLVED in r23663 directly in trunk

<zalex> tested. trunk r23663 compiled ok and it works.

<sasha> CLOSED with small change in r23688.

Comment by richlv [ 2011 Nov 30 ]

(2) also :
what's the difference between "history and trends" and "records of deleted items" ? i assume the latter is not the amount of items, but the amount of history and trends values for those items ?

<dimir> "Old history and trends" is the outdated information (as configured in the item keep this and that), "records of deleted items" is all the data (basically what's in "housekeeper" table) related to removed item.

<zalex> maybe would be better to replace all words "records" to the "values"? It will be more clear.

<dimir> For me "deleted 2 values from history and trends" is not more clear than "deleted 2 records from hostory and trends". What I'd add is singular value support.

<dimir> if there are no objections, RESOLVED in r23681

<zalex> dev branch r23681 tested. it works (see 1 event):
"housekeeper deleted: 7056 records from history and trends, 0 records of deleted items, 1 event, 0 alerts, 0 sessions"
he-he, it's some "alternative" to gettext

<dimir> We decided to discard these changes as we don't have anything like it anywhere. CLOSED

Comment by dimir [ 2011 Dec 01 ]

Oleksiy, thank you for testing!

Comment by dimir [ 2011 Dec 01 ]

Fixed in trunk r23663.

Comment by richlv [ 2011 Dec 01 ]

(3) i suspect "d_clenup" is a typo

<dimir> Right, RESOLVED in pre-1.8.10 r23732, pre-1.9.9 r23733.
<sasha> CLOSED

Comment by Alexander Vladishev [ 2011 Dec 02 ]

Closing resolved issue

Comment by dimir [ 2011 Dec 02 ]

Reopening to assign to myself.

Comment by dimir [ 2011 Dec 02 ]

Closed.

Comment by richlv [ 2011 Dec 19 ]

48 deleted events reported as 1 in 1.8.10rc1

strace output :

event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=11", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=18", 40) = 40
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=5", 39) = 39
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=9", 39) = 39
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=1", 39) = 39
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=47", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=38", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=44", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=43", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=36", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=42", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=34", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=35", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=31", 40) = 40
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=8", 39) = 39
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=30", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=40", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=37", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=13", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=39", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=33", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=46", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=29", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=48", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=41", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=14", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=32", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=10", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=27", 40) = 40
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=6", 39) = 39
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=7", 39) = 39
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=12", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=26", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=45", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=24", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=25", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=17", 40) = 40
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=2", 39) = 39
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=3", 39) = 39
event_strace.13938:write(6, "#\0\0\0\3delete from events where eventid=4", 39) = 39
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=15", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=16", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=20", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=21", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=22", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=23", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=19", 40) = 40
event_strace.13938:write(6, "$\0\0\0\3delete from events where eventid=28", 40) = 40
event_strace.13938:write(7, " 13938:20111217:175347.261 housekeeper deleted: 0 records from history and trends, 0 records of deleted items, 1 events, 0 alerts, 0 sessions\n", 142) = 142

Comment by Alexander Vladishev [ 2011 Dec 19 ]

Fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-4298

Comment by dimir [ 2011 Dec 19 ]

Tested successfully.

Comment by Alexander Vladishev [ 2011 Dec 28 ]

Available in version pre-1.8.11, r24309.





[ZBX-4360] Server from trunk will not compile on FreeBSD 7.3 Created: 2011 Nov 17  Updated: 2017 May 30  Resolved: 2012 Jun 13

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Installation (I)
Affects Version/s: 1.9.8 (beta)
Fix Version/s: 1.8.10, 1.9.8 (beta)

Type: Incident report Priority: Trivial
Reporter: dimir Assignee: dimir
Resolution: Fixed Votes: 0
Labels: compilation, freebsd
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

FreeBSD 7.3-RELEASE FreeBSD 7.3-RELEASE #0: Sun Mar 21 06:15:01 UTC 2010 root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386



 Description   

Server compilation fails with error while trying to compile trapper:

[...]
gcc -DHAVE_CONFIG_H -I. -I../../../include -g -O2 -I/usr/local/include/mysql -fno-strict-aliasing -pipe -I/usr/local/include -MT nodehistory.o -MD -MP -MF .deps/nodehistory.Tpo -c -o nodehistory.o nodehistory.c
In file included from nodehistory.h:24,
from nodehistory.c:23:
../../../include/comms.h:121: error: expected '=', ',', ';', 'asm' or '_attribute_' before 'zbx_tcp_recv_ext'

      • Error code 1
        [...]

The problem is that "ssize_t" type is not recognized in comms.h in line:

ssize_t zbx_tcp_recv_ext(zbx_sock_t *s, char **data, unsigned char flags, int timeout);

Including <unistd.h> fixed the problem.

Steps to reproduce:
1) checkout trunk
2) enter trunk directory
3) run: ./bootstrap.sh && ./configure --enable-server --with-mysql && make dbschema > /dev/null && make >/dev/null
4) observer compilation error message



 Comments   
Comment by dimir [ 2011 Nov 17 ]

Set Fix Version/s.

Comment by dimir [ 2011 Nov 17 ]

Fixed in pre-1.9.8 r23322 .

Comment by dimir [ 2011 Nov 17 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4360 .

Comment by dimir [ 2011 Nov 22 ]

Fixed in pre-1.8.10 r23415 .





[ZBX-4376] Quoted spec symbols in lld via proxy Created: 2011 Nov 22  Updated: 2017 May 30  Resolved: 2012 Feb 21

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 1.9.8 (beta)
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Blocker
Reporter: Alexey Pustovalov Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: trivial
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File item_prototypes.png     PNG File items.png    

 Description   

24917:20111122:233650.539 In DCmass_proxy_add_history()
24917:20111122:233650.539 query [txnlev:1]
....
"snmp.discovery":[
....
{
"

{#SNMPINDEX}":10110,
"{#SNMPVALUE}":"GigabitEthernet0
/10"},
{
"{#SNMPINDEX}

":10111,
"

{#SNMPVALUE}

":"GigabitEthernet0
/11"},
....

and we have incorrect item key in zabbix server. Ex.:
????????:?????? ?????? GigabitEthernet0\/16 ifInUcastPkts["GigabitEthernet0\/16"]



 Comments   
Comment by Alexander Vladishev [ 2011 Nov 30 ]

It's normal. All low level discovery data is stored and processed in JSON format. Slashes (/) in JSON strings should be escaped. (www.json.org)

Please attach a screenshot, if you have a problem with LLD.

Comment by Alexey Pustovalov [ 2011 Dec 01 ]

screenshots

Comment by Alexander Vladishev [ 2011 Dec 01 ]

What database you are using on server and proxy side?

Comment by Alexander Vladishev [ 2011 Dec 01 ]

Confirmed, when using mysql on proxy side.

Comment by Alexander Vladishev [ 2011 Dec 01 ]

Could repeat only once. After setting additional debug-information in the code and compilation of a proxy the problem hasn't repeated.

Try to recompile a proxy too using these commands:

./bootstrap.sh
./configure -enable-proxy --with<db> ...
make clean
make dbschema
make install

Comment by Alexey Pustovalov [ 2011 Dec 01 ]

problem remains with last trunk proxy on PostgreSQL.

Comment by Alexey Pustovalov [ 2011 Dec 01 ]

on debian with mysql the problem hasn't repeated.
problem on gentoo with postgresql only.

Comment by Alexander Vladishev [ 2011 Dec 01 ]

Fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-4376

Comment by Alexey Pustovalov [ 2011 Dec 01 ]

working. Thanks

Comment by dimir [ 2011 Dec 01 ]

Do we really want to "set standard_conforming_strings to off;" ?

Comment by Alexander Vladishev [ 2011 Dec 01 ]

You are right! It is the bad idea. In version PostgreSQL 8.1 this variable only for reading. I re-open this problem for finishing.

Comment by Alexander Vladishev [ 2011 Dec 01 ]

Has been fixed by another way. Please retest r23707.

Comment by dimir [ 2011 Dec 02 ]

I like it!

Comment by Alexander Vladishev [ 2011 Dec 02 ]

Fixed in version pre-1.9.9, revision 23728. Backported to pre-1.8.10, revision 23729.

Comment by richlv [ 2014 Jan 30 ]

note that json standard does not require escaping of slashes (only doublequotes and backslashes). from http://www.ietf.org/rfc/rfc4627.txt :

"All Unicode characters may be placed within the quotation marks except for the characters that must be escaped: quotation mark, reverse solidus, and the control characters (U+0000 through U+001F)."

ZBX-5116 talks about similar topic in the frontend/api





[ZBX-4375] Update translate for ru lang Created: 2011 Nov 22  Updated: 2017 May 30  Resolved: 2011 Nov 22

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.10
Fix Version/s: 1.8.10

Type: Incident report Priority: Minor
Reporter: Alexey Pustovalov Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File ru_ru.inc.php    

 Comments   
Comment by richlv [ 2011 Nov 22 ]

there seems to be lack of contact persons on irc - is the translation for S_SHOW_ITEMS_WITHOUT_DATA correct ? isn't it missing the "show" part ?

Comment by Alexey Pustovalov [ 2011 Nov 22 ]

With "show" part label for items without data is too long.
"Показать элементы данных без истории" veeeryy long
Meaning saved without "show" part for ru lang.

Comment by richlv [ 2011 Nov 22 ]

ok then - committed to 1.8 branch rev 23437, thanks

Comment by Oleksii Zagorskyi [ 2011 Nov 22 ]

"Элементы данных без истории" is not the best translation.

If we take a look at the page "latest.php" we will see similar text "Отображать элементы данных, содержащие в названии" which is even longer than mentioned one

So, the proper translation would be "Отображать элементы данных без истории"
Missing word "Отображать" is not very good. IMO.





[ZBX-4377] compilation with --enable-static exits with "Curl library not found" Created: 2011 Nov 23  Updated: 2017 May 30  Resolved: 2011 Dec 28

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Installation (I)
Affects Version/s: 1.8.9
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Minor
Reporter: Robert Jerzak Assignee: dimir
Resolution: Fixed Votes: 0
Labels: static
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Ubuntu 11.10 x86_64


Attachments: Text File config.log     Text File config.log    

 Description   

Compilation with --enable-static exits with:

checking whether libcurl is usable... no
configure: error: Curl library not found

Example:
./configure --prefix=/usr/local/ --bindir=/usr/local/sbin/ --with-mysql=/usr/bin/mysql_config --enable-server --enable-agent --with-net-snmp --with-libcurl --with-openipmi --enable-ipv6

finish with no errors.

./configure --prefix=/usr/local/ --bindir=/usr/local/sbin/ --with-mysql=/usr/bin/mysql_config --enable-server --enable-agent --with-net-snmp --with-libcurl --with-openipmi --enable-ipv6 --enable-static

[...]
checking whether libcurl is usable... no
configure: error: Curl library not found

The issue can be replicated every time on Ubuntu 11.10 x86_64.



 Comments   
Comment by Igor Danoshaites (Inactive) [ 2011 Nov 23 ]

Hi,

I can reproduce the same case on Ubuntu 10.04.3.

When compiling without "enable-static" parameter all is fine, but when using "--enable-static" parameter with the same configure command, appears the following error:

checking for curl-config... /usr/bin/curl-config
checking for the version of libcurl... 7.19.7
checking for libcurl >= version 7.13.1... yes
checking for main in -lcurl... yes
checking whether libcurl is usable... no
configure: error: Curl library not found

Comment by dimir [ 2011 Nov 23 ]

Basically the behavior must be correct here. The problem is the error message though. So what configure does in the "checking whether libcurl is usable" check it compiles simple program that uses libcurl and linkes it statically. libcurl requires bunch of other libraries, which, in turn, must be available in a static versions too. I believe this is the problem, not all the required static libraries are installed.

So the fix is probably to report a proper error in this case, that libcurl is not possible to link statically, instead "libary not found".

That would require some work as we currently just have one message if there are any problem with the library - "library not found". I think we should introduce another one here - "Xxx library is not available for static linking" or something. Which would mean the library itself or any other library it depends on.

Robert, would it be possible to attach config.log which is generated right after the error? Something tells me you are missing a lot of needed static libraries.

Comment by Robert Jerzak [ 2011 Nov 23 ]

config.log from failed enable-static compilation

Comment by dimir [ 2011 Nov 25 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4377

There was incorrect check for static linking of libcurl. Now the error message should clearly state which library is missing.

Comment by Igor Danoshaites (Inactive) [ 2011 Nov 25 ]

Tested that dev branch ZBX-4377, now in case of error appears correct error message: "error: static library gssapi_krb5 required for linking libcurl not found".

Now it is waiting for code review.

Comment by dimir [ 2011 Dec 06 ]

Fixed in pre-1.8.10 r23802, pre-1.9.9 r23803.

Comment by Robert Jerzak [ 2011 Dec 28 ]

I think there is not always correct error message, for example arch (we use it on production systems) linux:

checking for main in -lz ... (cached) yes
checking for main in -lcurl... yes
checking whether libcurl is usable... no
configure: error: libcurl is not available for static linking

Comment by Robert Jerzak [ 2011 Dec 28 ]

config.log from arch linux

Comment by Robert Jerzak [ 2011 Dec 28 ]

I tested it on zabbix 1.8.10.

Comment by dimir [ 2011 Dec 28 ]

I doubt it will be an easy task to compile Zabbix with all these options you chose for configure statically. You realize that in this case you have to have every external library that is needed in a static version? We can't go and check every library if it's available in a static version. The message states that it's not possible to compile a program with librucl (and other things you chose) statically and it is correct.

Compiling statically is not a trivial task. Expecially if you want to have every piece compiled statically. For example it's possible to compile a program linked with libcurl statically and the rest of the libs dynamically, that would be a much easier task but we do not have currently in Zabbix such a way to define which part is to be linked statically and which dynamically. You could do that yourself by playing with Makefiles and gcc options (the position of --static in parameters list to gcc).

Besides, in some cases static linking is not possible at all:

http://stackoverflow.com/questions/3430400/linux-static-linking-is-dead

I'm closing this issue, please re-open if you disagree.

Comment by Walter Heck [ 2012 Aug 14 ]

Would it make sense to reflect in the documentation and in ./configure --help that static linking is not recommended? That could have just saved me a ton of time

Comment by richlv [ 2012 Aug 22 ]

it would make sense, but please open a new issue about it

Comment by dimir [ 2012 Aug 22 ]

I agree on adding that note. Please mention the new issue number here.

Comment by dimir [ 2012 Aug 30 ]

Added a note here:

http://www.zabbix.com/documentation/2.0/manual/installation/install#configure_the_sources

Comment by Jason Markowitz [ 2013 Aug 21 ]

I was able to work around this issue by installing glibc-static packages.





[ZBX-4383] 'host.delete' method in API v. 1.8.8 leaves orphaned 'usermacro' objects in DB Created: 2011 Nov 24  Updated: 2017 May 30  Resolved: 2011 Nov 24

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: API (A)
Affects Version/s: 1.8.8
Fix Version/s: 1.8.10

Type: Incident report Priority: Minor
Reporter: Dhruv Bansal Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: api, hosts, macros
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Linux 2.6.32-31-generic #61-Ubuntu-10.04.3 SMP x86_64 GNU/Linux


Issue Links:
Duplicate
duplicates ZBX-4288 host macros are not deleted from the ... Closed

 Description   

1) Create a host with an associated usermacro.
2) Delete the host using the API's 'host.delete' method.
3) Host will be gone from DB but usermacro object persists.



 Comments   
Comment by Igor Danoshaites (Inactive) [ 2011 Nov 24 ]

Hi,

At this moment this issue is fixed in dev branch ZBX-4288 and after code review this fix will be available in 1.8 branch.

Considering this issue resolved.

Comment by Oleksii Zagorskyi [ 2011 Nov 25 ]

I would prefer to close this issue as duplicate and leave the "Fix Version/s:" empty. IMO.

Comment by richlv [ 2011 Nov 25 ]

although if it was actually fixed and we know the version, it makes sense to set "fix version" to that version.





[ZBX-4391] suffixes not properly supported in trigger testing interface in frontend Created: 2011 Nov 24  Updated: 2017 May 30  Resolved: 2012 Jan 09

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 1.8.10, 1.9.9 (beta)

Type: Incident report Priority: Major
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: suffixes, triggertesting
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate

 Description   

When trigger expression contains the suffixes in the trigger expression then tester always returns FALSE.
Example: "host:test.item.last(0)}<1G"

The last time It worked correctly in the 1.8.2.
In the 1.8.3 - 1.8.9 and current trunk it always return FALSE.



 Comments   
Comment by Vjacheslav Shipillo (Inactive) [ 2011 Nov 30 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391

Comment by Alexey Fukalov [ 2011 Nov 30 ]

(1) [GUI]
Not all suffixes are working (http://www.zabbix.com/documentation/1.8/manual/config/suffixes)

<slava> RESOLVED

<Vedmak> as decided we need support up to Y suffix.
<SlaVa> RESOLVED
<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2011 Nov 30 ]

(3) [GUI]
I think regular expression could be simplyfied to smth like: "/([0-9\.]+)[K|M|G]?/" also case is significant, as "K" is not the same as "k"
<slava> RESOLVED
<Vedmak> in fact regexp can be simplified even more: "/[0-9\.]+[KMG]?/"
<SlaVa> RESOLVED
<Vedmak> CLOSED

Comment by Vjacheslav Shipillo (Inactive) [ 2011 Nov 30 ]

"Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4391"

<zalex> dev branch tested. works as expected.

Comment by Alexander Vladishev [ 2011 Dec 15 ]

(0) is not solved

(4) a trigger expression parser on server side do not support suffixes P (Peta), E (Exa), Z (Zetta) and Y (Yotta). Please, rollback a support of these suffixes on GUI side in the trigger expressions.

<Slava> RESOLVED

sasha Has been fixed in ^/trunk r24449. CLOSED

Comment by Vjacheslav Shipillo (Inactive) [ 2011 Dec 21 ]

Fixed in 24150

Comment by Alexey Fukalov [ 2011 Dec 22 ]

(5) [GUI]
In function "convert" there is still code for converting to yotta etc.
<Slava>RESOLVED r 24185

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2011 Dec 22 ]

(6) [GUI]
Why do you use in test both "button_click" and "click" methods?
Also formatting in test file should be fixed.
<Slava>RESOLVED r 24198

<Vedmak> CLOSED

Comment by richlv [ 2011 Dec 23 ]

(7) new file, testTriggerExpressions.php, should have svn:eol-style svn property set to 'native'
<SlaVa>RESOLVED r 24236

<richlv> CLOSED

Comment by Alexey Fukalov [ 2011 Dec 27 ]

(8) [GUI]
In trunk branch all suffixes like Y, Z, etc. are still acceptable in trigger expressions, is it ok?
<SlaVa> No, it's not ok. RESOLVED r 24282

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2011 Dec 28 ]

(9) [GUI]
Suffixes are left in defines.inc.php and maybe somewhere else..
<Slava>RESOLVED

<Vedmak> CLOSED

Comment by Vjacheslav Shipillo (Inactive) [ 2011 Dec 30 ]

fixed in r 24449

Comment by Oleksii Zagorskyi [ 2011 Dec 30 ]

(10) Missing record for the trunk ChangeLog.
1.9.9 value is missing in the "Fix Version/s:"
Will be REOPENED.
<SlaVa>
Changes for 1.8.10rc1

..F....... ZBX-4391 fixed suffix support in trigger testing interface (slava)

<zalex> I've added the tag 1.9.9 to the "Fix Version/s:"
I'm closing it. ChangeLog processing will be discussed separately.
CLOSED

Comment by richlv [ 2012 Jan 08 ]

(12) added unittest has not been added to SeleniumTests.php

added unittest testTriggerExpressions.php defines it's class name as being "testPageHosts" ...
<Slava> RESOLVED in r 24608

sasha The trigger expression parser and tests to it were completely rewritten in r31649. CLOSED

Comment by richlv [ 2013 Aug 19 ]

still not closed : (4) and (12)

sasha Reviewed and CLOSED.





[ZBX-4413] nbsp in "event generation" dropdown Created: 2011 Dec 01  Updated: 2017 May 30  Resolved: 2011 Dec 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 1.8.10

Type: Incident report Priority: Blocker
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: regression, triggers
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates ZBX-4015 Persistent Cross Site Scripting Vulne... Closed

 Description   

open trigger properties, examine "event generation" dropdown - it has  

broken in r23578 (ZBX-4015)



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2011 Dec 01 ]

This will be fixed in ZBX-4413.

CLOSED.





[ZBX-4424] Handling of the log of long Japanese Created: 2011 Dec 08  Updated: 2017 May 30  Resolved: 2011 Dec 11

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Agent (G), Server (S)
Affects Version/s: 1.8.8, 1.8.9
Fix Version/s: 1.8.10, 1.9.9 (beta), 2.0.0

Type: Incident report Priority: Blocker
Reporter: suzuka Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: items, localization
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

RHEL CentOS 5.6, 6.0 Postgresql-8.4.7



 Description   

I am monitoring Windows EventLog.

When Zabbix Server receives the log of 255 or more Japanese characters(512 bytes or more ?), an error is outputted and data is not registered.

This problem occurs in zabbix1.8.8 and 1.8.9 and it does not coour in 1.8.7 and 1.8.6.

I guess that there is a problem in handling of the Japanese character after 255 character in 1.8.8 or later.

The following is a log when I test.

1) Zabbix v1.8.8
Japanese char 254 -> correct

[pg_log]

2011-12-08 11:06:03 JST: 4352: LOG: duration: 0.480 ms statement: insert into alerts (alertid,actionid,eventid,userid,clock,mediatypeid,sendto,subject,message,status,alerttype,esc_step) values (4703,4,40420,3,1323309963,4,'sasaki@localhost','[????] Error is output to ApplicationLog on Windows2008: PROBLEM','?????????????

Error is output to ApplicationLog on Windows2008: PROBLEM
Last value: ????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

',0,0,0)

[zabbix_server.log]

none

2) Zabbix v1.8.8
Japanese char 255 -> Not correct

[pg_log]

2011-12-08 11:10:32 JST: 4354: ERROR: invalid byte sequence for encoding "UTF8": 0xe32720
2011-12-08 11:10:32 JST: 4354: HINT: This error can also happen if the byte sequence does not match the encoding expected by the server, which is controlled by "client_encoding".
2011-12-08 11:10:32 JST: 4354: ERROR: current transaction is aborted, commands ignored until end of transaction block
2011-12-08 11:10:32 JST: 4354: STATEMENT: insert into history_log (id,itemid,clock,timestamp,source,severity,value,logeventid) values (8,25109,1323310227,1323310148,'EventCreate',4,'???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????',1000);

2011-12-08 11:10:32 JST: 4354: ERROR: current transaction is aborted, commands ignored until end of transaction block

[zabbix_server.log]

3688:20111208:111032.678 [Z3005] query failed: [0] PGRES_FATAL_ERROR:ERROR: invalid byte sequence for encoding "UTF8": 0xe32720
HINT: This error can also happen if the byte sequence does not match the encoding expected by the server, which is controlled by "client_encodi
ng".
[update items set lastclock=1323310227,lastlogsize=15486,mtime=0,prevvalue=lastvalue,lastvalue='??????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????<E3>' where itemid=25109;
]
3688:20111208:111032.679 [Z3005] query failed: [0] PGRES_FATAL_ERROR:ERROR: current transaction is aborted, commands ignored until end of tra
nsaction block
[insert into history_log (id,itemid,clock,timestamp,source,severity,value,logeventid) values (8,25109,1323310227,1323310148,'EventCreate',4,'?
??????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????',1000);
]
3688:20111208:111032.679 [Z3005] query failed: [0] PGRES_FATAL_ERROR:ERROR: current transaction is aborted, commands ignored until end of tra
nsaction block
[select distinct t.triggerid,t.type,t.value,t.error,t.expression,f.itemid from triggers t,functions f,items i where t.triggerid=f.triggerid and
f.itemid=i.itemid and t.status=0 and f.itemid in (25109) order by t.triggerid]

3) Zabbix v1.8.7
Japanese char 254 -> correct

[pg_log]

2011-12-08 11:34:34 JST: 5504: LOG: duration: 0.747 ms statement: insert into alerts (alertid,actionid,eventid,userid,clock,mediatypeid,sendto,subject,message,status,alerttype,esc_step) values (4705,4,40681,3,1323311674,4,'sasaki@localhost','[????] Error is output to ApplicationLog on Windows2008: PROBLEM','?????????????

Error is output to ApplicationLog on Windows2008: PROBLEM
Last value: ??????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

',0,0,0)

[zabbix_server.log]

none

4) Zabbix v1.8.7
Japanese char 255 -> correct

[pg_log]

2011-12-08 11:38:05 JST: 5504: LOG: duration: 0.764 ms statement: insert into alerts (alertid,actionid,eventid,userid,clock,mediatypeid,sendto,subject,message,status,alerttype,esc_step) values (4706,4,40682,3,1323311885,4,'sasaki@localhost','[????] Error is output to ApplicationLog on Windows2008: PROBLEM','?????????????

Error is output to ApplicationLog on Windows2008: PROBLEM
Last value: ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

',0,0,0)

[zabbix_server.log]

none



 Comments   
Comment by Alexander Vladishev [ 2011 Dec 11 ]

Fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-4424

Comment by dimir [ 2011 Dec 12 ]

Please review my changes in r23928.

<Sasha> Great! CLOSED

Comment by Alexander Vladishev [ 2011 Dec 13 ]

Fixed in version pre-1.8.10, revision 23950.





Generated at Thu Mar 28 19:50:44 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.