(1) It would be better to check if CONFIG_VMWARE_FORKS is not 0, rather than using zbx_vmware_get_statistics(). This way we would avoid of unnecessary vmware cache locking if collector(s) are running.
We should use lowercase letters if we are talking about our vmware collector. All of our processes have lowercase names - so we kept similar naming style for vmware collector. If we are talking about VMware as a product - we should use their capitalization (VM - uppercase, ware - lowercase) - VMware (for example VMware checks).
In this case the message is about our collector process - so it should be something like 'vmware collector is not started', or '... not running'. We have messages 'no "process type" processes started', but those messages are used for checking the specific processes - the situation is not quite the same. Maybe we need to double check it with Martins what would be the best choice.
The error messages that are show in frontend should start with uppercase letter and end with .. It would be nice to fix also the rest of error messages in checks_simple.c file.
Viktors Tjarve RESOLVED. Please review the r58010 if you agree with using get_process_type_forks() for process check rather then just checking if CONFIG_VMWARE_FORKS is not 0.
Andris Zeila CLOSED