ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-10318

adding and removing columns and rows in screens uses GET requests

    Details

      Description

      Suppose we are editing a screen and playing with adding and removing columns and rows. The URLs to do these actions will be like these (note the last part):

      http://localhost/zabbix/screenedit.php?config=1&screenid=16&add_col=0
      http://localhost/zabbix/screenedit.php?config=1&screenid=16&rmv_col=0
      http://localhost/zabbix/screenedit.php?config=1&screenid=16&add_row=3
      http://localhost/zabbix/screenedit.php?screenid=16&rmv_row=3
      

      These are GET requests, which means that pressing F5 or simply giving someone these links to go to will perform the corresponding action.

        Issue Links

          Activity

          Hide
          vitalijs.cemeris added a comment - - edited

          RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-10318
          r58408

          Show
          vitalijs.cemeris added a comment - - edited RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-10318 r58408
          Hide
          Alexander Vladishev added a comment - - edited

          (1) new functions addScreenCellGroup() and removeScreenCellGroup():

          • debug functions xdebug_start_trace() and xdebug_stop_trace() must be removed from code
          • getRequest() call cannot be used in auxiliary functions
          • too many API requests can produce these functions (performance issue)

          Alexander Vladishev RESOLVED in r58932, 58934

          Ivo Kurzemnieks CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (1) new functions addScreenCellGroup() and removeScreenCellGroup(): debug functions xdebug_start_trace() and xdebug_stop_trace() must be removed from code getRequest() call cannot be used in auxiliary functions too many API requests can produce these functions (performance issue) Alexander Vladishev RESOLVED in r58932, 58934 Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (2) translation strings changed

          Strings added:

          • must be between "%1$s" and "%2$s"

          Strings deleted:

          • Impossible to remove last row and column.
          • Screen should contain at least one row and column.

          Ivo Kurzemnieks CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (2) translation strings changed Strings added: must be between "%1$s" and "%2$s" Strings deleted: Impossible to remove last row and column. Screen should contain at least one row and column. Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (3) a new method CLink->setUrl() must be removed

          Alexander Vladishev RESOLVED in r58933

          Ivo Kurzemnieks CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (3) a new method CLink->setUrl() must be removed Alexander Vladishev RESOLVED in r58933 Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (4) Validation of "vsize" and "hsize" parameters must be moved into API

          Related issue: ZBX-10517

          Alexander Vladishev RESOLVED in r58953.

          Ivo Kurzemnieks CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (4) Validation of "vsize" and "hsize" parameters must be moved into API Related issue: ZBX-10517 Alexander Vladishev RESOLVED in r58953. Ivo Kurzemnieks CLOSED.
          Hide
          Alexander Vladishev added a comment - - edited

          (5) Cannot insert an empty row/column into the screen

          Screen "Zabbix server" cell X - 0 Y - 1 is already taken. [screenedit.php:250 → addScreenRow() → CFrontendApiWrapper->update() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CScreen->update() → CScreen->updateReal() → CScreen->replaceItems() → CScreenItem->update() → CScreenItem->validateUpdate() → CScreenItem->checkDuplicateResourceInCell() → CApiService::exception() in include/classes/api/services/CScreenItem.php:965]
          

          Related issue: ZBX-10517

          Alexander Vladishev RESOLVED in r58976.

          Ivo Kurzemnieks CLOSED.

          Show
          Alexander Vladishev added a comment - - edited (5) Cannot insert an empty row/column into the screen Screen "Zabbix server" cell X - 0 Y - 1 is already taken. [screenedit.php:250 → addScreenRow() → CFrontendApiWrapper->update() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CScreen->update() → CScreen->updateReal() → CScreen->replaceItems() → CScreenItem->update() → CScreenItem->validateUpdate() → CScreenItem->checkDuplicateResourceInCell() → CApiService::exception() in include/classes/api/services/CScreenItem.php:965] Related issue: ZBX-10517 Alexander Vladishev RESOLVED in r58976. Ivo Kurzemnieks CLOSED.
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (6) Fixed minor coding style issues in r58993. Please review.

          Alexander Vladishev Thanks. CLOSED

          Show
          Ivo Kurzemnieks added a comment - - edited (6) Fixed minor coding style issues in r58993. Please review. Alexander Vladishev Thanks. CLOSED
          Hide
          Ivo Kurzemnieks added a comment -

          TESTED,

          but don't forget to close (6).

          Show
          Ivo Kurzemnieks added a comment - TESTED, but don't forget to close (6).
          Hide
          Alexander Vladishev added a comment -

          Fixed in pre-3.0.2rc1 r58996 and pre-3.1.0 (trunk) r58995.

          Show
          Alexander Vladishev added a comment - Fixed in pre-3.0.2rc1 r58996 and pre-3.1.0 (trunk) r58995.

            People

            • Assignee:
              Unassigned
              Reporter:
              Aleksandrs Saveljevs
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: