Details

      Description

      Consider attached "operations.png". It can be seen that labels marked with red are aligned with the top of the corresponding element on the right. However, labels marked with blue are aligned with their bottom.

      1. add_button_alignment.patch
        0.4 kB
        Alexander Vladishev
      1. add_button_with_textarea.png
        14 kB
      2. incorrect_align.png
        11 kB
      3. operations.png
        38 kB

        Activity

        Hide
        Pavel Amosov added a comment -

        Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435

        Show
        Pavel Amosov added a comment - Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435
        Hide
        Alexander Vladishev added a comment - - edited

        (1) No translation strings changed

        Oleg Egorov CLOSED

        Show
        Alexander Vladishev added a comment - - edited (1) No translation strings changed Oleg Egorov CLOSED
        Hide
        Alexander Vladishev added a comment - - edited

        (2) the label marked with red dot still aligned incorrectly

        Alexander Vladishev RESOLVED in r59093

        Oleg Egorov CLOSED

        Show
        Alexander Vladishev added a comment - - edited (2) the label marked with red dot still aligned incorrectly Alexander Vladishev RESOLVED in r59093 Oleg Egorov CLOSED
        Hide
        Pavel Amosov added a comment - - edited

        Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435
        Also, field names should be put inside labels for IE compatibility

        Show
        Pavel Amosov added a comment - - edited Fixed in svn://svn.zabbix.com/branches/dev/ZBX-10435 Also, field names should be put inside labels for IE compatibility
        Hide
        Alexander Vladishev added a comment - - edited

        (3) In FF Add button is not aligned properly with text areas.

        Patch (add_button_alignment.patch) attached. Thanks to Pavel Amosov.

        Alexander Vladishev RESOLVED in r59094

        Oleg Egorov CLOSED. But added related issues is ZBX-10570

        Show
        Alexander Vladishev added a comment - - edited (3) In FF Add button is not aligned properly with text areas. Patch ( add_button_alignment.patch ) attached. Thanks to Pavel Amosov . Alexander Vladishev RESOLVED in r59094 Oleg Egorov CLOSED. But added related issues is ZBX-10570
        Hide
        Oleg Egorov added a comment - - edited

        (4)

        –Undefined index: esc_step_from [actionconf.php:367 → sortOperations() in include\actions.inc.php:911]
        –Undefined index: esc_step_to [actionconf.php:367 → sortOperations() in include\actions.inc.php:912]
        –Undefined index: esc_period [actionconf.php:367 → sortOperations() in include\actions.inc.php:913]
        

        In ZBX-10435 was displayed undefined index issue, but I can't reproduce it again.
        Please check it.

        Alexander Vladishev It is easy to reproduce:

        • open discovery action in a first tab;
        • open list of trigger actions in second tab;
        • update any operation in first tab

        These errors is not related to this fix but will be fixed here.

        Alexander Vladishev RESOLVED in r59131.

        Ivo Kurzemnieks Minor code refactoring in r59290, please review.

        Alexander Vladishev Good idea! CLOSED

        Show
        Oleg Egorov added a comment - - edited (4) –Undefined index: esc_step_from [actionconf.php:367 → sortOperations() in include\actions.inc.php:911] –Undefined index: esc_step_to [actionconf.php:367 → sortOperations() in include\actions.inc.php:912] –Undefined index: esc_period [actionconf.php:367 → sortOperations() in include\actions.inc.php:913] In ZBX-10435 was displayed undefined index issue, but I can't reproduce it again. Please check it. Alexander Vladishev It is easy to reproduce: open discovery action in a first tab; open list of trigger actions in second tab; update any operation in first tab These errors is not related to this fix but will be fixed here. Alexander Vladishev RESOLVED in r59131. Ivo Kurzemnieks Minor code refactoring in r59290, please review. Alexander Vladishev Good idea! CLOSED
        Hide
        Ivo Kurzemnieks added a comment -

        TESTED,

        don't forget to close (4).

        Show
        Ivo Kurzemnieks added a comment - TESTED, don't forget to close (4).
        Hide
        Alexander Vladishev added a comment -

        Fixed in:

        • pre-3.0.2 r59294
        • pre-3.1.0 (trunk) r59295
        Show
        Alexander Vladishev added a comment - Fixed in: pre-3.0.2 r59294 pre-3.1.0 (trunk) r59295

          People

          • Assignee:
            Unassigned
            Reporter:
            Aleksandrs Saveljevs
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: