Uploaded image for project: 'ZABBIX BUGS AND ISSUES'
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-10576

Restructure unixODBC related code

    XMLWordPrintable

Details

    • Team A
    • Sprint 15, Sprint 16, Sprint 17, Sprint 18, Sprint 19
    • 3

    Description

      Zabbix interface for unixODBC library has following flaws:

      • There are two places where unixODBC headers are (indirectly) included:
        • src/libs/zbxdbhigh/odbc.c
        • src/zabbix_server/poller/checks_db.c
      • File odbc.c is compiled as a part of libzbxdbhigh.a but has its own header include/zbxodbc.h
      • ODBC handle structure serves both as handle and result structure

      We should either

      • make a standalone unixODBC lib with it's own include/zbxodbc.h, src/libs/zbxodbc, libzbxodbc.a and hide all unixODBC details there
      • or move all related stuff from src/libs/zbxdbhigh/odbc.c to src/zabbix_server/poller/checks_db.c and remove include/zbxodbc.h because it is not used anywhere else (we do similarly with netSNMP, OpenIPMI and libSSH2)

      Attachments

        Issue Links

          Activity

            People

              glebs.ivanovskis Glebs Ivanovskis (Inactive)
              glebs.ivanovskis Glebs Ivanovskis (Inactive)
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: