Uploaded image for project: 'ZABBIX BUGS AND ISSUES'
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-10820

Potential loss of data when server/proxy processes zabbix_sender data

    XMLWordPrintable

Details

    • Team A
    • Sprint 12, Sprint 13, Sprint 14, Sprint 15, Sprint 16
    • 2

    Description

      Thanks to (86) of ZBXNEXT-1263 we now save peer hostname/IP in peer field of zbx_socket_t structure and reuse when necessary.

      The only exception is zbx_tcp_check_security() calling getpeername() and inet_ntoa()/zbx_getnameinfo() independently. We should reuse peer at least and possibly think about storing getpeername() result in zbx_socket_t structure too on stage of zbx_tcp_accept().

      Suppose zabbix_sender disconnects (due to timeout or network failure) right after server/proxy performs zbx_tcp_accept(). Server/proxy will be able to read sender data but will have to reject it because of security restriction since second call of getpeername() will fail.

      Also peer in zbx_socket_t and host in zbx_get_ip_by_socket() use different in size static buffers.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              glebs.ivanovskis Glebs Ivanovskis (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: