Details
-
Problem report
-
Status: Closed
-
Trivial
-
Resolution: Fixed
-
3.4.0alpha1
-
Windows
-
Team A
-
Sprint 12, Sprint 13, Sprint 14, Sprint 15, Sprint 16
-
0.5
Description
In include/perfmon.h there is a definition of an enum type without a name:
typedef enum
{
PERF_COUNTER_NOTSUPPORTED = 0,
PERF_COUNTER_INITIALIZED,
PERF_COUNTER_GET_SECOND_VALUE, /* waiting for the second raw value (needed for some, e.g. rate, counters) */
PERF_COUNTER_ACTIVE,
};
and hence these values need to be stored in a generic int:
typedef struct perf_counter_data
{
...
int status;
...
}
PERF_COUNTER_DATA;
Would be so much better for readability to give this type a meaningful name.
P.S. Also struct type naming does not follow the latest guidelines.