-
Problem report
-
Resolution: Fixed
-
Trivial
-
4.0.12, 4.2.6
-
Any version of macOS
-
Sprint 56 (Sep 2019), Sprint 57 (Oct 2019), Sprint 58 (Nov 2019)
-
0.25
Steps to reproduce:
- Install zabbix-agent via pkg
- Modify file `/usr/local/etc/zabbix/zabbix_agentd.conf`
- Re-install zabbix agent via pkg
Result:
Extra unnecessary files will be left by second installer: `/usr/local/etc/zabbix/zabbix_agentd/userparameter_{examples,mysql}.conf.NEW` while their counterparts (without '.NEW' suffix is identical to them)
Expected:
No such files
How to Fix:
Replace line 37 of postinstall scripts (`cmp --silent "${file_new}" "${file}" || ret=$?`) with `cmp --silent "${file_new}" "${file}"; ret=$?`
What happens is `ret` variable reused in cycle and not set to zero on next loop.