-
Problem report
-
Resolution: Fixed
-
Trivial
-
None
-
None
-
Sprint 71 (Dec 2020)
-
0.5
Initially discovered by coverity that return status of a function is not used.
Please find the latest report on new defect(s) introduced to Zabbix found with Coverity Scan. 1 new defect(s) introduced to Zabbix found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 313559: Error handling issues (CHECKED_RETURN) /src/zabbix_server/lld/lld_manager.c: 600 in lld_manager_thread() ________________________________________________________________________________________________________ *** CID 313559: Error handling issues (CHECKED_RETURN) /src/zabbix_server/lld/lld_manager.c: 600 in lld_manager_thread() 594 595 time_stat = time_now; 596 processed_num = 0; 597 } 598 599 update_selfmon_counter(ZBX_PROCESS_STATE_IDLE); >>> CID 313559: Error handling issues (CHECKED_RETURN) >>> Calling "zbx_ipc_service_recv" without checking return value (as is done elsewhere 4 out of 5 times). 600 zbx_ipc_service_recv(&lld_service, 1, &client, &message); 601 update_selfmon_counter(ZBX_PROCESS_STATE_BUSY); 602 603 sec = zbx_time(); 604 zbx_update_env(sec); 605
Here it is visible that indeed lld manager is missing idle time from process state while preprocessing manager has it:
lld manager #1 [processed 0 LLD rules during 5.005197 sec] preprocessing manager #1 [queued 0, processed 0 values, idle 5.005245 sec during 5.0
Expected:
Process state should be consistent across managers where possible.
