User must understand what he doing, increasing colspan or rowspan is needed only then it's needed, otherwise table probably will be fail..
with such reasoning we could remove any sanity checks or validation. disagree, proper span validation is important
RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-1946.
Seems row span sometimes validated as row span, i set row span 2 and get error about column span.
As we discussed make checkSpan and checkSpanInBounds methods check both spans at once.
In validate* methods API calls probably should be changed to something more lightweight either direct raw sql or select constructor.
Fixed in 2.0.4rc1 r30600 and 2.1.0 r30601.
(4) this added error messages like :
Incorrect row span provided for screen element.
Incorrect column span provided for screen element.
that's great... but maybe we can somehow indicate which element is that ?
maybe x & y or some other way
Pavels Jelisejevs Hm, how about "Incorrect row span provided for screen element located at X - 3 and Y - 4."? Doesn't sound good to me, but I can't think of a better alternative.
Pavels Jelisejevs RESOLVED.
Pavels Jelisejevs CLOSED.
(5) "Screen elements column span is too big."
does that refer to a single element's span, or is it 'undefined' (can be any amount of elements) ? in the first case we probably should add apostrophe, in the second case - use singular "element".
also, similar as (4), can/do we provide more information here ?
Improved error messages in svn://svn.zabbix.com/branches/dev/ZBX-1946. RESOLVED.
New messages have two "%1$s" references.
When it's fixed, can be merged.
Error messages improved in 2.0.5rc1 r32086 and 2.1.0 r32088.