ZABBIX BUGS AND ISSUES

row and column span in screens exceeds normal cell area

Details

  • Zabbix ID:
    RTF

Description

screate a 1x1 screen, insert into it any element and set row & column span for it to be 2 & 2. as a result, this element bleeds over to the control column and row - see the screenshot

Issue Links

Activity

Hide
Eduards Samersovs added a comment -

User must understand what he doing, increasing colspan or rowspan is needed only then it's needed, otherwise table probably will be fail..

Show
Eduards Samersovs added a comment - User must understand what he doing, increasing colspan or rowspan is needed only then it's needed, otherwise table probably will be fail..
Hide
richlv added a comment -

with such reasoning we could remove any sanity checks or validation. disagree, proper span validation is important

Show
richlv added a comment - with such reasoning we could remove any sanity checks or validation. disagree, proper span validation is important
Hide
Pavels Jelisejevs added a comment -

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-1946.

Show
Pavels Jelisejevs added a comment - RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-1946.
Hide
Alexey Fukalov added a comment - - edited

(1)
Seems row span sometimes validated as row span, i set row span 2 and get error about column span.

<pavels> RESOLVED.

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (1) Seems row span sometimes validated as row span, i set row span 2 and get error about column span. <pavels> RESOLVED. <Vedmak> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(2)
As we discussed make checkSpan and checkSpanInBounds methods check both spans at once.

<pavels> RESOLVED.

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (2) As we discussed make checkSpan and checkSpanInBounds methods check both spans at once. <pavels> RESOLVED. <Vedmak> CLOSED
Hide
Alexey Fukalov added a comment - - edited

(3)
In validate* methods API calls probably should be changed to something more lightweight either direct raw sql or select constructor.

<pavels> RESOLVED.

<Vedmak> CLOSED

Show
Alexey Fukalov added a comment - - edited (3) In validate* methods API calls probably should be changed to something more lightweight either direct raw sql or select constructor. <pavels> RESOLVED. <Vedmak> CLOSED
Hide
Pavels Jelisejevs added a comment -

Fixed in 2.0.4rc1 r30600 and 2.1.0 r30601.

CLOSED.

Show
Pavels Jelisejevs added a comment - Fixed in 2.0.4rc1 r30600 and 2.1.0 r30601. CLOSED.
Hide
richlv added a comment - - edited

(4) this added error messages like :
Incorrect row span provided for screen element.
Incorrect column span provided for screen element.

that's great... but maybe we can somehow indicate which element is that ?
maybe x & y or some other way

Pavels Jelisejevs Hm, how about "Incorrect row span provided for screen element located at X - 3 and Y - 4."? Doesn't sound good to me, but I can't think of a better alternative.

Pavels Jelisejevs RESOLVED.

Pavels Jelisejevs CLOSED.

Show
richlv added a comment - - edited (4) this added error messages like : Incorrect row span provided for screen element. Incorrect column span provided for screen element. that's great... but maybe we can somehow indicate which element is that ? maybe x & y or some other way Pavels Jelisejevs Hm, how about "Incorrect row span provided for screen element located at X - 3 and Y - 4."? Doesn't sound good to me, but I can't think of a better alternative. Pavels Jelisejevs RESOLVED. Pavels Jelisejevs CLOSED.
Hide
richlv added a comment - - edited

(5) "Screen elements column span is too big."

does that refer to a single element's span, or is it 'undefined' (can be any amount of elements) ? in the first case we probably should add apostrophe, in the second case - use singular "element".

also, similar as (4), can/do we provide more information here ?

Pavels Jelisejevs RESOLVED.

Pavels Jelisejevs CLOSED.

Show
richlv added a comment - - edited (5) "Screen elements column span is too big." does that refer to a single element's span, or is it 'undefined' (can be any amount of elements) ? in the first case we probably should add apostrophe, in the second case - use singular "element". also, similar as (4), can/do we provide more information here ? Pavels Jelisejevs RESOLVED. Pavels Jelisejevs CLOSED.
Hide
Pavels Jelisejevs added a comment -

Improved error messages in svn://svn.zabbix.com/branches/dev/ZBX-1946. RESOLVED.

Show
Pavels Jelisejevs added a comment - Improved error messages in svn://svn.zabbix.com/branches/dev/ZBX-1946. RESOLVED.
Hide
Alexey Fukalov added a comment - - edited

(1)
New messages have two "%1$s" references.

When it's fixed, can be merged.

Pavels Jelisejevs CLOSED.

Show
Alexey Fukalov added a comment - - edited (1) New messages have two "%1$s" references. When it's fixed, can be merged. Pavels Jelisejevs CLOSED.
Hide
Pavels Jelisejevs added a comment -

Error messages improved in 2.0.5rc1 r32086 and 2.1.0 r32088.

CLOSED.

Show
Pavels Jelisejevs added a comment - Error messages improved in 2.0.5rc1 r32086 and 2.1.0 r32088. CLOSED.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: