Uploaded image for project: 'ZABBIX BUGS AND ISSUES'
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-24389

Agent2 and Web Service targets aren't rebuilt after first build

XMLWordPrintable

    • S24-W16/17, S24-W20/21
    • 0.25

      In ZBX-23441, the target names for building the zabbix_agent2 and zabbix_web_service binaries were updated to be the actual names of the binary files.

      Previously, these were names in the module, while the built output were the current target names (filenames in the bin directory tree).

      The effect this had, was that the targets were always built, as the previous name was never created on the filesystem, hence considered outdated by make.

      The current effect is that this target is built, but is considered up-to-date by make on subsequent invocations, as the target does not have any pre-requisites, and the body of the target is not evaluated, as the file exists.

      This leads to the executables not being rebuilt after the first build, and requires removing and rebuilding them for changes in the source to take effect.

      To restore the previous behavior, the targets can be forced to always build, by depending on a force target.

      It would obviously be great if proper prerequisites could be defined, but this isn't C, and it's more hassle than it's worth, as the go tooling is smart enough to not rebuild cached objects it doesn't need to and in the worst case (i.e. no modifications) simply relinks the target.

            jlambda Juris Lambda
            jlambda Juris Lambda
            Team I
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: