added a comment - - edited

(2)

Quality of preparing so many and important phrases is very very important to not do extra work for translators.

I hope in your understanding.

Let's go.

Some strings:

'N = 1 - if last and previous values differs, 0 - otherwise.'

'N = 1 - if timestamp is equal with Zabbix server time for T seconds, 0 - otherwise'

'N = 1 - last value matches regular expression V for last T seconds, 0 - otherwise.'

'N = 1 - last value matches regular expression V for last T seconds, 0 - otherwise. (non case-sensitive)'

'N = 1 - last Event ID matches regular expression T, 0 - otherwise.'

'N < 1 - last log source of the last log entry matches T, 0 - otherwise.'

'N < 1 - no data received during period of T seconds, 0 - otherwise'

These all strings (and their variations) should be transformed and should look similarly to other descriptions. I showed that on the screenshot (see such transformation in Ukrainian translation).

For example, first string would be:

'Last and previous values differs - then N = 1, 0 - otherwise.'

^{}richlv we should clean them up, but probably not spend too much time on it - that dialog should be completely redesigned anyway

the first one would make more sense to me as :

"If last two values are the same, N = 0, if they differ N = 1"

^{}Oleksiy Zagorskyi

Taking into account my suggestions from (4) and (5) here are my suggestion for new strings above:

Timestamp does not differ from Zabbix server time for more than T seconds - then N = 1, 0 - otherwise'

Check regular expression V in last (most recent) value of a period T. N = 1 - if matches, 0 - otherwise'

Check regular expression V in last (most recent) value of a period T. N = 1 - if matches, 0 - otherwise. (non case-sensitive)'

Event ID of the last log entry matches regular expression T - then N = 1, 0 - otherwise.'

Log source of the last log entry matches parameter T - then N = 1, 0 - otherwise.'

No data received during period of time T - then N = 1, 0 - otherwise'

^{}Oleg Egorov RESOLVED

^{}Martins Valkovskis I would suggest these strings:

'Different last and preceding values is N = 1, 0 - otherwise.'

'Timestamp not different from Zabbix server time for more than T seconds is N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T is N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T is N = 1, 0 - otherwise. (non case-sensitive)'

'Regular expression T matching last log entry event ID is N = 1, 0 - otherwise.'

'Log source of the last log entry matching parameter T is N = 1, 0 - otherwise.'

'No data received during period of time T is N = 1, 0 - otherwise.'

^{}Oleksiy Zagorskyi

your suggestion - 'Different last and preceding values is N = 1, 0 - otherwise.'

If we accept this style then we need rewrite all rest strings in this style.

But personally I do not like replacement "then" to "is", it looks not clear for me.

And I agree for improved "timestamp...".

^{}Martins Valkovskis Well. it's the best I could do that is logically and grammatically correct (hopefully) and does not start with "If". Perhaps it is important to realize that this set of messages is a bit more complex than the other messages in the list. So, whichever way we go, someone will not like it.

^{}Martins Valkovskis also, you can find "is" in the other messages too.

^{}Oleksiy Zagorskyi but in other messages the "is" word located in **another place** (Something **is** > N) and has **another meaning**

^{}Martins Valkovskis OK, I'll throw in another set of suggestions:

'Difference between last and preceding values, if N = 1, 0 - otherwise.'

'Timestamp not different from Zabbix server time for more than T seconds, if N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T, if N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T, if N = 1, 0 - otherwise (non case-sensitive).'

'Regular expression T matching last log entry event ID, if N = 1, 0 - otherwise.'

'Log source of the last log entry matching parameter T, if N = 1, 0 - otherwise.'

'No data received during period of time T, if N = 1, 0 - otherwise.'

Perhaps these work better in that silly form. Basically the message should only explain the function (as the field says 'Function'), not the meanings of N. Values of N could be listed, with their meanings, against the N (in that case a dropdown or something), depending on the chosen function...that is, if the form was designed differently and actually made sense

^{}Oleg Egorov RESOLVED

^{}Oleksiy Zagorskyi sorry, I cannot agree.

I agree that my English is ... as it is, but my logic should be ok (IMO).

Changes above **break** logic. I believe that regular zabbix user considers trigger expression in another way (logic). We do not consider what is the N (right part), but consider what is the expression (left part) itself !

That's why I suggest replace "if" to "then" and some other changes.

My renewed suggestions:

'Difference between last and preceding values, then N = 1, 0 - otherwise.'

'Timestamp not different from Zabbix server time for more than T seconds, then N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T, then N = 1, 0 - otherwise.'

'Regular expression V matching last value in period T, then N = 1, 0 - otherwise (non case-sensitive).'

'Event ID of last log entry matching regular expression T, then N = 1, 0 - otherwise.'

'Log source of the last log entry matching parameter T, then N = 1, 0 - otherwise.'

^{}Martins Valkovskis If users would be better off this way, OK.

^{}Oleg Egorov RESOLVED

^{}Oleksiy Zagorskyi fuhhh, thanks ! CLOSED

^{}Oleksiy Zagorskyi We forgot to return back "then" instead of "if" (used temporary in the middle of development) for "nodata" function.

REOPENED

^{}Oleg Egorov RESOLVED IN svn://svn.zabbix.com/branches/dev/ZBX-3204 r31172

^{}Oleksiy Zagorskyi checked, CLOSED

Oleksiy,

It still actual for latest 2.0 code?