-
Incident report
-
Resolution: Incomplete
-
Major
-
None
-
None
sort of a followup to ZBX-1344
since the list posted there, situation has slightly improved (down to 64 unused functions from 93 - but that still seems terribly high).
in trunk we have 73 unused functions, excluding tests
some might be correctly unused (like debug functions), but surely not all of them. also, this highlights a few gems in commit messages and change piling - for example, revision 10349 moved several functions from config.inc.php to debug.inc.php. commit message ?
"fixed error when create dependency for trigger that belongs to same template"
functions that were unused then and are unused still in 1.8 svn head :
function __autoload from ./include/config.inc.php not referenced anywhere
function deleteByTriggerIDs from ./api/classes/class.cevent.php not referenced anywhere
function delete_expression_by_regexpid from ./include/regexp.inc.php not referenced anywhere
function deleteHostMacro from ./api/classes/class.cusermacro.php not referenced anywhere
function destroy_objects from ./include/classes/class.cobject.php not referenced anywhere
function endAPITransactions from ./api/classes/class.czbxapi.php not referenced anywhere
function _exception from ./include/classes/class.cjson.php not referenced anywhere
function getArgument from ./include/classes/class.curl.php not referenced anywhere
function getFile from ./include/classes/class.curl.php not referenced anywhere
function getImg from ./include/classes/class.ctree.php not referenced anywhere
function getPassword from ./include/classes/class.curl.php not referenced anywhere
function getReference from ./include/classes/class.curl.php not referenced anywhere
function getShifts from ./include/classes/class.cchart.php not referenced anywhere
function getUserName from ./include/classes/class.curl.php not referenced anywhere
function getValue from ./include/classes/class.ccomboitem.php not referenced anywhere
function hideHeader from ./include/classes/class.ctriggersinfo.php not referenced anywhere
function implode_objects from ./include/classes/class.cobject.php not referenced anywhere
function is_error from ./api/rpc/class.cjsonrpc.php not referenced anywhere
function natksort from ./include/func.inc.php not referenced anywhere
function setCaption from ./include/classes/class.ccomboitem.php not referenced anywhere
function setGridStep from ./include/classes/class.cbar.php not referenced anywhere
function setPassword from ./include/classes/class.curl.php not referenced anywhere
function setPath from ./include/classes/class.curl.php not referenced anywhere
function setPort from ./include/classes/class.curl.php not referenced anywhere
function setProtocol from ./include/classes/class.curl.php not referenced anywhere
function setQuery from ./include/classes/class.curl.php not referenced anywhere
function setReference from ./include/classes/class.curl.php not referenced anywhere
function setRows from ./include/classes/class.ctextarea.php not referenced anywhere
function setRowSpan from ./include/classes/class.ccol.php not referenced anywhere
function setUserName from ./include/classes/class.curl.php not referenced anywhere
function showBody from ./include/classes/class.ctag.php not referenced anywhere
function showEnd from ./include/classes/class.ctag.php not referenced anywhere
function showRow from ./include/classes/class.ctable.php not referenced anywhere
function switchPieExploded from ./include/classes/class.cpie.php not referenced anywhere
function zbx_dbconcat from ./include/db.inc.php not referenced anywhere
function zbx_sql_mod from ./include/db.inc.php not referenced anywhere
since then, new unused functions :
function deleteDependencies from ./api/classes/class.ctrigger.php not referenced anywhere
function addChecks from ./api/classes/class.cdrule.php not referenced anywhere
function deleteChecks from ./api/classes/class.cdrule.php not referenced anywhere
function create_real from ./api/classes/class.capplication.php not referenced anywhere
function update_real from ./api/classes/class.capplication.php not referenced anywhere
function deleteElements from ./api/classes/class.cmap.php not referenced anywhere
function parseMacro from ./api/classes/class.ctriggerexpression.php not referenced anywhere
function getLatestCloseTime from ./include/sounds.inc.php not referenced anywhere
function zbx_implodeHash from ./include/func.inc.php not referenced anywhere
function bcround from ./include/func.inc.php not referenced anywhere
function get_action_by_actionid from ./include/actions.inc.php not referenced anywhere
function imageDiagonalMarks from ./include/graphs.inc.php not referenced anywhere
function DashedRectangle from ./include/graphs.inc.php not referenced anywhere
function showMemoryPick from ./include/copt.lib.php not referenced anywhere
function showExpressionErrors from ./include/triggers.inc.php not referenced anywhere
function SDB from ./include/debug.inc.php not referenced anywhere
function VDP from ./include/debug.inc.php not referenced anywhere
function delete_script from ./include/scripts.inc.php not referenced anywhere
function get_services_links_by_linkid from ./include/services.inc.php not referenced anywhere
function zbx_addJSLocale from ./include/js.inc.php not referenced anywhere
function get_sysmap_by_sysmapid from ./include/maps.inc.php not referenced anywhere
function setAccessKey from ./include/classes/class.cbutton.php not referenced anywhere
function __get from ./include/classes/class.cpagefilter.php not referenced anywhere
function getTriggerCB from ./include/classes/class.cpagefilter.php not referenced anywhere
function addRectArea from ./include/classes/class.careamap.php not referenced anywhere
function showStart from ./include/classes/class.ctag.php not referenced anywhere
function setBody from ./include/classes/class.cformelement.php not referenced anywhere
function getShadow from ./include/classes/class.cgraphdraw.php not referenced anywhere
unused functions in trunk :
function is_error from ./api/rpc/class.cjsonrpc.php not referenced anywhere
function get_rules from ./api/classes/class.ctrigger.php not referenced anywhere
function deleteDependencies from ./api/classes/class.ctrigger.php not referenced anywhere
function addChecks from ./api/classes/class.cdrule.php not referenced anywhere
function deleteChecks from ./api/classes/class.cdrule.php not referenced anywhere
function deleteElements from ./api/classes/class.cmap.php not referenced anywhere
function parseMacro from ./api/classes/class.ctriggerexpression.php not referenced anywhere
function deleteHostMacro from ./api/classes/class.cusermacro.php not referenced anywhere
function endAPITransactions from ./api/classes/class.czbxapi.php not referenced anywhere
function deleteByTriggerIDs from ./api/classes/class.cevent.php not referenced anywhere
function getLatestCloseTime from ./include/sounds.inc.php not referenced anywhere
function natksort from ./include/func.inc.php not referenced anywhere
function zbx_implodeHash from ./include/func.inc.php not referenced anywhere
function bcround from ./include/func.inc.php not referenced anywhere
function get_tr_event_by_eventid from ./include/events.inc.php not referenced anywhere
function get_action_by_actionid from ./include/actions.inc.php not referenced anywhere
function templated_screen from ./include/screens.inc.php not referenced anywhere
function zbx_dbconcat from ./include/db.inc.php not referenced anywhere
function zbx_sql_mod from ./include/db.inc.php not referenced anywhere
function get_graphs_by_hostid from ./include/graphs.inc.php not referenced anywhere
function imageDiagonalMarks from ./include/graphs.inc.php not referenced anywhere
function DashedRectangle from ./include/graphs.inc.php not referenced anywhere
function showMemoryPick from ./include/copt.lib.php not referenced anywhere
function update_template_dependencies_for_host from ./include/triggers.inc.php not referenced anywhere
function showExpressionErrors from ./include/triggers.inc.php not referenced anywhere
function SDB from ./include/debug.inc.php not referenced anywhere
function VDP from ./include/debug.inc.php not referenced anywhere
function get_items_by_hostid from ./include/items.inc.php not referenced anywhere
function delete_expression_by_regexpid from ./include/regexp.inc.php not referenced anywhere
function __autoload from ./include/config.inc.php not referenced anywhere
function get_services_links_by_linkid from ./include/services.inc.php not referenced anywhere
function zbx_addJSLocale from ./include/js.inc.php not referenced anywhere
function get_sysmap_by_sysmapid from ./include/maps.inc.php not referenced anywhere
function delete_sysmaps_elements_with_triggerid from ./include/maps.inc.php not referenced anywhere
function get_applications_by_templateid from ./include/hosts.inc.php not referenced anywhere
function get_applications_by_hostid from ./include/hosts.inc.php not referenced anywhere
function setSize from ./include/classes/class.clistbox.php not referenced anywhere
function hideHeader from ./include/classes/class.ctriggersinfo.php not referenced anywhere
function setGridStep from ./include/classes/class.cbar.php not referenced anywhere
function setAccessKey from ./include/classes/class.cbutton.php not referenced anywhere
function getValue from ./include/classes/class.ccomboitem.php not referenced anywhere
function setCaption from ./include/classes/class.ccomboitem.php not referenced anywhere
function setPort from ./include/classes/class.curl.php not referenced anywhere
function getArgument from ./include/classes/class.curl.php not referenced anywhere
function setQuery from ./include/classes/class.curl.php not referenced anywhere
function setProtocol from ./include/classes/class.curl.php not referenced anywhere
function setUserName from ./include/classes/class.curl.php not referenced anywhere
function getUserName from ./include/classes/class.curl.php not referenced anywhere
function setPassword from ./include/classes/class.curl.php not referenced anywhere
function getPassword from ./include/classes/class.curl.php not referenced anywhere
function getFile from ./include/classes/class.curl.php not referenced anywhere
function setReference from ./include/classes/class.curl.php not referenced anywhere
function getReference from ./include/classes/class.curl.php not referenced anywhere
function setPath from ./include/classes/class.curl.php not referenced anywhere
function __get from ./include/classes/class.cpagefilter.php not referenced anywhere
function getTriggerCB from ./include/classes/class.cpagefilter.php not referenced anywhere
function addRectArea from ./include/classes/class.careamap.php not referenced anywhere
function setRows from ./include/classes/class.ctextarea.php not referenced anywhere
function setRowSpan from ./include/classes/class.ccol.php not referenced anywhere
function showStart from ./include/classes/class.ctag.php not referenced anywhere
function showBody from ./include/classes/class.ctag.php not referenced anywhere
function showEnd from ./include/classes/class.ctag.php not referenced anywhere
function getForm from ./include/classes/class.ctag.php not referenced anywhere
function getImg from ./include/classes/class.ctree.php not referenced anywhere
function __toString from ./include/classes/class.cobject.php not referenced anywhere
function destroy_objects from ./include/classes/class.cobject.php not referenced anywhere
function implode_objects from ./include/classes/class.cobject.php not referenced anywhere
function switchPieExploded from ./include/classes/class.cpie.php not referenced anywhere
function setBody from ./include/classes/class.cformelement.php not referenced anywhere
function getShifts from ./include/classes/class.cchart.php not referenced anywhere
function _exception from ./include/classes/class.cjson.php not referenced anywhere
function showRow from ./include/classes/class.ctable.php not referenced anywhere
function getShadow from ./include/classes/class.cgraphdraw.php not referenced anywhere