ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-4009

{HOSTNAME} and {IPADDRESS} macros are not resolved in custom labels on network maps in the edit mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9.5 (alpha)
    • Fix Version/s: 1.9.9 (beta)
    • Component/s: Frontend (F)
    • Environment:
      RHEL 5 derivative, PostgreSQL 8.4, PHP 5.1.6

      Description

      I'm not sure whether this is a bug or feature.

      To reproduce:
      1) go to Configuration of network maps menu;
      2) click the Edit link of a map;
      3) set Host label type to Custom label;
      4) in the below text area enter

      {HOSTNAME} {IPADDRESS};
      5) save;
      6) open the map in the editor, see that host label is shown as "{HOSTNAME}

      {IPADDRESS}";
      6) go to network maps monitoring, open the map, see that {HOSTNAME} {IPADDRESS}

      are substituted with the respective values as expected.

        Activity

        Hide
        richlv added a comment - - edited

        that was sort of a planned change, but it has regressions - most notably, makes map editing much harder as identifying map elements now is impossible without opening their properties individually. same goes for all other macros, as before it was possible to simply add a macro to reference item value and immediately see whether it was correct - not possible anymore.

        possible solution would be a "resolve macros" mode - by default they would not be resolved (improves performance), but could be easily enabled.

        this functionality was lost during development of ZBXNEXT-674

        Show
        richlv added a comment - - edited that was sort of a planned change, but it has regressions - most notably, makes map editing much harder as identifying map elements now is impossible without opening their properties individually. same goes for all other macros, as before it was possible to simply add a macro to reference item value and immediately see whether it was correct - not possible anymore. possible solution would be a "resolve macros" mode - by default they would not be resolved (improves performance), but could be easily enabled. this functionality was lost during development of ZBXNEXT-674
        Hide
        Alexei Vladishev added a comment -

        That's the difference between Monitoring and Configuration sections. In Configuration we tend to display configuration parameters as they are without substitution of macros. That's the general approach we applied to maps as well.

        I agree that a special "Preview" button would be a nice touch though.

        Show
        Alexei Vladishev added a comment - That's the difference between Monitoring and Configuration sections. In Configuration we tend to display configuration parameters as they are without substitution of macros. That's the general approach we applied to maps as well. I agree that a special "Preview" button would be a nice touch though.
        Hide
        richlv added a comment -

        after some discussion this was decided to be a serious enough regression in the editing mode to warrant a blocker priority

        Show
        richlv added a comment - after some discussion this was decided to be a serious enough regression in the editing mode to warrant a blocker priority
        Hide
        richlv added a comment - - edited

        rough initial specification at https://zabbix.org/wiki/Docs/specs/ZBX-4009

        <pavels> I think it should affect everything in the map configuration, not just the map itself. Should we resolve all of the macros, or just some of them, e.g HOST.NAME or IPADDRESS? Someone also had a nice idea, that the resolved macros should be highlighted with some color to separate them from plain text.

        Show
        richlv added a comment - - edited rough initial specification at https://zabbix.org/wiki/Docs/specs/ZBX-4009 <pavels> I think it should affect everything in the map configuration, not just the map itself. Should we resolve all of the macros, or just some of them, e.g HOST.NAME or IPADDRESS? Someone also had a nice idea, that the resolved macros should be highlighted with some color to separate them from plain text.
        Hide
        Alexey Fukalov added a comment -

        dev branch: svn://svn.zabbix.com/branches/dev/ZBX-4009

        Show
        Alexey Fukalov added a comment - dev branch: svn://svn.zabbix.com/branches/dev/ZBX-4009
        Hide
        Alexander Vladishev added a comment -

        Successfully tested!

        Show
        Alexander Vladishev added a comment - Successfully tested!
        Hide
        Alexey Fukalov added a comment -

        MERGED: svn://svn.zabbix.com/trunk 24241

        Show
        Alexey Fukalov added a comment - MERGED: svn://svn.zabbix.com/trunk 24241
        Hide
        Oleksiy Zagorskyi added a comment -

        Just for case - do not forget to update http://www.zabbix.com/documentation/2.0/manual/introduction/whatsnew200 with this feature.

        Show
        Oleksiy Zagorskyi added a comment - Just for case - do not forget to update http://www.zabbix.com/documentation/2.0/manual/introduction/whatsnew200 with this feature.
        Hide
        Alexey Fukalov added a comment -

        Added note to What's new.

        Show
        Alexey Fukalov added a comment - Added note to What's new.

          People

          • Assignee:
            Alexey Fukalov
            Reporter:
            Sergey Syreskin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: