Details

    • Type: Incident report
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.8 (beta)
    • Fix Version/s: 2.0.0rc1
    • Component/s: API (A), Frontend (F)
    • Labels:
    • Environment:
      trunk, r24888

      Description

      Some problems found with user macros:

      1. host and template level macros:

      • some macros can disappear at their saving; how to repeat a problem:
        a. add two macros {$A} and {$B}
        b. remove macro {$A}
        c. add macro {$C} and save host or template
        d. only {$C} macro will be saved

      2. template level macros:

      • the distance between macros isn't enough (see a screenshot)

      3. the source code for template/host and global level macros is very different; it should be unified

      4. the validation order of macros isn't logical

      5. in API there aren't some checks

      • a check for duplicated macros

      6. error messages violates coding style; for example:
      frontends/php/api/classes/class.cusermacro.php:735, 738

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                sasha Alexander Vladishev
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: