ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-4894

source ip detection doesn't work with fping3

    Details

      Description

      fping finally seems to be picked up by a new maintainer - which is great (see http://fping.org/ )

      the problem is that zabbix source ip detection breaks with fping3.

      zabbix tries to detect whether fping help output contains -I or -S flag (in that order), and uses that option with the source ip specified.

      unfortunately for zabbix, fping3 uses -I for source interface, and -I comes first in the fping3 help output, so zabbix picks it up and uses -I<sourceip>, which fails and makes fping3 to ignore this parameter

      this is true for both fping 3.0 and 3.1-rc1 (both already used in gentoo)

      1. fping-help.txt
        30 kB
        Aleksandrs Saveljevs

        Activity

        Hide
        richlv added a comment -

        as for how to properly solve this... hard to say. zabbix must be able to detect & work properly with vanilla fping2, patched with both flags and also fping3.

        maybe do 'fping -v' first, if it's >= version 3, use -S (until source interface is implemented in zabbix ), fallback to the existing detection otherwise ?

        Show
        richlv added a comment - as for how to properly solve this... hard to say. zabbix must be able to detect & work properly with vanilla fping2, patched with both flags and also fping3. maybe do 'fping -v' first, if it's >= version 3, use -S (until source interface is implemented in zabbix ), fallback to the existing detection otherwise ?
        Hide
        richlv added a comment -
        Show
        richlv added a comment - referenced in gentoo bug https://bugs.gentoo.org/show_bug.cgi?id=412659
        Hide
        Alexei Vladishev added a comment -

        I am not sure it is a bug, it sounds like a feature request (improvement).

        Show
        Alexei Vladishev added a comment - I am not sure it is a bug, it sounds like a feature request (improvement).
        Hide
        richlv added a comment -

        ...and it might get resolved in fping3, so only early fping3 versions might be affected.
        upstream bug https://github.com/schweikert/fping/issues/2

        Show
        richlv added a comment - ...and it might get resolved in fping3, so only early fping3 versions might be affected. upstream bug https://github.com/schweikert/fping/issues/2
        Hide
        Oleksiy Zagorskyi added a comment - - edited

        FreeBSD started to use v3.4 in its ports three (i.e. as stable branch) from 24 Sep 2012 09:16:00
        http://www.freshports.org/net/fping/

        Debian is using already v3.2 in testing repo and v3.4 in experimental repo.
        They started to test 3.1~rc1 from 26 Apr 2012
        http://packages.debian.org/wheezy/fping
        http://packages.debian.org/experimental/fping

        Show
        Oleksiy Zagorskyi added a comment - - edited FreeBSD started to use v3.4 in its ports three (i.e. as stable branch) from 24 Sep 2012 09:16:00 http://www.freshports.org/net/fping/ Debian is using already v3.2 in testing repo and v3.4 in experimental repo. They started to test 3.1~rc1 from 26 Apr 2012 http://packages.debian.org/wheezy/fping http://packages.debian.org/experimental/fping
        Hide
        Matthew Marlowe added a comment -

        any update on this bug? We're still advising Gentoo Linux users to avoid using fping >= 3.0 with zabbix and have been for over 6 months..I'd like to get clarification if the problem still exists, whether it really is a problem or just a feature request, and/or what the long term solution will be....

        Show
        Matthew Marlowe added a comment - any update on this bug? We're still advising Gentoo Linux users to avoid using fping >= 3.0 with zabbix and have been for over 6 months..I'd like to get clarification if the problem still exists, whether it really is a problem or just a feature request, and/or what the long term solution will be....
        Hide
        richlv added a comment -

        there are no specific plans to support all functionality with fping3 yet. we'll probably get to that when most distributions in wide use will have migrated to it

        Show
        richlv added a comment - there are no specific plans to support all functionality with fping3 yet. we'll probably get to that when most distributions in wide use will have migrated to it
        Hide
        Volker Fröhlich added a comment -

        Information for users of Fedora and EPEL:

        EPEL5 and 6 only ship fping-2.4b2. This version doesn't support setting a source IP address. You've got to set up routing accordingly or mangle datagrams with iptables to manipulate the routing decision, if necessary.

        All maintained Fedora releases ship fping-3.5. We're avoiding the problem of flag detection by hard-coding the flag to -S.

        Show
        Volker Fröhlich added a comment - Information for users of Fedora and EPEL: EPEL5 and 6 only ship fping-2.4b2. This version doesn't support setting a source IP address. You've got to set up routing accordingly or mangle datagrams with iptables to manipulate the routing decision, if necessary. All maintained Fedora releases ship fping-3.5. We're avoiding the problem of flag detection by hard-coding the flag to -S.
        Hide
        Volker Fröhlich added a comment -

        EPEL 7 will have fping 3.5 and the behavior thus will be the same as in Fedora.

        Show
        Volker Fröhlich added a comment - EPEL 7 will have fping 3.5 and the behavior thus will be the same as in Fedora.
        Hide
        Vincent Andries added a comment -

        This seems to also affect Zabbix 2.4.4 release on Debian Wheezy. Debian uses fping version 3.2.

        The patch on http://pkgs.fedoraproject.org/cgit/zabbix.git/tree/zabbix-1.8.12-fping3.patch still seems to fix this.
        Kind of strange that a 3 year old bug is still unresolved...

        Show
        Vincent Andries added a comment - This seems to also affect Zabbix 2.4.4 release on Debian Wheezy. Debian uses fping version 3.2. The patch on http://pkgs.fedoraproject.org/cgit/zabbix.git/tree/zabbix-1.8.12-fping3.patch still seems to fix this. Kind of strange that a 3 year old bug is still unresolved...
        Hide
        Aleksandrs Saveljevs added a comment -

        Attached "fping-help.txt" demonstrates help output for fping tags that are not release candidates (based on https://github.com/schweikert/fping).

        Show
        Aleksandrs Saveljevs added a comment - Attached "fping-help.txt" demonstrates help output for fping tags that are not release candidates (based on https://github.com/schweikert/fping ).
        Hide
        Aleksandrs Saveljevs added a comment -

        Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4894 by preferring "-S" option over "-I" option if both are present.

        Show
        Aleksandrs Saveljevs added a comment - Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4894 by preferring "-S" option over "-I" option if both are present.
        Hide
        Andris Mednis added a comment -

        Successfully tested.

        Show
        Andris Mednis added a comment - Successfully tested.
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        Fixed in pre-2.2.12rc1 r58772, pre-2.4.8rc1 r58773, pre-3.0.2rc1 r58774, pre-3.1.0 (trunk) r58775.

        Show
        Aleksandrs Saveljevs added a comment - - edited Fixed in pre-2.2.12rc1 r58772, pre-2.4.8rc1 r58773, pre-3.0.2rc1 r58774, pre-3.1.0 (trunk) r58775.

          People

          • Assignee:
            Unassigned
            Reporter:
            richlv
          • Votes:
            4 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: