ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-5579

Web-interface displays "Acknowledged" even if a trigger has no events

    Details

      Description

      Web-interface calculates a number of acknowledged events on the tr_status.php and if events do not exist at all web-interface display "Acknowledged" anyway.

        Issue Links

          Activity

          Hide
          Alexey Pustovalov added a comment - - edited

          The problem here:

                                  if($trigger['event_count']){
                                          $to_ack = new CCol(array(new CLink(_('Acknowledge'), 'acknow.php?triggers[]='.$trigger['triggerid'].'&backurl='.$page['file'], 'on'), ' ('.$trigger['event_count'].')'));
                                  }
                                  else{
                                          $to_ack = new CCol(_('Acknowledged'), 'off');
                                  }
          
          

          We think all events already acknowledged if $trigger['event_count'] non-exist or equal 0. But if a trigger has not any events we can not say what they has been acknowledged!

          Show
          Alexey Pustovalov added a comment - - edited The problem here: if($trigger['event_count']){ $to_ack = new CCol(array(new CLink(_('Acknowledge'), 'acknow.php?triggers[]='.$trigger['triggerid'].'&backurl='.$page['file'], 'on'), ' ('.$trigger['event_count'].')')); } else{ $to_ack = new CCol(_('Acknowledged'), 'off'); } We think all events already acknowledged if $trigger ['event_count'] non-exist or equal 0. But if a trigger has not any events we can not say what they has been acknowledged!
          Hide
          richlv added a comment -

          but if there are no events, what should we display then ?

          Show
          richlv added a comment - but if there are no events, what should we display then ?
          Hide
          Alexey Pustovalov added a comment -

          old fired triggers can be without events (small keep time of events for records or partitioning).

          Show
          Alexey Pustovalov added a comment - old fired triggers can be without events (small keep time of events for records or partitioning).
          Hide
          Alexey Fukalov added a comment -

          We decided to show 'No events' string for such triggers.

          Show
          Alexey Fukalov added a comment - We decided to show 'No events' string for such triggers.
          Hide
          Alexey Fukalov added a comment -

          dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579

          Show
          Alexey Fukalov added a comment - dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579
          Hide
          Pavels Jelisejevs added a comment - - edited

          (1) If I select a host without triggers on the trigger status page, I receive an error:

          Undefined variable: triggerIdsWithoutUnackEvents [tr_status.php:400]

          Alexey Fukalov RESOLVED

          Pavels Jelisejevs CLOSED.

          Show
          Pavels Jelisejevs added a comment - - edited (1) If I select a host without triggers on the trigger status page, I receive an error: Undefined variable: triggerIdsWithoutUnackEvents [tr_status.php:400] Alexey Fukalov RESOLVED Pavels Jelisejevs CLOSED.
          Hide
          Pavels Jelisejevs added a comment - - edited

          (2) Can you please change 'noEvents' to 'hasEvents'. I, personally, think it's more intuitive that way.

          Alexey Fukalov RESOLVED

          Pavels Jelisejevs CLOSED.

          Show
          Pavels Jelisejevs added a comment - - edited (2) Can you please change 'noEvents' to 'hasEvents'. I, personally, think it's more intuitive that way. Alexey Fukalov RESOLVED Pavels Jelisejevs CLOSED.
          Hide
          Pavels Jelisejevs added a comment -

          TESTED.

          Show
          Pavels Jelisejevs added a comment - TESTED.
          Hide
          Alexey Fukalov added a comment -

          Fixed in 2.0.4rc1 r30536, pre-2.1.0 r30537.

          Show
          Alexey Fukalov added a comment - Fixed in 2.0.4rc1 r30536, pre-2.1.0 r30537.
          Hide
          Alexander Vladishev added a comment - - edited

          (3) Triggers in an "Acknowledged" status if trigger has only unknown or not significant events. We can't acknowledge these events.

          https://support.zabbix.com/secure/attachment/20492/acknowledged-triggers.jpg

          Show
          Alexander Vladishev added a comment - - edited (3) Triggers in an "Acknowledged" status if trigger has only unknown or not significant events. We can't acknowledge these events. https://support.zabbix.com/secure/attachment/20492/acknowledged-triggers.jpg
          Hide
          Alexey Fukalov added a comment -

          Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579

          Show
          Alexey Fukalov added a comment - Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579
          Show
          Alexey Pustovalov added a comment - - edited (4) That change should be documented on http://www.zabbix.com/documentation/2.0/manual/web_interface/frontend_sections/monitoring/triggers <richlv> mentioned in http://www.zabbix.com/documentation/2.0/manual/introduction/whatsnew204 trigger section part still missing Martins Valkovskis Documented in http://www.zabbix.com/documentation/2.0/manual/web_interface/frontend_sections/monitoring/triggers http://www.zabbix.com/documentation/2.2/manual/web_interface/frontend_sections/monitoring/triggers Alexei Vladishev CLOSED
          Hide
          Eduards Samersovs added a comment - - edited

          (5) Error if filter events by "Show unknown events":
          Undefined index: 10087 [events.php:671]
          Undefined index: [events.php:720]
          Argument 1 passed to hostMenuData() must be an array, null given, called in /home/zabbix/www/testing-ZBX-5579/frontends/php/events.php on line 721 and defined [include/hosts.inc.php:1312]

          Alexey Fukalov seems it caused by event from templated trigger
          Eduards Samersovs CLOSED, seems my database is corrupted

          Show
          Eduards Samersovs added a comment - - edited (5) Error if filter events by "Show unknown events": Undefined index: 10087 [events.php:671] Undefined index: [events.php:720] Argument 1 passed to hostMenuData() must be an array, null given, called in /home/zabbix/www/testing- ZBX-5579 /frontends/php/events.php on line 721 and defined [include/hosts.inc.php:1312] Alexey Fukalov seems it caused by event from templated trigger Eduards Samersovs CLOSED, seems my database is corrupted
          Hide
          Eduards Samersovs added a comment - - edited

          (6) Please pass $_REQUEST['showUnknown'] directly as option to Event API

          Alexey Fukalov left as it is, as discussed.
          Eduards Samersovs CLOSED

          Show
          Eduards Samersovs added a comment - - edited (6) Please pass $_REQUEST ['showUnknown'] directly as option to Event API Alexey Fukalov left as it is, as discussed. Eduards Samersovs CLOSED
          Hide
          Eduards Samersovs added a comment -

          Tested!

          Show
          Eduards Samersovs added a comment - Tested!
          Hide
          Alexey Fukalov added a comment -

          Fixed in 2.0.4rc1 r31036, pre-2.1.0 r31037.

          Show
          Alexey Fukalov added a comment - Fixed in 2.0.4rc1 r31036, pre-2.1.0 r31037.

            People

            • Assignee:
              Unassigned
              Reporter:
              Alexey Pustovalov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: