ZABBIX BUGS AND ISSUES

custom trigger severities not reflected in user media config

Details

  • Zabbix ID:
    NA

Description

a) modify severity names in administration -> general -> trigger severities
b) open media properties for some user. changes done in (a) are not reflected in severity column (still uses NIWAHD, although tooltips are correct)

Issue Links

Activity

Hide
Oleg Egorov added a comment - - edited

Resolved in svn://svn.zabbix.com/branches/dev/ZBX-5621
REV 30382

Show
Oleg Egorov added a comment - - edited Resolved in svn://svn.zabbix.com/branches/dev/ZBX-5621 REV 30382
Hide
Alexey Fukalov added a comment - - edited

(1)
There is problem with utf text, zbx_substr should be used instead of substr.

Oleg Egorov RESOLVED

Alexey Fukalov CLOSED

Show
Alexey Fukalov added a comment - - edited (1) There is problem with utf text, zbx_substr should be used instead of substr. Oleg Egorov RESOLVED Alexey Fukalov CLOSED
Hide
Alexey Fukalov added a comment - - edited

(2)
Also i think function media_severity2str should be rewritten:

function media_severity2str($severity) {
	$result = array();
	foreach (getSeverityCaption() as $i => $caption) {
		$style = ($severity & (1 << $i)) ? 'enabled' : null;
		
		$result[$i] = new CSpan(zbx_substr($caption, 0, 1), $style);
		$result[$i]->setHint($caption.' ('.(isset($map['style']) ? 'on' : 'off').')');
	}

	return $result;
}

Oleg Egorov RESOLVED

Alexey Fukalov CLOSED

Show
Alexey Fukalov added a comment - - edited (2) Also i think function media_severity2str should be rewritten:
function media_severity2str($severity) {
	$result = array();
	foreach (getSeverityCaption() as $i => $caption) {
		$style = ($severity & (1 << $i)) ? 'enabled' : null;
		
		$result[$i] = new CSpan(zbx_substr($caption, 0, 1), $style);
		$result[$i]->setHint($caption.' ('.(isset($map['style']) ? 'on' : 'off').')');
	}

	return $result;
}
Oleg Egorov RESOLVED Alexey Fukalov CLOSED
Hide
Alexander Vladishev added a comment -

Fixed in pre-2.0.4 r30581 and pre-2.1.0 (trunk) r30580.

Show
Alexander Vladishev added a comment - Fixed in pre-2.0.4 r30581 and pre-2.1.0 (trunk) r30580.
Hide
Alexander Vladishev added a comment - - edited

(3) Moved from ZBX-6684. Incorrect severity label is shown when hovering on user profile media list item.

In User profile media tab, when hovering on added media severity labels NIWAHD, value "Off" shows for enabled severities.
This is due to checking non-existent parameter $map['style'] in file media.inc.php: 49

<richlv> hmm. this will be confusing now - issue changes were done for 2.0.4, now it is reopened, and "fix version" will be a mess...

Oleg Egorov RESOLVED IN r36244

Alexander Vladishev REOPENED

media_severity2str() return array of objects. The function should be renamed.

Тhe previous implementation of function was one many simpler and used less variables. Let's return old implementation!

Oleg Egorov RESOLVED IN r36259, 36292

Alexander Vladishev CLOSED Please review my changes in r36298

Oleg Egorov REVIEWED

Show
Alexander Vladishev added a comment - - edited (3) Moved from ZBX-6684. Incorrect severity label is shown when hovering on user profile media list item. In User profile media tab, when hovering on added media severity labels NIWAHD, value "Off" shows for enabled severities. This is due to checking non-existent parameter $map['style'] in file media.inc.php: 49 <richlv> hmm. this will be confusing now - issue changes were done for 2.0.4, now it is reopened, and "fix version" will be a mess... Oleg Egorov RESOLVED IN r36244 Alexander Vladishev REOPENED media_severity2str() return array of objects. The function should be renamed. Тhe previous implementation of function was one many simpler and used less variables. Let's return old implementation! Oleg Egorov RESOLVED IN r36259, 36292 Alexander Vladishev CLOSED Please review my changes in r36298 Oleg Egorov REVIEWED
Hide
Oleg Egorov added a comment -

FIXED IN 2.0.7rc1 r36302 and in 2.1.0(trunk) r36303
CLOSED

Show
Oleg Egorov added a comment - FIXED IN 2.0.7rc1 r36302 and in 2.1.0(trunk) r36303 CLOSED

People

  • Assignee:
    Unassigned
    Reporter:
    richlv
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: