Some API methods should not be public

XMLWordPrintable

    • Type: Incident report
    • Resolution: Won't fix
    • Priority: Major
    • None
    • Affects Version/s: None
    • Component/s: API (A)

      The following methods should have their visibility level set to protected instead of public:

      CApplication::checkInput()
      CDRule::checkInput()
      CHostInterface::checkInput()
      CItem::addRelatedObjects()
      CMap::checkInput()
      CMapElement::checkCircleSelectsLink()
      CService::validateUpdate()
      CService::validateDelete()
      CService::validateAddTimes()
      CService::validateUpdate()
      CUser::checkAuthentication()
      CUser::ldapLogin()
      CUserMacro::getMacros()
      CUserMacro::resolveTrigger()
      CUserMacro::resolveItem()
      CUserMacro::replaceMacros()
      CAction::validateOperations()
      CAction::validateConditions()
      CAction::validateOperationConditions()
      CZBXAPI::tableName()
      CZBXAPI::pk()
      CZBXAPI::pkOption()
      + All syncTemplates() and similar methods.

      This may require some code refactoring.

            Assignee:
            Unassigned
            Reporter:
            Pavels Jelisejevs (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: