ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-5639

Availability report ignores global option "Dropdown first entry"

    Details

      Description

      Even if we select "None" for "Dropdown first entry" global option, on the Availability report "Host group" and "Host" will have "not selected" but actually report works as for "All"

      I.e. we see statistic of all hosts from all groups and it's critical problem on big installations.

      Reproduced for latest 1.8 and 2.0.

        Activity

        Hide
        Oleg Egorov added a comment -

        RESOLVED IN svn://svn.zabbix.com/branches/dev/ZBX-5639 r31105

        Show
        Oleg Egorov added a comment - RESOLVED IN svn://svn.zabbix.com/branches/dev/ZBX-5639 r31105
        Hide
        Toms added a comment - - edited

        (1) Mode: By trigger template
        Select some group and host with triggers
        Triggers doesn't appear in list, thou they should.

        Oleg Egorov RESOLVED

        Toms this problem still exists

        choose template group, then template, then host, now change template. You will see empty list, but host selection is to "all". If you chose some host and then again "all" you will see triggers.

        Oleg Egorov I can't reproduce this issue now, if this problem exist, please say me

        Oleg Egorov RESOLVED

        Toms Revision number missing!
        This is quite hackish leading to following bug:
        mode:"By trigger template"
        open availability report in two tabs
        in first filter some triggers using first 3 drop-downs
        in second tab do the same with diferent template
        in first tab press filter, selected options are gone

        as well there is undefined index:
        Undefined index: filter_hostid [report2.php:80]
        it is noticeable in several combinations, including with mode: "By host"

        Oleg Egorov RESOLVED IN r31322 + minor minor code refactoring in r31323

        Toms CLOSED

        Show
        Toms added a comment - - edited (1) Mode: By trigger template Select some group and host with triggers Triggers doesn't appear in list, thou they should. Oleg Egorov RESOLVED Toms this problem still exists choose template group, then template, then host, now change template. You will see empty list, but host selection is to "all". If you chose some host and then again "all" you will see triggers. Oleg Egorov I can't reproduce this issue now, if this problem exist, please say me Oleg Egorov RESOLVED Toms Revision number missing! This is quite hackish leading to following bug: mode:"By trigger template" open availability report in two tabs in first filter some triggers using first 3 drop-downs in second tab do the same with diferent template in first tab press filter, selected options are gone as well there is undefined index: Undefined index: filter_hostid [report2.php:80] it is noticeable in several combinations, including with mode: "By host" Oleg Egorov RESOLVED IN r31322 + minor minor code refactoring in r31323 Toms CLOSED
        Hide
        Toms added a comment - - edited

        (2)
        if (a) {
        if (b)

        { do(); }

        }
        else

        { do(); }

        Should be written as:
        if (b || !a) { do(); }

        Oleg Egorov RESOLVED

        Toms Changes regarding those "ifs" changed logic and still wasn't optimal. See r31155, if OK close this sub-issue.

        Oleg Egorov CLOSED

        Oleg Egorov After changes in r31155, select in form "By trigger template" works incorrect

        Oleg Egorov Fixed in r31204

        Toms CLOSED. This worked incorrect as well in code from which I made changes

        Show
        Toms added a comment - - edited (2) if (a) { if (b) { do(); } } else { do(); } Should be written as: if (b || !a) { do(); } Oleg Egorov RESOLVED Toms Changes regarding those "ifs" changed logic and still wasn't optimal. See r31155, if OK close this sub-issue. Oleg Egorov CLOSED Oleg Egorov After changes in r31155, select in form "By trigger template" works incorrect Oleg Egorov Fixed in r31204 Toms CLOSED. This worked incorrect as well in code from which I made changes
        Hide
        Toms added a comment - - edited

        (3)
        select_config() should be assigned to variable $config not $gui, as it is everywhere in the code. As well $gui stands for Graphical User Interface and would be misleading anyway. Current variable $config should be renamed to something like $availabilityReportMode.

        Oleg Egorov RESOLVED

        Toms CLOSED

        Show
        Toms added a comment - - edited (3) select_config() should be assigned to variable $config not $gui, as it is everywhere in the code. As well $gui stands for Graphical User Interface and would be misleading anyway. Current variable $config should be renamed to something like $availabilityReportMode. Oleg Egorov RESOLVED Toms CLOSED
        Hide
        Toms added a comment - - edited

        (4) select_config() should be called right before usage of its returned data.

        Oleg Egorov RESOLVED

        Toms CLOSED

        Show
        Toms added a comment - - edited (4) select_config() should be called right before usage of its returned data. Oleg Egorov RESOLVED Toms CLOSED
        Hide
        Toms added a comment - - edited

        (5) as an addition to this issue it would be nice to fix that selected values would be remembered in filter if "remember selected" is selected in configuration.

        Oleg Egorov In form "By trigger template" not need remember "Template trigger" and "Filter by host group" - Pavel decision

        RESOLVED in r31144

        Mode is not remembered now.

        Group and template/host is only remembered if button "filter" is clicked.

        Group and template/host is remembered if checkbox "Remember selected" in Configuration is checked.

        Oleg Egorov RESOLVED

        Toms CLOSED

        Show
        Toms added a comment - - edited (5) as an addition to this issue it would be nice to fix that selected values would be remembered in filter if "remember selected" is selected in configuration. Oleg Egorov In form "By trigger template" not need remember "Template trigger" and "Filter by host group" - Pavel decision RESOLVED in r31144 Mode is not remembered now. Group and template/host is only remembered if button "filter" is clicked. Group and template/host is remembered if checkbox "Remember selected" in Configuration is checked. Oleg Egorov RESOLVED Toms CLOSED
        Hide
        Toms added a comment - - edited

        (6) $_REQUEST['config'] as well should be renamed according to its logic.

        Oleg Egorov RESOLVED

        Toms CLOSED

        Show
        Toms added a comment - - edited (6) $_REQUEST ['config'] as well should be renamed according to its logic. Oleg Egorov RESOLVED Toms CLOSED
        Hide
        Toms added a comment - - edited

        (7)

        if (!isset($_REQUEST['config']))

        { $_REQUEST['config'] = 0; }

        instead of 0, constant AVAILABILITY_REPORT_BY_HOST should be used

        Oleg Egorov RESOLVED

        Toms CLOSED

        Show
        Toms added a comment - - edited (7) if (!isset($_REQUEST ['config'] )) { $_REQUEST['config'] = 0; } instead of 0, constant AVAILABILITY_REPORT_BY_HOST should be used Oleg Egorov RESOLVED Toms CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        I found problem in 2.0.4, don't work "Filter by host group"
        It will be fixed under this ZBX

        Oleg Egorov RESOLVED r31297

        Toms CLOSED

        Show
        Oleg Egorov added a comment - - edited I found problem in 2.0.4, don't work "Filter by host group" It will be fixed under this ZBX Oleg Egorov RESOLVED r31297 Toms CLOSED
        Hide
        Toms added a comment - - edited

        TESTED

        Review my changes in r31462, if OK merge.

        Oleg Egorov CLOSED

        Show
        Toms added a comment - - edited TESTED Review my changes in r31462, if OK merge. Oleg Egorov CLOSED
        Hide
        Oleg Egorov added a comment -

        RESOLVED IN 2.0.4 r31471, 2.1.0 r31472
        CLOSED

        Show
        Oleg Egorov added a comment - RESOLVED IN 2.0.4 r31471, 2.1.0 r31472 CLOSED

          People

          • Assignee:
            Oleg Egorov
            Reporter:
            Oleksiy Zagorskyi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: