Details

      Description

      Some code should be removed from the TriggerPrototype module:

      delete method:

      • DB:delete('events', ....
        the trigger prototypes do not generate events
      • DB::delete('sysmaps_elements', ...
        the trigger prototype doesn't join the screen
      • actions disabling code and deleting action conditions

      get method:

      • withUnacknowledgedEvents option
      • withAcknowledgedEvents option
      • lastChangeSince option
      • lastChangeTill option
      • only_true option

      Something else?

        Activity

        Hide
        Alexander Vladishev added a comment -

        Same problems with GraphPrototype:

        delete method:

        • DB::delete('screens_items', ...
        • DB::delete('profiles', ...
        Show
        Alexander Vladishev added a comment - Same problems with GraphPrototype: delete method: DB::delete('screens_items', ... DB::delete('profiles', ...
        Hide
        Alexey Fukalov added a comment -

        svn://svn.zabbix.com/branches/dev/ZBX-5665

        Show
        Alexey Fukalov added a comment - svn://svn.zabbix.com/branches/dev/ZBX-5665
        Hide
        Alexey Fukalov added a comment -

        Also fixed bug when delete trigger prototype and created triggers are not deleted.

        Show
        Alexey Fukalov added a comment - Also fixed bug when delete trigger prototype and created triggers are not deleted.
        Hide
        Toms added a comment - - edited

        (1) in CGraphPrototype delete() method comment missing type for $graphids

        Alexey Fukalov RESOLVED r30856.

        Toms CLOSED

        Show
        Toms added a comment - - edited (1) in CGraphPrototype delete() method comment missing type for $graphids Alexey Fukalov RESOLVED r30856. Toms CLOSED
        Hide
        Toms added a comment - - edited

        (2) in CGraphPrototype checkInput()method comment - it is OK to give 'true' as return type if function always returns true.
        Samples: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.return.pkg.html

        Alexey Fukalov I think it's incorrect example there. Description says there should be type of variable not value.

        Toms CLOSED

        Show
        Toms added a comment - - edited (2) in CGraphPrototype checkInput()method comment - it is OK to give 'true' as return type if function always returns true. Samples: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.return.pkg.html Alexey Fukalov I think it's incorrect example there. Description says there should be type of variable not value. Toms CLOSED
        Hide
        Toms added a comment - - edited

        (3) Message 'Cannot delete trigger prototype.' in CTriggerPrototype should be something like 'Cannot delete trigger prototype child triggers.'.

        Alexey Fukalov RESOLVED r30856.

        Toms CLOSED

        Show
        Toms added a comment - - edited (3) Message 'Cannot delete trigger prototype.' in CTriggerPrototype should be something like 'Cannot delete trigger prototype child triggers.'. Alexey Fukalov RESOLVED r30856. Toms CLOSED
        Hide
        Toms added a comment - - edited

        (4) Comment for CItemPrototype delete() method is wrong

        Alexey Fukalov RESOLVED r30856.

        Toms CLOSED

        Show
        Toms added a comment - - edited (4) Comment for CItemPrototype delete() method is wrong Alexey Fukalov RESOLVED r30856. Toms CLOSED
        Hide
        Toms added a comment -

        Review my changes, if OK merge

        Show
        Toms added a comment - Review my changes, if OK merge
        Hide
        Alexey Fukalov added a comment -

        Fixed in 2.0.4rc1 r30859, pre-2.1.0 r30860.

        Show
        Alexey Fukalov added a comment - Fixed in 2.0.4rc1 r30859, pre-2.1.0 r30860.
        Hide
        Pavels Jelisejevs added a comment - - edited

        (5) Please add this to the API changelog:

        "Also fixed bug when delete trigger prototype and created triggers are not deleted."

        Alexey Fukalov CLOSED

        Show
        Pavels Jelisejevs added a comment - - edited (5) Please add this to the API changelog: "Also fixed bug when delete trigger prototype and created triggers are not deleted." Alexey Fukalov CLOSED

          People

          • Assignee:
            Alexey Fukalov
            Reporter:
            Alexander Vladishev
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: