ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-5688

bad trigger line in graphs when using suffixes

    Details

      Description

      When using suffixes in trigger expressions , the trigger line in graph do not take the suffix in account :
      using

      {host:sysUptime.last(0)}

      <1h, the trigger line in the graph and legend is '1' rather than 3600.

      I have the same problem using complex triggers :

      {host:system.cpu.load[,avg5].min(#2)}

      >{$MAX_CPU_LOAD} is OK
      but

      {host:system.cpu.load[,avg5].min(#2)}

      >2*{$MAX_CPU_LOAD} gets a trigger line at 2.

        Activity

        Hide
        Alexei Vladishev added a comment -

        I would consider this as a bug.

        Show
        Alexei Vladishev added a comment - I would consider this as a bug.
        Hide
        Alexey Fukalov added a comment -

        Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5688

        Fixed only suffix support. Complex expressions are not supported for graph triggers for now.

        Show
        Alexey Fukalov added a comment - Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5688 Fixed only suffix support. Complex expressions are not supported for graph triggers for now.
        Hide
        Ghozlane TOUMI added a comment -

        hmm. the fix seems not complete,
        from what I understand from source,

        • you translate only K, M and G...
        • for others right hand values, the first numeric value is taken as trigger limit, wich is wrong.
        • trigger > 1h will draw a line at 1 not 3600,
        • trigger > 2*3000 will draw a line at 2.

        please

        • add convertion for time based units,
        • for "complex triggers", at least disable the trigger line (I guess a '$' at the end of the regexp should do)
        Show
        Ghozlane TOUMI added a comment - hmm. the fix seems not complete, from what I understand from source, you translate only K, M and G... for others right hand values, the first numeric value is taken as trigger limit, wich is wrong. trigger > 1h will draw a line at 1 not 3600, trigger > 2*3000 will draw a line at 2. please add convertion for time based units, for "complex triggers", at least disable the trigger line (I guess a '$' at the end of the regexp should do)
        Hide
        Alexey Fukalov added a comment -

        Hmm, all suffixes (TGMKsmhdw) should work in dev branch.
        I added more strict matching for regexp, thank you for suggestion.

        Show
        Alexey Fukalov added a comment - Hmm, all suffixes (TGMKsmhdw) should work in dev branch. I added more strict matching for regexp, thank you for suggestion.
        Hide
        Ghozlane TOUMI added a comment -

        Ignore my comment on units, I was reading the diff backwards . duh.

        Show
        Ghozlane TOUMI added a comment - Ignore my comment on units, I was reading the diff backwards . duh.
        Hide
        Toms added a comment -

        TESTED

        Show
        Toms added a comment - TESTED
        Hide
        Alexey Fukalov added a comment -

        Fixed in 2.0.4rc1 r30864, pre-2.1.0 r30865.

        Show
        Alexey Fukalov added a comment - Fixed in 2.0.4rc1 r30864, pre-2.1.0 r30865.

          People

          • Assignee:
            Alexey Fukalov
            Reporter:
            Ghozlane TOUMI
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: