ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-5814

Incorrect error message for saving trigger with illegal trigger expression

    Details

      Description

      Error message incorrect when trigger expression contains line break. For example:

      Incorrect trigger expression format "

      {constant}={constant}

      &

      {constant}={constant}

      &

      {constant}={constant}

      &

      {constant}={constant}

      &

      {constant}={constant}

      &

      {constant}={constant}

      ". Check expression part starting from "

      {test6:snmp.test1.last(0)}

      =0&

      {test6:snmp.test2.last(0)}

      =0&

      {test6:snmp.test3.last(0)}

      =0&

      {test6:snmp.test4.last(0)}

      =0&

      {test6:snmp.test5.last(0)}

      =0&

      {test6:snmp.test6.last(0)}

      =0".
      for trigger expression:

      {test6:snmp.test1.last(0)}

      =0&

      {test6:snmp.test2.last(0)}

      =0&

      {test6:snmp.test3.last(0)}

      =0&

      {test6:snmp.test4.last(0)}

      =0&\n

      {test6:snmp.test5.last(0)}

      =0&

      {test6:snmp.test6.last(0)}

      =0

      where \n - new line break. Used here only for demonstration the problem.

        Activity

        Hide
        richlv added a comment - - edited

        and what is that error message ?

        edit : as in, what's incorrect about the message ? i believe i figured it out, but it took some staring at the summary, and i'm still not 100% sure
        Alexey Pustovalov Expression part does no start from line break, it starts from first symbol of trigger expression.

        Show
        richlv added a comment - - edited and what is that error message ? edit : as in, what's incorrect about the message ? i believe i figured it out, but it took some staring at the summary, and i'm still not 100% sure Alexey Pustovalov Expression part does no start from line break, it starts from first symbol of trigger expression.
        Hide
        Alexander Vladishev added a comment -

        It will be fixed in trunk only.

        Show
        Alexander Vladishev added a comment - It will be fixed in trunk only.
        Hide
        Oleg Egorov added a comment - - edited

        This issue actual not only for "enter", but also for the letters
        Example:

        {ZBX:11111.last(0)}

        =i0&

        {ZBX:11111.abschange(0)}

        <0

        Incorrect trigger expression format
        Check expression part starting from "

        {ZBX:11111.last(0)}

        =i0&

        {ZBX:11111.abschange(0)}

        <0

        Show
        Oleg Egorov added a comment - - edited This issue actual not only for "enter", but also for the letters Example: {ZBX:11111.last(0)} =i0& {ZBX:11111.abschange(0)} <0 Incorrect trigger expression format Check expression part starting from " {ZBX:11111.last(0)} =i0& {ZBX:11111.abschange(0)} <0
        Hide
        Oleg Egorov added a comment - - edited

        Under this ZBX will be fixed only line breaks

        Oleg Egorov RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-5814 r31407

        Alexander Vladishev This change will not included in stable branches. CLOSED

        Show
        Oleg Egorov added a comment - - edited Under this ZBX will be fixed only line breaks Oleg Egorov RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-5814 r31407 Alexander Vladishev This change will not included in stable branches. CLOSED
        Hide
        Oleg Egorov added a comment -

        Sub issues will be fixed under this fix

        Show
        Oleg Egorov added a comment - Sub issues will be fixed under this fix
        Hide
        Alexander Vladishev added a comment - - edited

        Fixed in pre-1.8.16 r31955, pre-2.0.4 r31650 and pre-2.1.0 r31649.

        Show
        Alexander Vladishev added a comment - - edited Fixed in pre-1.8.16 r31955, pre-2.0.4 r31650 and pre-2.1.0 r31649.
        Hide
        Tony den Haan added a comment -

        I ran into this on 2.0.3, so it has not been fixed. Not sure if it should simply remove linebreaks before parsing, or show proper error message.

        Show
        Tony den Haan added a comment - I ran into this on 2.0.3, so it has not been fixed. Not sure if it should simply remove linebreaks before parsing, or show proper error message.
        Hide
        Michael Brown added a comment -

        What's the status of this? Do newlines in trigger expressions throw an error still or are they stripped before parsing?

        Show
        Michael Brown added a comment - What's the status of this? Do newlines in trigger expressions throw an error still or are they stripped before parsing?
        Hide
        richlv added a comment -

        newlines were likely supported in 2.4, but documentation on that seems to be lacking - see ZBX-10636

        Show
        richlv added a comment - newlines were likely supported in 2.4, but documentation on that seems to be lacking - see ZBX-10636

          People

          • Assignee:
            Unassigned
            Reporter:
            Alexey Pustovalov
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: