Details

      Description

      I create new item:
      Name: 00
      Key: 00
      Units: 00
      Description: 00

      Then i try change 00 to 0
      And nothing!

      Again I have 00!

        Activity

        Hide
        Oleg Egorov added a comment -

        And 0.0 = 0.00 = 00.0

        Show
        Oleg Egorov added a comment - And 0.0 = 0.00 = 00.0
        Hide
        Oleg Egorov added a comment - - edited

        (1) Impossible create host group with name "0"

        Cannot create group without name.
        

        Ivo Kurzemnieks RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6348 r40743
        Eduards Samersovs CLOSED

        Show
        Oleg Egorov added a comment - - edited (1) Impossible create host group with name "0" Cannot create group without name. Ivo Kurzemnieks RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6348 r40743 Eduards Samersovs CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (2)

        Undefined index: itemid [ in C:\xampp\htdocs\trunk\frontends\php\graphs.php:397]
        

        If open graph in "0" host or "0" item

        Oleg Egorov Cannot reproduce, CLOSED

        Show
        Oleg Egorov added a comment - - edited (2) Undefined index: itemid [ in C:\xampp\htdocs\trunk\frontends\php\graphs.php:397] If open graph in "0" host or "0" item Oleg Egorov Cannot reproduce, CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (3) And item prototype, trigger prototype... pages

        No item with itemid="22452".
        No item with itemid="22450".
        No item with itemid="22686".
        

        Oleg Egorov Cannot reproduce, CLOSED

        Show
        Oleg Egorov added a comment - - edited (3) And item prototype, trigger prototype... pages No item with itemid="22452". No item with itemid="22450". No item with itemid="22686". Oleg Egorov Cannot reproduce, CLOSED
        Hide
        Oleg Egorov added a comment - - edited

        (4) Templated graphs, where main graph is "0"
        Have Parent graph "" <- empty

        Oleg Egorov Cannot reproduce, CLOSED

        Show
        Oleg Egorov added a comment - - edited (4) Templated graphs, where main graph is "0" Have Parent graph "" <- empty Oleg Egorov Cannot reproduce, CLOSED
        Hide
        Oleg Egorov added a comment - - edited
        Show
        Oleg Egorov added a comment - - edited See ZBX-6358
        Hide
        Ivo Kurzemnieks added a comment -

        Initial problem with changing item name, keys, units and description RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6348 r40739

        Show
        Ivo Kurzemnieks added a comment - Initial problem with changing item name, keys, units and description RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6348 r40739
        Hide
        Ivo Kurzemnieks added a comment - - edited

        (5) Problems in forms:

        • if template name has zeros and template visible name has different amount of zeros, upon opening template again in edit form, the zeros in visible name field are no longer visible. RESOLVED in r40746
        • same problem with 'visible name' in hosts form. RESOLVED in r40748
        • trigger with name "0" appears empty in edit form. RESOLVED in r40749
        • initial problem with saving zeros (when nothing is saved) in graphs form RESOLVED in r40752
        • initial problem with saving zeros in LLD rules RESOLVED in r40756
        • initial problem with saving zeros in item prototypes RESOLVED in r40757
        • initial problem with saving zeros in web scenarios, templated web scenarios and scenario step names RESOLVED in r40758
        • initial problem with saving zeros in slides and slide elements with "0" are displayed as empty RESOLVED in r40759
        • in scripts page when "Confirmation text" is zero (not many zeros), "Enable confirmation" checkbox is not checked RESOLVED in 40764

        If screen resource URL is 0, it says "No URL provided for screen element." Thechnically it's correct because simply entering 0 is not URL.

        Eduards Samersovs REOPEN

        • Undefined index is possible in CHostGroup.php:483
        • Undefined index is possible in configuration.slideconf.edit.php:60
        • CTemplate.php:460 - missing point at the end of the message
        • Please use strcmp() instead of === in DB.php and for situation where integers are possible

        Ivo Kurzemnieks RESOLVED in r40893
        Eduards Samersovs CLOSED, For my is OK, but maybe Pavels will have some comments

        Pavels Jelisejevs "0" is a valid URL.

        Ivo Kurzemnieks RESOLVED in r40926

        Pavels Jelisejevs CLOSED.

        Show
        Ivo Kurzemnieks added a comment - - edited (5) Problems in forms: if template name has zeros and template visible name has different amount of zeros, upon opening template again in edit form, the zeros in visible name field are no longer visible. RESOLVED in r40746 same problem with 'visible name' in hosts form. RESOLVED in r40748 trigger with name "0" appears empty in edit form. RESOLVED in r40749 initial problem with saving zeros (when nothing is saved) in graphs form RESOLVED in r40752 initial problem with saving zeros in LLD rules RESOLVED in r40756 initial problem with saving zeros in item prototypes RESOLVED in r40757 initial problem with saving zeros in web scenarios, templated web scenarios and scenario step names RESOLVED in r40758 initial problem with saving zeros in slides and slide elements with "0" are displayed as empty RESOLVED in r40759 in scripts page when "Confirmation text" is zero (not many zeros), "Enable confirmation" checkbox is not checked RESOLVED in 40764 If screen resource URL is 0, it says "No URL provided for screen element." Thechnically it's correct because simply entering 0 is not URL. Eduards Samersovs REOPEN Undefined index is possible in CHostGroup.php:483 Undefined index is possible in configuration.slideconf.edit.php:60 CTemplate.php:460 - missing point at the end of the message Please use strcmp() instead of === in DB.php and for situation where integers are possible Ivo Kurzemnieks RESOLVED in r40893 Eduards Samersovs CLOSED, For my is OK, but maybe Pavels will have some comments Pavels Jelisejevs "0" is a valid URL. Ivo Kurzemnieks RESOLVED in r40926 Pavels Jelisejevs CLOSED.
        Hide
        Pavels Jelisejevs added a comment - - edited

        (6) In CHostGroup.php:483

        if (!isset($group['name']) || (isset($group['name']) && zbx_empty($group['name']))) {
        

        can be simplified as

        if (!isset($group['name']) || zbx_empty($group['name'])) {
        

        The same in CHttpTest and CTemplate.

        Ivo Kurzemnieks RESOLVED in r40947

        Pavels Jelisejevs Minor change in 40976. CLOSED.

        Show
        Pavels Jelisejevs added a comment - - edited (6) In CHostGroup.php:483 if (!isset($group['name']) || (isset($group['name']) && zbx_empty($group['name']))) { can be simplified as if (!isset($group['name']) || zbx_empty($group['name'])) { The same in CHttpTest and CTemplate. Ivo Kurzemnieks RESOLVED in r40947 Pavels Jelisejevs Minor change in 40976. CLOSED.
        Hide
        Pavels Jelisejevs added a comment - - edited

        (7) I've made a minor improvement in r40923.

        Ivo Kurzemnieks REVIEWED.
        Thanks!
        CLOSED.

        Show
        Pavels Jelisejevs added a comment - - edited (7) I've made a minor improvement in r40923. Ivo Kurzemnieks REVIEWED. Thanks! CLOSED.
        Hide
        Pavels Jelisejevs added a comment - - edited

        (8) I suggest to remove the zbx_strcmp() function and cast the arguments to strings and use a strict comparison instead. It would also be nice use the CArrayHelper::unsetEqualValues() in places we discussed.

        Ivo Kurzemnieks RESOLVED in r40947

        Pavels Jelisejevs CLOSED.

        Show
        Pavels Jelisejevs added a comment - - edited (8) I suggest to remove the zbx_strcmp() function and cast the arguments to strings and use a strict comparison instead. It would also be nice use the CArrayHelper::unsetEqualValues() in places we discussed. Ivo Kurzemnieks RESOLVED in r40947 Pavels Jelisejevs CLOSED.
        Hide
        Pavels Jelisejevs added a comment - - edited

        (9) Another problem. Create a host named "0" and two triggers on it. Then add a dependency from one trigger to the other. You'll see an undefined index error:

        Undefined index: host [triggers.php:332 → CView->render() → include() in /opt/lampp/htdocs/zabbix/2.2/frontends/php/include/views/configuration.triggers.edit.php:282]
        

        Ivo Kurzemnieks RESOLVED in r40949

        Pavels Jelisejevs Please review my change in r40974. This check is unnecessary, since selectHosts will always return some result.

        Ivo Kurzemnieks REVIEWED.
        Ok, thanks!
        CLOSED.

        Show
        Pavels Jelisejevs added a comment - - edited (9) Another problem. Create a host named "0" and two triggers on it. Then add a dependency from one trigger to the other. You'll see an undefined index error: Undefined index: host [triggers.php:332 → CView->render() → include() in /opt/lampp/htdocs/zabbix/2.2/frontends/php/include/views/configuration.triggers.edit.php:282] Ivo Kurzemnieks RESOLVED in r40949 Pavels Jelisejevs Please review my change in r40974. This check is unnecessary, since selectHosts will always return some result. Ivo Kurzemnieks REVIEWED. Ok, thanks! CLOSED.
        Hide
        Pavels Jelisejevs added a comment - - edited

        TESTED.

        Please review (9) before merging.

        Show
        Pavels Jelisejevs added a comment - - edited TESTED. Please review (9) before merging.
        Hide
        Ivo Kurzemnieks added a comment -

        Fixed in pre-2.2.2rc1 r40979 and pre-2.3.0 (trunk) r40981

        Show
        Ivo Kurzemnieks added a comment - Fixed in pre-2.2.2rc1 r40979 and pre-2.3.0 (trunk) r40981

          People

          • Assignee:
            Ivo Kurzemnieks
            Reporter:
            Oleg Egorov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: