Details
-
Type:
Incident report
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.1.9
-
Component/s: Proxy (P), Server (S)
-
Labels:
Description
if proxy asks for config data from the server but there is no proxy with such name, previously we would log a message "Proxy host name might not be matching that on the server."
now it's :
979:20131105:160656.160 Received configuration data from server. Datalen 23
979:20131105:160656.160 failed to update local proxy configuration copy: Can't open JSON object or array ""failed"}"
even the first message here should not appear, it should only be logged when actual received data is ok
Activity
(1) It would be nice to send back the error description in info field and write it into logs.
Andris Mednis It was decided that sending the error description and writing it into receiver's log should be implemented for all types of data transfer between active proxy and server.
Andris Zeila CLOSED
(2) It was decided that the error description should use dynamically allocated memory instead of a fixed size 256-byte buffer.
Andris Mednis Available in svn://svn.zabbix.com/branches/dev/ZBX-7288 r40883.
Andris Mednis CLOSED
Reopening because requirements have changed.
Available in the development branch svn://svn.zabbix.com/branches/dev/ZBX-7288.
(3) Regarding zbx_recv_response_dyn(zbx_sock_t *sock, char **info, char **error, int timeout) function. I'm not sure about changing the name - usually _dyn is appended if we have already function working with static buffers with the same name.
But the error output parameter usually is the last one. I think it would be good to keep this pattern.
Andris Mednis RESOLVED in r40878.
Andris Zeila CLOSED
(4) Please review my changes in r40858
Andris Mednis Thanks! Reviewed and accepted. Minor improvements in r40873.
Andris Zeila CLOSED
(5) Warning messages should keep <variable>:<value> pattern instead of <variable>=<value>
Andris Mednis RESOLVED in r40883.
Andris Zeila CLOSED
Successfully tested
(6) Added an error message for active/passive proxy misconfiguration case in r40922.
Andris Zeila CLOSED
(7) get_proxy_id() changed to get_active_proxy_id() in r40952.
Andris Zeila CLOSED
Successfully tested
Fixed in versions pre-2.2.2 rev. 40975 and pre-2.3.0 rev. 40977.
(8) this was also listed by andris at https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew222#daemon_improvements -> CLOSED
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-7288 .