ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-7407

URL eventsource parameter has effect on existing action

    Details

      Description

      User can change action's eventsource by using URL parameter.

      For example:
      (1) open any trigger action
      (2) add into an URL &eventsource=1 and press Enter
      (3) save action

        Issue Links

          Activity

          Hide
          Ivo Kurzemnieks added a comment -

          RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7407

          Show
          Ivo Kurzemnieks added a comment - RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7407
          Hide
          Ivo Kurzemnieks added a comment - - edited

          (1) hidden field "form_refresh" repeats twice in form

          Ivo Kurzemnieks RESOLVED in r40459

          Pavels Jelisejevs CLOSED.

          Show
          Ivo Kurzemnieks added a comment - - edited (1) hidden field "form_refresh" repeats twice in form Ivo Kurzemnieks RESOLVED in r40459 Pavels Jelisejevs CLOSED.
          Hide
          Pavels Jelisejevs (Inactive) added a comment - - edited

          (2) I would suggest just ignoring the eventsource parameter for update forms. Otherwise, it makes the validation code more complicated. We do it for most of the parameters.

          Ivo Kurzemnieks RESOLVED in r40924

          Pavels Jelisejevs CLOSED.

          Show
          Pavels Jelisejevs (Inactive) added a comment - - edited (2) I would suggest just ignoring the eventsource parameter for update forms. Otherwise, it makes the validation code more complicated. We do it for most of the parameters. Ivo Kurzemnieks RESOLVED in r40924 Pavels Jelisejevs CLOSED.
          Hide
          Pavels Jelisejevs (Inactive) added a comment - - edited

          (3) A problem with cloning actions:

          1. Open a trigger action configuration form, press clone.
          2. Try to save the action, you'll see the "action already exists" error.
          3. Change the name of the action and save it again. You'll see the "Field "eventsource" must be missing." error.

          Ivo Kurzemnieks RESOLVED in r40924

          Pavels Jelisejevs CLOSED.

          Show
          Pavels Jelisejevs (Inactive) added a comment - - edited (3) A problem with cloning actions: 1. Open a trigger action configuration form, press clone. 2. Try to save the action, you'll see the "action already exists" error. 3. Change the name of the action and save it again. You'll see the "Field "eventsource" must be missing." error. Ivo Kurzemnieks RESOLVED in r40924 Pavels Jelisejevs CLOSED.
          Hide
          Pavels Jelisejevs (Inactive) added a comment - - edited

          (4) In actionconf.php:

          • please revert the formatting to the validation code.
          • don't modify the $_REQUEST variable.
          • the "eventsource" parameter is passed to the view file twice in the $data array: under the "eventsource" key and in the "action" array.

          Ivo Kurzemnieks RESOLVED in r40924

          Pavels Jelisejevs A minor formatting correction in r40939.

          Ivo Kurzemnieks REVIEWED.
          Thanks!
          CLOSED.

          Show
          Pavels Jelisejevs (Inactive) added a comment - - edited (4) In actionconf.php: please revert the formatting to the validation code. don't modify the $_REQUEST variable. the "eventsource" parameter is passed to the view file twice in the $data array: under the "eventsource" key and in the "action" array. Ivo Kurzemnieks RESOLVED in r40924 Pavels Jelisejevs A minor formatting correction in r40939. Ivo Kurzemnieks REVIEWED. Thanks! CLOSED.
          Hide
          Pavels Jelisejevs (Inactive) added a comment -

          TESTED.

          Please review (4) before merging.

          Show
          Pavels Jelisejevs (Inactive) added a comment - TESTED. Please review (4) before merging.
          Hide
          Ivo Kurzemnieks added a comment -

          Fixed in pre-2.2.2rc1 r40942 and pre-2.3.0 (trunk) r40943

          Show
          Ivo Kurzemnieks added a comment - Fixed in pre-2.2.2rc1 r40942 and pre-2.3.0 (trunk) r40943
          Hide
          Pavels Jelisejevs (Inactive) added a comment - - edited

          (5) I've updated the API docs, please review:

          Alexander Vladishev CLOSED

          Show
          Pavels Jelisejevs (Inactive) added a comment - - edited (5) I've updated the API docs, please review: https://www.zabbix.com/documentation/2.2/manual/api/reference/action/object - marked the "eventsource" property as constant https://www.zabbix.com/documentation/2.2/manual/api/reference_commentary#property_labels - described what "constant" actually means. Alexander Vladishev CLOSED

            People

            • Assignee:
              Unassigned
              Reporter:
              Alexander Vladishev
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: