process_active_checks() is too long and too dirty!

XMLWordPrintable

    • Type: Incident report
    • Resolution: Won't fix
    • Priority: Trivial
    • None
    • Affects Version/s: 1.8.18, 2.0.9, 2.2.0
    • Component/s: Agent (G)
    • None

      I think Zabbix source code is too dirty, because almost functions are too long! Especially, process_active_checks() in zabbix_agent/active.c. The function is over 600 lines.

      The attached patch is for 2.2.0. There is a bad coding. It is 'return -2', i.e. hard code.

        1. 0_active.c.clean_up.patch
          29 kB
        2. 1_active_metrics_register.patch
          13 kB

            Assignee:
            Unassigned
            Reporter:
            MATSUDA Daiki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: