Uploaded image for project: 'ZABBIX BUGS AND ISSUES'
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-7419

process_active_checks() is too long and too dirty!

XMLWordPrintable

    • Icon: Incident report Incident report
    • Resolution: Won't fix
    • Icon: Trivial Trivial
    • None
    • 1.8.18, 2.0.9, 2.2.0
    • Agent (G)
    • None

      I think Zabbix source code is too dirty, because almost functions are too long! Especially, process_active_checks() in zabbix_agent/active.c. The function is over 600 lines.

      The attached patch is for 2.2.0. There is a bad coding. It is 'return -2', i.e. hard code.

            Unassigned Unassigned
            daiki.matsuda@miraclelinux.com MATSUDA Daiki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: