(2) there's also "maintenance_type=0" - do we want to use a hardcoded zero here ?
(assuming that we even want to set this field at all here)
Juris Miščenko Corrected. RESOLVED.
Aleksandrs Saveljevs I looked at it once some time back and decided that 0 might not be that bad. While it technically coincides with the value of MAINTENANCE_TYPE_NORMAL, the value in this field does not matter when "maintenance_status" is set to HOST_MAINTENANCE_STATUS_OFF. Hence, 0 might be better for readability, depending on how one looks at things.
Juris Miščenko That reasoning isn't immediately clear. An expanding macro would simply remove the guess-work as to why it's hardcoded. Should/must this be noted somewhere, or is this such a minor detail that it doesn't matter?
<richlv> that's what my final remark was about - as it doesn't matter, why update it here at all ?
Andris Zeila it's nice to have them in a default state even if they aren't used. Another option might be to add a new define MAINTENANCE_TYPE_DEFAULT = MAINTENANCE_TYPE_NORMAL, but that's probably overkill.