ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-8243

changed error message for notsupported items not logged in server logfile

    Details

      Description

      if an item becomes unsupported, it is logged in server logfile and stored in item's error field.

      if the error message later changes, it is written in the item, but not in the logfile - this makes debugging much harder. if the error message changes, that should be written to the logfile, too

        Activity

        Hide
        Juris Miščenko (Inactive) added a comment -

        Fix implemented at svn://svn.zabbix.com/branches/dev/ZBX-8243

        Show
        Juris Miščenko (Inactive) added a comment - Fix implemented at svn://svn.zabbix.com/branches/dev/ZBX-8243
        Hide
        Andris Zeila added a comment - - edited

        (1) We should log not-escaped error value.

        Juris Miščenko Corrected. RESOLVED.

        Andris Zeila CLOSED

        Show
        Andris Zeila added a comment - - edited (1) We should log not-escaped error value. Juris Miščenko Corrected. RESOLVED. Andris Zeila CLOSED
        Hide
        Andris Zeila added a comment - - edited

        (2) While looking at error messages I noticed that the 'item xx became supported' message src/libs/zbxdbcache/dbcache.c:1083 is broken. Would be nice to fix it too.

        Juris Miščenko Log message adjusted. RESOLVED.

        Andris Zeila it's being already fixed in ZBX-7555. CLOSED

        Show
        Andris Zeila added a comment - - edited (2) While looking at error messages I noticed that the 'item xx became supported' message src/libs/zbxdbcache/dbcache.c:1083 is broken. Would be nice to fix it too. Juris Miščenko Log message adjusted. RESOLVED. Andris Zeila it's being already fixed in ZBX-7555 . CLOSED
        Hide
        Andris Zeila added a comment -

        Successfully tested, please check changes in r46010

        Show
        Andris Zeila added a comment - Successfully tested, please check changes in r46010
        Hide
        Juris Miščenko (Inactive) added a comment -

        Fix merged in 2.2.4rc1 r46026, 2.3.1 (trunk) r46029

        Show
        Juris Miščenko (Inactive) added a comment - Fix merged in 2.2.4rc1 r46026, 2.3.1 (trunk) r46029
        Hide
        Alexander Vladishev added a comment - - edited

        REOPENED

        (3) First error message is printed twice

         31909:20140620:160508.408 item "host:agent.ping[]" became not supported: Not supported by Zabbix Agent
         31909:20140620:160508.408 error reason for "host:agent.ping[]" changed: "Not supported by Zabbix Agent"
        

        Juris Miščenko RESOLVED.

        Andris Zeila CLOSED

        Show
        Alexander Vladishev added a comment - - edited REOPENED (3) First error message is printed twice 31909:20140620:160508.408 item "host:agent.ping[]" became not supported: Not supported by Zabbix Agent 31909:20140620:160508.408 error reason for "host:agent.ping[]" changed: "Not supported by Zabbix Agent" Juris Miščenko RESOLVED. Andris Zeila CLOSED
        Hide
        Alexander Vladishev added a comment - - edited

        (4) the message is incorrectly formatted

        • bad
          error reason for "host:agent.ping[]" changed: "Not supported by Zabbix Agent"
          
        • good
          error reason for "host:agent.ping[]" changed: Not supported by Zabbix Agent
          

        Juris Miščenko Message formating corrected. RESOLVED.

        <richlv> let's change that to "Zabbix agent" as per https://www.zabbix.org/wiki/Docs/specs/syntax#Syntax

        Andris Zeila

        src/zabbix_server/server.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Server. Zabbix %s (revision %s).",
        src/zabbix_server/server.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Server stopped. Zabbix %s (revision %s).",
        
        src/zabbix_proxy/proxy.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Proxy (%s) [%s]. Zabbix %s (revision %s).",
        src/zabbix_proxy/proxy.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Proxy stopped. Zabbix %s (revision %s).",
        
        src/libs/zbxwin32/service.c:			zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent shutdown requested");
        src/libs/zbxwin32/service.c:			zbx_error("\n\n\t!!!ATTENTION!!! Zabbix Agent started as a console application. !!!ATTENTION!!!\n");
        src/zabbix_agent/zabbix_agentd.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Agent [%s]. Zabbix %s (revision %s).",
        src/zabbix_agent/zabbix_agentd.c:	zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent stopped. Zabbix %s (revision %s).",
        src/zabbix_server/poller/checks_agent.c:			zbx_snprintf(buffer, sizeof(buffer), "Not supported by Zabbix Agent");
        src/zabbix_server/poller/checks_agent.c:			zbx_snprintf(buffer, sizeof(buffer), "Zabbix Agent non-critical error");
        src/zabbix_server/poller/checks_agent.c:			zbx_snprintf(buffer, sizeof(buffer), "Received empty response from Zabbix Agent at [%s]."
        
        include/version.h:#define APPLICATION_NAME	"Zabbix Agent"
        

        I think it would be better to create a new ZBX and change all occurrences of Zabbix <Application> at the same time. And I'm not sure if we should change application name in Windows.

        Andris Zeila it was decided to leave out the capitalization issues. The primary issue is fixed, so CLOSED

        Show
        Alexander Vladishev added a comment - - edited (4) the message is incorrectly formatted bad error reason for "host:agent.ping[]" changed: "Not supported by Zabbix Agent" good error reason for "host:agent.ping[]" changed: Not supported by Zabbix Agent Juris Miščenko Message formating corrected. RESOLVED. < richlv > let's change that to "Zabbix agent" as per https://www.zabbix.org/wiki/Docs/specs/syntax#Syntax Andris Zeila src/zabbix_server/server.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Server. Zabbix %s (revision %s).", src/zabbix_server/server.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Server stopped. Zabbix %s (revision %s).", src/zabbix_proxy/proxy.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Proxy (%s) [%s]. Zabbix %s (revision %s).", src/zabbix_proxy/proxy.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Proxy stopped. Zabbix %s (revision %s).", src/libs/zbxwin32/service.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent shutdown requested"); src/libs/zbxwin32/service.c: zbx_error("\n\n\t!!!ATTENTION!!! Zabbix Agent started as a console application. !!!ATTENTION!!!\n"); src/zabbix_agent/zabbix_agentd.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Agent [%s]. Zabbix %s (revision %s).", src/zabbix_agent/zabbix_agentd.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent stopped. Zabbix %s (revision %s).", src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Not supported by Zabbix Agent"); src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Zabbix Agent non-critical error"); src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Received empty response from Zabbix Agent at [%s]." include/version.h:#define APPLICATION_NAME "Zabbix Agent" I think it would be better to create a new ZBX and change all occurrences of Zabbix <Application> at the same time. And I'm not sure if we should change application name in Windows. Andris Zeila it was decided to leave out the capitalization issues. The primary issue is fixed, so CLOSED
        Hide
        Alexander Vladishev added a comment - - edited

        (5) the line is too long

        zabbix_log(LOG_LEVEL_WARNING, "error reason for \"%s:%s\" changed: \"%s\"", item->host.host, item->key_orig, h->value_orig.err);
        

        Juris Miščenko Line broken down to fit guideline length. RESOLVED.

        Andris Zeila CLOSED

        Show
        Alexander Vladishev added a comment - - edited (5) the line is too long zabbix_log(LOG_LEVEL_WARNING, "error reason for \" %s:%s\ " changed: \" %s\"", item->host.host, item->key_orig, h->value_orig.err); Juris Miščenko Line broken down to fit guideline length. RESOLVED. Andris Zeila CLOSED
        Hide
        Juris Miščenko (Inactive) added a comment -

        Fix implemented in svn://svn.zabbix.com/branches/dev/ZBX-8243

        Show
        Juris Miščenko (Inactive) added a comment - Fix implemented in svn://svn.zabbix.com/branches/dev/ZBX-8243
        Hide
        Andris Zeila added a comment - - edited

        (6) Fixed multiple unrelated formatting issues in r46955, please review

        Juris Miščenko Formating now looks proper. Thank you. RESOLVED. CLOSED.

        Show
        Andris Zeila added a comment - - edited (6) Fixed multiple unrelated formatting issues in r46955, please review Juris Miščenko Formating now looks proper. Thank you. RESOLVED. CLOSED.
        Hide
        Andris Zeila added a comment -

        Successfully tested

        Show
        Andris Zeila added a comment - Successfully tested
        Hide
        Juris Miščenko (Inactive) added a comment -

        Corrections merged in 2.2.5rc1 r46961, 2.3.1 (trunk) r46962

        Show
        Juris Miščenko (Inactive) added a comment - Corrections merged in 2.2.5rc1 r46961, 2.3.1 (trunk) r46962
        Hide
        richlv added a comment - - edited

        (7) as discussed on irc, whatsnew entry should go in 2.2.4 whatsnew
        Juris Miščenko Moved the entry to the proper whatsnew page. RESOLVED.

        <richlv> looks good to me, CLOSED

        Show
        richlv added a comment - - edited (7) as discussed on irc, whatsnew entry should go in 2.2.4 whatsnew Juris Miščenko Moved the entry to the proper whatsnew page. RESOLVED. < richlv > looks good to me, CLOSED

          People

          • Assignee:
            Unassigned
            Reporter:
            richlv
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: