ZABBIX BUGS AND ISSUES
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-8874

Incorrect focus field in LLD rule settings causes adding flexible interval in most browsers

    Details

      Description

      To reproduce the problem. Open existing LLD rule or create new LLD rule, put mouse cursor to item "Name" field and press Enter key.
      You will see how new flexible interval will be added with default/example options.

        Activity

        Hide
        Alexander Vladishev added a comment -

        Cannot reproduce with Firefox and Chrome (2.2.6 and pre-2.2.7 r49694).

        Please add more information how to reproduce the issue.

        Show
        Alexander Vladishev added a comment - Cannot reproduce with Firefox and Chrome (2.2.6 and pre-2.2.7 r49694). Please add more information how to reproduce the issue.
        Hide
        Pavels Jelisejevs (Inactive) added a comment -

        Tried IE11, works fine as well.

        Show
        Pavels Jelisejevs (Inactive) added a comment - Tried IE11, works fine as well.
        Hide
        Pavels Jelisejevs (Inactive) added a comment -

        The bug is reproducible in the LLD rule form.

        Show
        Pavels Jelisejevs (Inactive) added a comment - The bug is reproducible in the LLD rule form.
        Hide
        Krists Krigers (Inactive) added a comment -

        Fixed and committed in r49943, svn://svn.zabbix.com/branches/dev/ZBX-8874 (copy of branches/2.4).

        Show
        Krists Krigers (Inactive) added a comment - Fixed and committed in r49943, svn://svn.zabbix.com/branches/dev/ZBX-8874 (copy of branches/2.4).
        Hide
        Ivo Kurzemnieks added a comment - - edited

        (1) String changes?

        Krists Krigers No string changes. RESOLVED.

        Ivo Kurzemnieks CLOSED.

        Show
        Ivo Kurzemnieks added a comment - - edited (1) String changes? Krists Krigers No string changes. RESOLVED. Ivo Kurzemnieks CLOSED.
        Hide
        Ivo Kurzemnieks added a comment - - edited

        (2) Macros tab in Host and Template forms no longer work. Start typing beginning with {... and form submits

        Krists Krigers RESOLVED in r49961.

        Ivo Kurzemnieks CLOSED.

        Show
        Ivo Kurzemnieks added a comment - - edited (2) Macros tab in Host and Template forms no longer work. Start typing beginning with {... and form submits Krists Krigers RESOLVED in r49961. Ivo Kurzemnieks CLOSED.
        Hide
        Ivo Kurzemnieks added a comment - - edited

        (3) Host and Template forms: placing cursor in different fields, gives different results. Placing it in name field, will try to submit form and if no name is entered, it fails with error. It is OK. Placing it in interface field and not providing name, does submit form, but does not give error. If there is no subform, main form should be submitted.

        Krists Krigers Fixed the way how keypress handler is attached to inputs and selects. RESOLVED in r49963.

        Ivo Kurzemnieks

        • In LLD rule form, when cursor is in flexible interval, submits subform (Add), but In item/item prototype forms, when cursor is in flexible interval, submits main form.
        • In item form (and other simlilar places), when focus is in application select (it's a multiple select), form does not submit (FF only issue). Other selects work fine.
        • Pop-up submits form in its' own window and does not close. Other pop-ups like trigger expression and media, work fine.
          REOPENED.

        Krists Krigers Discussed witrh Pavels Jelisejevs and decided to leave FF and popup behavior as they are now. Fixed flexible intervals in LLD form. RESOLVED in r50047.

        Ivo Kurzemnieks Please, revert jquery.js file and as we discussed, for now we will not use subforms. So having cursor in flexible interval, we need to submit main form.
        REOPENED.

        Krists Krigers RESOLVED in r50060.

        Ivo Kurzemnieks Almost good. Just few more things:

        • in Latest Data the "main" button (Filter) is determined by order. Maybe it's better to add that 'main' class for it too;
        • init.js: 156 we can use $ instead of jQuery and there is an extra space after { bracket.
        • main.js the new code piece no longer processes subforms, and it's safe to remove the code;
        • maybe we can document on how the main class is created and how it's used. "How it works" section ok? I found at least 3 ways: with makeFormFooter() using first parameter, addClass('main') and useJQueryStyle('main').

        REOPENED.

        Krists Krigers See some documentation in https://documentation.zabbix.lan/internal/devel_howitworks/default_submit_button_in_forms.
        RESOLVED in r50083.

        Alexander Vladishev jquery.js was not fully restored

        $ md5sum ../../2.4/frontends/php/js/jquery/jquery.js
        df6173bad69801a82b84701789ab16c5  ../../2.4/frontends/php/js/jquery/jquery.js
        $ md5sum frontends/php/js/jquery/jquery.js
        628072e7212db1e8cdacb22b21752cda  frontends/php/js/jquery/jquery.js
        

        Ivo Kurzemnieks Thanks for documenting this. I restored jquery.js using diff. Some extra comment was added at the top of the file. See r50279. Also, as discussed, I made minor corrections to enterSubmit function. Please, review r50286

        Krists Krigers CLOSED.

        Show
        Ivo Kurzemnieks added a comment - - edited (3) Host and Template forms: placing cursor in different fields, gives different results. Placing it in name field, will try to submit form and if no name is entered, it fails with error. It is OK. Placing it in interface field and not providing name, does submit form, but does not give error. If there is no subform, main form should be submitted. Krists Krigers Fixed the way how keypress handler is attached to inputs and selects. RESOLVED in r49963. Ivo Kurzemnieks In LLD rule form, when cursor is in flexible interval, submits subform (Add), but In item/item prototype forms, when cursor is in flexible interval, submits main form. In item form (and other simlilar places), when focus is in application select (it's a multiple select), form does not submit (FF only issue). Other selects work fine. Pop-up submits form in its' own window and does not close. Other pop-ups like trigger expression and media, work fine. REOPENED. Krists Krigers Discussed witrh Pavels Jelisejevs and decided to leave FF and popup behavior as they are now. Fixed flexible intervals in LLD form. RESOLVED in r50047. Ivo Kurzemnieks Please, revert jquery.js file and as we discussed, for now we will not use subforms. So having cursor in flexible interval, we need to submit main form. REOPENED. Krists Krigers RESOLVED in r50060. Ivo Kurzemnieks Almost good. Just few more things: in Latest Data the "main" button (Filter) is determined by order. Maybe it's better to add that 'main' class for it too; init.js: 156 we can use $ instead of jQuery and there is an extra space after { bracket. main.js the new code piece no longer processes subforms, and it's safe to remove the code; maybe we can document on how the main class is created and how it's used. "How it works" section ok? I found at least 3 ways: with makeFormFooter() using first parameter, addClass('main') and useJQueryStyle('main'). REOPENED. Krists Krigers See some documentation in https://documentation.zabbix.lan/internal/devel_howitworks/default_submit_button_in_forms . RESOLVED in r50083. Alexander Vladishev jquery.js was not fully restored $ md5sum ../../2.4/frontends/php/js/jquery/jquery.js df6173bad69801a82b84701789ab16c5 ../../2.4/frontends/php/js/jquery/jquery.js $ md5sum frontends/php/js/jquery/jquery.js 628072e7212db1e8cdacb22b21752cda frontends/php/js/jquery/jquery.js Ivo Kurzemnieks Thanks for documenting this. I restored jquery.js using diff. Some extra comment was added at the top of the file. See r50279. Also, as discussed, I made minor corrections to enterSubmit function. Please, review r50286 Krists Krigers CLOSED.
        Hide
        Ivo Kurzemnieks added a comment -

        TESTED,
        but close (3) before merging.

        Show
        Ivo Kurzemnieks added a comment - TESTED, but close (3) before merging.
        Hide
        Krists Krigers (Inactive) added a comment - - edited

        (4) Added plugin initialization parameter validation in r50323. Please check.

        Ivo Kurzemnieks I made minor corrections to your code in r50379

        Krists Krigers Looks good. CLOSED.

        Show
        Krists Krigers (Inactive) added a comment - - edited (4) Added plugin initialization parameter validation in r50323. Please check. Ivo Kurzemnieks I made minor corrections to your code in r50379 Krists Krigers Looks good. CLOSED.
        Hide
        Krists Krigers (Inactive) added a comment -

        Fixed and merged to

        • 2.4.3rc1 in r50449,
        • 2.5.0 (trunk) in r50450.
        Show
        Krists Krigers (Inactive) added a comment - Fixed and merged to 2.4.3rc1 in r50449, 2.5.0 (trunk) in r50450.
        Hide
        Alexander Vladishev added a comment - - edited

        (5) Submit occurs when pressing Enter key on focused button (for example [Clone], [Cancel], [Reset] ...).

        REOPENED

        Ivo Kurzemnieks Branch to this solution deleted. See (8).
        CLOSED.

        Show
        Alexander Vladishev added a comment - - edited (5) Submit occurs when pressing Enter key on focused button (for example [Clone] , [Cancel] , [Reset] ...). REOPENED Ivo Kurzemnieks Branch to this solution deleted. See (8). CLOSED.
        Hide
        Krists Krigers (Inactive) added a comment -

        Fixed in r50499, new branch svn://svn.zabbix.com/branches/dev/ZBX-8874 (copy of branches/2.4). RESOLVED.

        Show
        Krists Krigers (Inactive) added a comment - Fixed in r50499, new branch svn://svn.zabbix.com/branches/dev/ZBX-8874 (copy of branches/2.4). RESOLVED.
        Hide
        Alexei Vladishev added a comment - - edited

        (6) Configuration->Actions, new condition "Trigger name= like ". Press Enter key in the trigger name input, the form will be submitted. It should create a new condition before as it worked before.

        Krists Krigers RESOLVED in r50701.

        Ivo Kurzemnieks Branch to this solution deleted. See (8).
        CLOSED.

        Show
        Alexei Vladishev added a comment - - edited (6) Configuration->Actions, new condition "Trigger name= like ". Press Enter key in the trigger name input, the form will be submitted. It should create a new condition before as it worked before. Krists Krigers RESOLVED in r50701. Ivo Kurzemnieks Branch to this solution deleted. See (8). CLOSED.
        Hide
        Alexander Vladishev added a comment - - edited

        (7) Broken Autofill browser functionality. I cannot select data with Enter from Autofill data.

        Krists Krigers RESOLVED in r50701.

        Ivo Kurzemnieks Branch to this solution deleted. See (8).
        CLOSED.

        Show
        Alexander Vladishev added a comment - - edited (7) Broken Autofill browser functionality. I cannot select data with Enter from Autofill data. Krists Krigers RESOLVED in r50701. Ivo Kurzemnieks Branch to this solution deleted. See (8). CLOSED.
        Hide
        Alexander Vladishev added a comment -

        Undoing changes in r50646 (branches/2.4) and r50647 (trunk).

        Show
        Alexander Vladishev added a comment - Undoing changes in r50646 (branches/2.4) and r50647 (trunk).
        Hide
        Krists Krigers (Inactive) added a comment -

        Fixed in r50701, branch svn://svn.zabbix.com/branches/dev/ZBX-8874.

        Show
        Krists Krigers (Inactive) added a comment - Fixed in r50701, branch svn://svn.zabbix.com/branches/dev/ZBX-8874.
        Hide
        Ivo Kurzemnieks added a comment - - edited

        (8) Provided different solution to fix the original problem in svn://svn.zabbix.com/branches/dev/ZBX-8874 r51396

        Alexander Vladishev Thanks! CLOSED

        Show
        Ivo Kurzemnieks added a comment - - edited (8) Provided different solution to fix the original problem in svn://svn.zabbix.com/branches/dev/ZBX-8874 r51396 Alexander Vladishev Thanks! CLOSED
        Hide
        Ivo Kurzemnieks added a comment - - edited

        Fixed in pre-2.4.4rc1 r51402 and pre-2.5.0 (trunk) r51403

        Show
        Ivo Kurzemnieks added a comment - - edited Fixed in pre-2.4.4rc1 r51402 and pre-2.5.0 (trunk) r51403

          People

          • Assignee:
            Unassigned
            Reporter:
            Alexey Pustovalov
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: