Details

      Description

      there are some differences between the item key helper and list of the keys in the manual

      Manual PHP helper
      log[file,<regexp>,<encoding>,<maxlines>,<mode>,<output>] log[file,<pattern>,<encoding>,<maxlines>,<mode>,<output>]
      logrt[file_pattern,<regexp>,<encoding>,<maxlines>,<mode>,<output>] logrt[file_format,<pattern>,<encoding>,<maxlines>,<mode>,<output>]
      service_state[*] service_state[service]
      system.cpu.num[<type>] system.cpu.num
      system.localtime[<type>] system.localtime
      system.swap.in[<device>,<type>] system.swap.in[<swap>,<type>]
      system.swap.out[<device>,<type>] system.swap.out[<swap>,<type>]
      system.swap.size[<device>,<type>] system.swap.size[<swap>,<mode>]
      vfs.dev.read[<device>,<type>,<mode>] vfs.dev.read[device,<type>,<mode>]
      vfs.dev.write[<device>,<type>,<mode>] vfs.dev.write[device,<type>,<mode>]
      web.page.regexp[host,<path>,<port>,<regexp>,<length>,<output>] web.page.regexp[host,<path>,<port>,<regexp>,<length>] (passive items only)
      • ordering of net.dns.record and net.dns
      • ordering of net.tcp.service.perf and net.tcp.service

        Activity

        Hide
        richlv added a comment -

        note that description texts SHOULD NOT BE CHANGED at this time, even when they miss some detail - all of them should be reviewed and updated at once to reduce the amount of work translators have to do

        Show
        richlv added a comment - note that description texts SHOULD NOT BE CHANGED at this time, even when they miss some detail - all of them should be reviewed and updated at once to reduce the amount of work translators have to do
        Hide
        richlv added a comment - - edited

        decisions to be made (updated after discussing with maartinjsh) :

        • log/logrt items - regexp or pattern ? -> regexp
        • logrt - probably file_pattern instead of file_format. maybe even file_regexp ? -> file_regexp
        • ordering - shorter or longer key first ? (probably shortest) -> shortest
        • swap items - device or swap ? swap could be on a file... -> but even swap file sometimes is said to be swap device -> device
        • system.swap.size is the only swap item to use "mode" instead of "type", and that is also different from the manual. seems to be a simple mistake -> should be changed to "type"
        • eventlog - name or logtype ? -> name
        Show
        richlv added a comment - - edited decisions to be made (updated after discussing with maartinjsh) : log/logrt items - regexp or pattern ? -> regexp logrt - probably file_pattern instead of file_format. maybe even file_regexp ? -> file_regexp ordering - shorter or longer key first ? (probably shortest) -> shortest swap items - device or swap ? swap could be on a file... -> but even swap file sometimes is said to be swap device -> device system.swap.size is the only swap item to use "mode" instead of "type", and that is also different from the manual. seems to be a simple mistake -> should be changed to "type" eventlog - name or logtype ? -> name
        Hide
        richlv added a comment -

        zabbix 1.8 is not supported anymore, so this should be fixed in 2.0 and up (primarily because system.localtime is missing the param completely)

        Show
        richlv added a comment - zabbix 1.8 is not supported anymore, so this should be fixed in 2.0 and up (primarily because system.localtime is missing the param completely)
        Hide
        richlv added a comment - - edited
        • fixed for 2.0 in svn://svn.zabbix.com/branches/dev/ZBX-9168; to minimise changes in this branch, only incorrect item keys were changed
        • fixed for 2.2 in svn://svn.zabbix.com/branches/dev/ZBX-9168-2.2
        Show
        richlv added a comment - - edited fixed for 2.0 in svn://svn.zabbix.com/branches/dev/ZBX-9168; to minimise changes in this branch, only incorrect item keys were changed fixed for 2.2 in svn://svn.zabbix.com/branches/dev/ZBX-9168-2.2
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (1) In 2.0 branch, some agent keys are missing in the item helper:

        • agent.hostname
        • net.udp.listen[port]
        • sensor[device,sensor,<mode>]
        • services[<type>,<state>,<exclude>]

        Aleksandrs Saveljevs Not sure what "incorrect item keys" means. Therefore, listing differences that are still present between 2.0 manual at https://www.zabbix.com/documentation/2.0/manual/config/items/itemtypes/zabbix_agent and https://www.zabbix.com/documentation/2.0/manual/config/items/itemtypes/zabbix_agent/win_keys, and item helper:

        Manual PHP helper
        log[file,<regexp>,<encoding>,<maxlines>,<mode>] log[file,<pattern>,<encoding>,<maxlines>,<mode>]
        logrt[file_regexp,<regexp>,<encoding>,<maxlines>,<mode>] logrt[file_format,<pattern>,<encoding>,<maxlines>,<mode>]
        system.swap.in[<device>,<type>] system.swap.in[<swap>,<type>]
        system.swap.out[<device>,<type>] system.swap.out[<swap>,<type>]
        system.swap.size[<device>,<type>] system.swap.size[<swap>,<mode>]
        eventlog[name,<regexp>,<severity>,<source>,<eventid>,<maxlines>,<mode>] eventlog[logtype,<pattern>,<severity>,<source>,<eventid>,<maxlines>,<mode>]
        service_state[*] service_state[service]

        <richlv> missing item keys added in r51550; only "description" column from the manual was used to keep things simpler for 2.0.

        "incorrect item keys" was meant to be keys that don't just use a different word to refer to a specific parameter (like "regexp" vs "pattern"), but keys that omitted the fact that item key had any parameters at all, for example.

        from the above list, all of the differences seem to be in how item key parameters are denoted/named - to keep the number of changes to 2.0 low, it is proposed not to modify key parameters for this branch.

        RESOLVED

        Aleksandrs Saveljevs CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (1) In 2.0 branch, some agent keys are missing in the item helper: agent.hostname net.udp.listen[port] sensor[device,sensor,<mode>] services[<type>,<state>,<exclude>] Aleksandrs Saveljevs Not sure what "incorrect item keys" means. Therefore, listing differences that are still present between 2.0 manual at https://www.zabbix.com/documentation/2.0/manual/config/items/itemtypes/zabbix_agent and https://www.zabbix.com/documentation/2.0/manual/config/items/itemtypes/zabbix_agent/win_keys , and item helper: Manual PHP helper log[file,<regexp>,<encoding>,<maxlines>,<mode>] log[file,<pattern>,<encoding>,<maxlines>,<mode>] logrt[file_regexp,<regexp>,<encoding>,<maxlines>,<mode>] logrt[file_format,<pattern>,<encoding>,<maxlines>,<mode>] system.swap.in[<device>,<type>] system.swap.in[<swap>,<type>] system.swap.out[<device>,<type>] system.swap.out[<swap>,<type>] system.swap.size[<device>,<type>] system.swap.size[<swap>,<mode>] eventlog[name,<regexp>,<severity>,<source>,<eventid>,<maxlines>,<mode>] eventlog[logtype,<pattern>,<severity>,<source>,<eventid>,<maxlines>,<mode>] service_state[*] service_state[service] < richlv > missing item keys added in r51550; only "description" column from the manual was used to keep things simpler for 2.0. "incorrect item keys" was meant to be keys that don't just use a different word to refer to a specific parameter (like "regexp" vs "pattern"), but keys that omitted the fact that item key had any parameters at all, for example. from the above list, all of the differences seem to be in how item key parameters are denoted/named - to keep the number of changes to 2.0 low, it is proposed not to modify key parameters for this branch. RESOLVED Aleksandrs Saveljevs CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (2) Some lines in the 2.0 diff go like this:

        -ROW   |7       |system.cpu.num ...
        +ROW   |7       |system.cpu.num[<type>] ...
        

        HTML entities should probably be used instead of raw angle brackets:

        +ROW   |7       |system.cpu.num[&lt;type&gt;] ...
        

        <richlv> ouch, sorry about that. should be fixed in r51549.
        RESOLVED

        Aleksandrs Saveljevs CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (2) Some lines in the 2.0 diff go like this: -ROW |7 |system.cpu.num ... +ROW |7 |system.cpu.num[<type>] ... HTML entities should probably be used instead of raw angle brackets: +ROW |7 |system.cpu.num[&lt;type&gt;] ... < richlv > ouch, sorry about that. should be fixed in r51549. RESOLVED Aleksandrs Saveljevs CLOSED
        Hide
        richlv added a comment - - edited

        (3) in 2.2 branch, the following keys are missing :

        • sensor[device,sensor,<mode>]
        • services[<type>,<state>,<exclude>]

        adding these would also add translatable strings, thus it is proposed to postpone this until all item descriptions are unified in item pages (ZBX-8811)

        Aleksandrs Saveljevs Fixing description for items like "system.swap.size[device,type]", where description still refers to the old "swap" and "mode", will have to be postponed until ZBX-8811, too, it seems. CLOSED.

        Show
        richlv added a comment - - edited (3) in 2.2 branch, the following keys are missing : sensor [device,sensor,<mode>] services [<type>,<state>,<exclude>] adding these would also add translatable strings, thus it is proposed to postpone this until all item descriptions are unified in item pages ( ZBX-8811 ) Aleksandrs Saveljevs Fixing description for items like "system.swap.size [device,type] ", where description still refers to the old "swap" and "mode", will have to be postponed until ZBX-8811 , too, it seems. CLOSED.
        Show
        richlv added a comment - - edited (4) asterisk (*) was changed to "service" in service_state key parameters in : https://www.zabbix.com/documentation/1.8/manual/config/items https://www.zabbix.com/documentation/2.0/manual/config/items/itemtypes/zabbix_agent/win_keys https://www.zabbix.com/documentation/2.2/manual/config/items/itemtypes/zabbix_agent/win_keys https://www.zabbix.com/documentation/2.4/manual/config/items/itemtypes/zabbix_agent/win_keys https://www.zabbix.com/documentation/3.0/manual/config/items/itemtypes/zabbix_agent/win_keys RESOLVED Aleksandrs Saveljevs CLOSED
        Hide
        richlv added a comment - - edited

        merged to 2.0 in r51594, 2.2 in r51599, 2.4 in r51600, trunk in r51604.

        Show
        richlv added a comment - - edited merged to 2.0 in r51594, 2.2 in r51599, 2.4 in r51600, trunk in r51604.
        Hide
        richlv added a comment - - edited

        (5) no translation changes

        Aleksandrs Saveljevs Until r51604, everything is good, but see (7). CLOSED.

        <richlv> it was decided not to change anything in (7), still no changed strings, remains CLOSED

        Show
        richlv added a comment - - edited (5) no translation changes Aleksandrs Saveljevs Until r51604, everything is good, but see (7). CLOSED. < richlv > it was decided not to change anything in (7), still no changed strings, remains CLOSED
        Hide
        richlv added a comment - - edited

        (6) conflicts were resolved when merging to 2.4 (net.tcp.service and net.tcp.service.perf keys) and trunk (net.dns and net.dns.record keys) - a quick check on that would be appreciated

        Aleksandrs Saveljevs CLOSED

        Show
        richlv added a comment - - edited (6) conflicts were resolved when merging to 2.4 (net.tcp.service and net.tcp.service.perf keys) and trunk (net.dns and net.dns.record keys) - a quick check on that would be appreciated Aleksandrs Saveljevs CLOSED
        Hide
        Aleksandrs Saveljevs added a comment - - edited

        (7) In 2.2 and above, descriptions of passive and active versions of net.tcp.service[] differ. Unifying them would remove one translatable string.

        <richlv> it was discovered that actually the difference is between agent & simple check descriptions, and those indeed are slightly different -> nothing to change, CLOSED

        Show
        Aleksandrs Saveljevs added a comment - - edited (7) In 2.2 and above, descriptions of passive and active versions of net.tcp.service[] differ. Unifying them would remove one translatable string. < richlv > it was discovered that actually the difference is between agent & simple check descriptions, and those indeed are slightly different -> nothing to change, CLOSED

          People

          • Assignee:
            Unassigned
            Reporter:
            richlv
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: