Uploaded image for project: 'ZABBIX BUGS AND ISSUES'
  1. ZABBIX BUGS AND ISSUES
  2. ZBX-9344

Zabbix server/proxy poller may hang on Telnet check when password is not required

    Details

      Description

      In the source code, file src/libs/zbxcomms/telnet.c:

      int     telnet_login(ZBX_SOCKET socket_fd, const char *username, const char *password, AGENT_RESULT *result)
      {
              const char      *__function_name = "telnet_login";
      [...]
              while (ZBX_TCP_ERROR != (rc == telnet_read(socket_fd, buf, &sz, &offset)))
              {
                      if (':' == telnet_lastchar(buf, offset))
                              break;
              }
      

      Instead of comparison operator

      ZBX_TCP_ERROR != (rc == telnet_read

      there should be an assignment operator

      ZBX_TCP_ERROR != (rc = telnet_read.

      This may cause endless loop if telnet server would not request password.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dimir dimir
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: