Uploaded image for project: 'ZABBIX FEATURE REQUESTS'
  1. ZABBIX FEATURE REQUESTS
  2. ZBXNEXT-3170

Add IP address support in net.if.discovery

XMLWordPrintable

      net.if.discovery lacks support of reporting IP addresses for discovered interfaces. Check attached patch. It reports only ipv4 addresses and only on Linux hosts.

        1. net.c.diff
          4 kB
          Alexander Afonyashin

          [ZBXNEXT-3170] Add IP address support in net.if.discovery

          Alexander Afonyashin added a comment -

          Patch needs to be improved to add IFADDR6 address reporting. It also skips interfaces without ipv4 addresses.

          Alexander Afonyashin added a comment - Patch needs to be improved to add IFADDR6 address reporting. It also skips interfaces without ipv4 addresses.

          Alexander Afonyashin added a comment -

          Improved version with ipv4/ipv6/noaddr interface support.

          Alexander Afonyashin added a comment - Improved version with ipv4/ipv6/noaddr interface support.

          Alexander Afonyashin added a comment - - edited

          $ zabbix_agentd -t net.if.discovery

          net.if.discovery                              [s|{"data":[{"{#IFNAME}":"lo","{#IFADDR}":"127.0.0.1","{#IFADDR6}":"::1"},{"{#IFNAME}":"eth0","{#IFADDR}":"X.X.X.X","{#IFADDR6}":"fe80::224:21ff:feXX:XXXX%eth0"},{"{#IFNAME}":"br0","{#IFADDR6}":"fe80::14b6:61ff:feXX:XXXX%br0"}]}]

          Alexander Afonyashin added a comment - - edited $ zabbix_agentd -t net.if.discovery net. if .discovery [s|{ "data" :[{ "{#IFNAME}" : "lo" , "{#IFADDR}" : "127.0.0.1" , "{#IFADDR6}" : "::1" },{ "{#IFNAME}" : "eth0" , "{#IFADDR}" : "X.X.X.X" , "{#IFADDR6}" : "fe80::224:21ff:feXX:XXXX%eth0" },{ "{#IFNAME}" : "br0" , "{#IFADDR6}" : "fe80::14b6:61ff:feXX:XXXX%br0" }]}]

          Andrey Melnikov added a comment -

          real ipv6 config always carry 2 addresses - fe80::xxxx and configured. Which address agent should return? First, second, both?

          Andrey Melnikov added a comment - real ipv6 config always carry 2 addresses - fe80::xxxx and configured. Which address agent should return? First, second, both?

          Oleksii Zagorskyi added a comment -

          The example does't contain {#IFADDR} macro for br0 interface.
          It's not very good to include exclude macros. More correctly would be include it but with empty value.
          I'm not sure here, but such approach may cause some problems like described in ZBXNEXT-3139

          Oleksii Zagorskyi added a comment - The example does't contain {#IFADDR} macro for br0 interface. It's not very good to include exclude macros. More correctly would be include it but with empty value. I'm not sure here, but such approach may cause some problems like described in ZBXNEXT-3139

          Oleksii Zagorskyi added a comment -

          In duplicated ZBXNEXT-2926 is a concern what to do for interfaces which have multiple IP addresses.

          Oleksii Zagorskyi added a comment - In duplicated ZBXNEXT-2926 is a concern what to do for interfaces which have multiple IP addresses.

          Glebs Ivanovskis (Inactive) added a comment -

          First of all, please have a look at Zabbix coding guidelines.

          Your patch relies heavily on ifaddrs.h. Is it present on all platforms Zabbix supports?

          I would suggest converting this patch into a loadable module. It will be easier for people to deploy and use it (no need to apply the patch and recompile Zabbix from sources with every upgrade) and it will be great for gathering more feedback faster.

          Glebs Ivanovskis (Inactive) added a comment - First of all, please have a look at Zabbix coding guidelines . Your patch relies heavily on ifaddrs.h. Is it present on all platforms Zabbix supports? I would suggest converting this patch into a loadable module . It will be easier for people to deploy and use it (no need to apply the patch and recompile Zabbix from sources with every upgrade) and it will be great for gathering more feedback faster.

            Unassigned Unassigned
            firm Alexander Afonyashin
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: