[ZBX-11038] Incomplete source tarball; pre-built source-less minified CSS files Created: 2016 Jul 27  Updated: 2017 May 30  Resolved: 2016 Oct 18

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Installation (I)
Affects Version/s: 3.0.4
Fix Version/s: 3.0.6rc1, 3.2.2rc1, 3.4.0alpha1

Type: Incident report Priority: Major
Reporter: Dmitry Smirnov Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: DFSG
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Source tarball is missing `sass` folder which makes it impossible to re-build some generated files.

Moreover 3.0.4 source tarball contains source-less minified `frontends/php/styles/*-theme.css` files.

Effectively minified code is equivalent of pre-compiled binary – un-readable, non-modifiable and non-distributable in Debian.

Please do not minify CSS files for source releases.
Please replace all minified files with their original (non-minified) sources (as it was in 3.0.3 and prior releases).

Read more in https://wiki.debian.org/onlyjob/no-minification

Also please ship all sources in source tarball, including `sass` folder.

Thanks.

 Comments   
Comment by Volker Fröhlich [ 2016 Jul 27 ]

I think having them alongside should be good enough.

Comment by Dmitry Smirnov [ 2016 Jul 27 ]

Absolutely. If "sass" folder were present in source tarball then one could re-build CSS files from source. That would be sufficient. Thanks.

Comment by Dmitry Smirnov [ 2016 Oct 07 ]

Please, pretty please let's fix this problem ASAP.
3.0.5 is affected and we are at risk of dropping Zabbix from official Debian repositories due to this issue. Thanks.

Comment by Alexander Vladishev [ 2016 Oct 10 ]

It will be fixed ASAP in versions 3.0.6 and 3.2.2. Thank you!

Comment by Alexander Vladishev [ 2016 Oct 10 ]

onlyjob, by the way, how much time do we have?

Comment by Aleksandrs Saveljevs [ 2016 Oct 11 ]

Note that CSS compression was added in ZBX-10504.

Comment by Aleksandrs Saveljevs [ 2016 Oct 11 ]

Minification removed and "sass" folder added to distribution in development branch svn://svn.zabbix.com/branches/dev/ZBX-11038 .

Comment by Dmitry Smirnov [ 2016 Oct 11 ]

Thank you. We should be fine if those changes will be incorporated into 3.0.6.

Comment by Aleksandrs Saveljevs [ 2016 Oct 17 ]

Fixed in pre-3.0.6rc1 r63205, pre-3.2.2rc1 r63206, and pre-3.3.0 (trunk) r63207.

Generated at Fri Apr 26 16:46:14 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.