[ZBX-1294] new trigger editor "allows" to edit templated triggers Created: 2009 Nov 17  Updated: 2017 May 30  Resolved: 2010 Dec 23

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.9.0 (alpha)
Fix Version/s: 1.8.4

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

rev 8318


Issue Links:
Duplicate
is duplicated by ZBX-3272 disable add button when editing templ... Closed

 Description   

new trigger expression editor sort of allows editing templated trigger expression, although it is not saved (and glitches when used).
expression editor should be completely disabled for templated expressions (it should still show expression, but not allow any editing)



 Comments   
Comment by richlv [ 2009 Nov 17 ]

correction. it actually does allow to edit templated trigger expressions, it's just that single expression is replaced, discarding the rest, and this change is saved

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 09 ]

Fixed in dev branch: ZBX-1294
Button "Add" disabled for templated triggers

Comment by Aleksandrs Saveljevs [ 2010 Dec 09 ]

(1) "Toggle input method" should also be disabled.

(2) This is a different issue, but probably minor enough to be fixed here: if we toggle the input method and click on the expression two times, a popup appears that says "Do you replace the conditional expression?". Probably it is lacking the words "wish to"?

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 10 ]

(1) "Toggle input method" is not present now for templated triggers
(2) String fixed

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 10 ]
  • ZBX-1294 disabled "Add" and "Toggle input method" for templated trigger expressions (KB)
    [merged: branches/1.8 r15986]
Comment by Oleksii Zagorskyi [ 2010 Dec 11 ]

In trunk rev 15989 is lost "Select prototype" button in 'popup_trexpr.php'
Need to fix (return the button).

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 13 ]

Oleksiy, thank you, fixed it.

Comment by richlv [ 2010 Dec 13 ]

hmm. i don't like disabling of "Toggle input method" for templated trigger expressions.

first, it removes the capability to see trigger in a visual way on the host level;
second, it removes the capability to test triggers with usermacros on the host level etc

it would be much better to disable individual controls in that editing mode.

(although this can also be added as a separate issue)

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 13 ]

Ok, then we are:

  • disabling buttons "Edit", "Insert macro", "And", "Or", "Replace"
  • removing "Delete" column
  • trigger link becomes inactive

Recreating development branch ZBX-1294

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 14 ]

Changes are made in branch ZBX-1294

Comment by richlv [ 2010 Dec 14 ]

confirming the fix in dev branch rev 16072. leaving as is for code review

Comment by Konstantin Buravcov (Inactive) [ 2010 Dec 23 ]

merged from branches/1.8 r16389

Generated at Fri Apr 26 23:22:43 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.