[ZBX-15593] Zabbix DB upgrade script fails, but DB upgrade continues Created: 2019 Feb 05  Updated: 2024 Apr 10  Resolved: 2019 Feb 09

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: 4.0.5rc1, 4.2.0beta1, 4.2 (plan)

Type: Problem report Priority: Trivial
Reporter: Kaspars Mednis Assignee: Vladislavs Sokurenko
Resolution: Fixed Votes: 0
Labels: dbpatches, upgrade
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Team: Team A
Sprint: Sprint 49 (Feb 2019)
Story Points: 0.125

 Description   

When upgrading Zabbix DB, i get multiple commit errors on update queries, but upgrade continues

Expected behavior - upgrade fails on such error, not just skips the table and continues. The upgrade finished with inconsistent table values and was fixed manually, but non experienced user will think everything went as expected.

 29973:20190110:120822.898 completed 22% of database upgrade
 29973:20190110:121135.923 slow query: 193.025398 sec, "alter table items drop column data_type"
 29973:20190110:121434.187 slow query: 178.262397 sec, "alter table items drop column delta"
 29973:20190110:121707.029 slow query: 152.840107 sec, "update items set formula='' where flags<>1 or evaltype<>3"
 29973:20190110:122055.309 [Z3005] query failed: [1180] Got error 5 during COMMIT [commit;]
 29973:20190110:122055.309 slow query: 228.279343 sec, "commit;"
 29973:20190110:122055.704 completed 23% of database upgrade
 29973:20190110:122754.976 slow query: 419.256325 sec, "alter table `alerts` add `p_eventid` bigint unsigned"
 29973:20190110:123240.690 slow query: 285.713095 sec, "alter table `alerts` add constraint c_alerts_5 foreign key (`p_eventid`) references `events` (`eventid`) on delete cascade"
 29973:20190110:123240.692 completed 24% of database upgrade
update items set delay='2m' where itemid=56247495;
"
 29973:20190110:130941.894 [Z3005] query failed: [1180] Got error 5 during COMMIT [commit;]
 29973:20190110:130941.894 slow query: 184.029411 sec, "commit;"
 29973:20190110:153231.496 completed 99% of database upgrade
 29973:20190110:153231.532 completed 100% of database upgrade
 29973:20190110:153231.532 database upgrade fully completed


 Comments   
Comment by Vladislavs Sokurenko [ 2019 Feb 05 ]

Which MySQL version is it ?

Comment by Kaspars Mednis [ 2019 Feb 05 ]

MariaDB 5.5

Comment by Kaspars Mednis [ 2019 Feb 06 ]

Error on MySQL side, which caused this error:

190111 13:43:23 [Warning] WSREP: transaction size limit (1073741824) exceeded: 1077936128
190111 13:43:24 [ERROR] WSREP: rbr write fail, data_len: 0, 2
Comment by Vladislavs Sokurenko [ 2019 Feb 08 ]

Fixed in development branch:
svn://svn.zabbix.com/branches/dev/ZBX-15593

fixed database upgrade patch to stop upgrade on commit failure

Comment by Vladislavs Sokurenko [ 2019 Feb 08 ]

Fixed in:

  • pre-4.0.5rc1 r89630
  • pre-4.2.0alpha4 (trunk) r89631
Generated at Fri Apr 26 17:58:59 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.