[ZBX-1902] can't create trigger dependency if template is linked against another template Created: 2010 Feb 01  Updated: 2017 May 30  Resolved: 2010 Apr 27

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.1, 1.9.0 (alpha)
Fix Version/s: 1.8.2

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

have two templates, link one to another. in the upstream template, have two triggers.
try to make one of the triggers depend on the other :
"<template name> is not the highest level template"

it actually is.



 Comments   
Comment by svenw [ 2010 Feb 17 ]

i disabled the check completely, and hope i did not break something else. ofcourse i need to make sure manually to only depend highest level triggers...

      • /tmp/triggers.inc.php.orig 2010-02-17 14:31:30.000000000 +0100
      • include/triggers.inc.php 2010-02-17 14:11:47.000000000 +0100
        ***************
      • 1940,1945 ****
      • 1940,1946 ----
        // Deny adding dependency between templates ifthey are not high level templates
        function validate_trigger_dependency($expression, $deps) {
        $result = true;
        + return $result;
        if(!empty($deps)){
        $templates = array();
        $templateids = array();
Comment by richlv [ 2010 Feb 22 ]

confirming the fix in dev branch rev 10349.

Comment by Alexey Fukalov [ 2010 Feb 23 ]

branches/1.8 1350

Comment by Nicolas Van Eenaeme [ 2010 Apr 15 ]

I'm hitting a similar error with zabbix 1.8.2.

Here's my situation:

I have 4 templates: Template_System_Essentials, Template_Mysql_Server, Template_Mysql_Server_50 and Template_Mysql_Server_51. The templates Template_Mysql_Server_50 and Template_Mysql_Server_51 are linked to Template_Mysql_Server.

Every host has Template_System_Essentials but no templates are linked to it.

When I want to update a trigger in Template_Mysql_Server and add a dependency on a trigger in Template_System_Essentials, I get the error of "Template_Mysql_Server is not the highest level template".

So the bug still exists or I'm doing something completely wrong.

Comment by richlv [ 2010 Apr 15 ]

two bugs have been found.

1. link templates t1 and t2 to template t3. try to create dependency from t1 to t2 - this fails. should work.

2. link template t1 to host h1. create a dependency from t1 to another template (not linked to h1) - this succeeds. should not.

as for the last comment, i believe issue is caused by attempting to depend to a template that is not available to lower level templates, thus they don't have any trigger to depends on => operation fails.

Comment by Bart Verwilst [ 2010 Apr 15 ]

Template_B Template_C

 
 
 
----------   -----------
 

Template_A Template_D

So you are saying that creating a dep from B to C should work? What the difference between creating one between B and D then? B and C aren't linked to eachother, sharing the same template shouldn't matter, right? ( Having B attached to your host doesn't mean it has C as well )

Comment by Bart Verwilst [ 2010 Apr 15 ]

Damned, JIRA screws up my pretty ASCII art

Comment by richlv [ 2010 Apr 15 ]

3. it is possible to link templates with identical items to a host from template properties if linking them one by one.
this is also possible when linking two templates with the same item to the host in one go.
should not be possible

Comment by richlv [ 2010 Apr 27 ]

dev branch rev 11710.

4. have two templates where a trigger in one depends on trigger in the other. link these to another template.
unlink these templates.
link them again - trigger that had the dependency is not properly updated (duplicate is created)

Comment by richlv [ 2010 Apr 27 ]

turns out it's not caused by the dependency, but a slightly more complex trigger expression.
currently one that causes the problem : "((

{t_circlink3:a.last(0)}

>0)&(

{t_circlink3:a.nodata(60)}

=0))"

Comment by richlv [ 2010 Apr 27 ]

confirming the fix for problems 1-4 in dev branch rev 11730...

Comment by Alexey Fukalov [ 2010 Apr 27 ]

branches/1.8 11736

Generated at Sat Apr 27 02:45:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.