[ZBX-2925] locale editor adds empty strings to the final file Created: 2010 Aug 24 Updated: 2017 May 30 Resolved: 2010 Aug 26 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | None |
Fix Version/s: | 1.8.4 |
Type: | Incident report | Priority: | Blocker |
Reporter: | richlv | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Description |
if "leave empty" is chosen in the locale editor, final file contains empty values - ones defined as '' "leave empty" is the most usable editing option, but empty values in the file result in no text in the frontend. empty values should not be written in the resulting file at all. |
Comments |
Comment by Alexey Fukalov [ 2010 Aug 25 ] |
branches/1.8 14094 |
Comment by richlv [ 2010 Aug 25 ] |
confirming the fix in trunk rev 14090. |
Comment by Oleksii Zagorskyi [ 2010 Aug 31 ] |
Serious problem founded. 'S_CHART4_HEADER_TITLE_PART1'=> '', Reopen this issue for resolve situation. |
Comment by Oleksii Zagorskyi [ 2010 Aug 31 ] |
oops, wrong. it will not undefined variable, everything should be fine . But this is an unexpected result from these changes. |
Comment by richlv [ 2010 Aug 31 ] |
hmm, yes, introduction of empty strings to combine final string is interesting... hopefully this problem will be gone in 2.0 and proper placeholders will be used |
Comment by richlv [ 2010 Sep 02 ] |
hmm... actually one problematic situation might be like follows : english locale defines some string; looks like gettexting everything is needed badly... |
Comment by Oleksii Zagorskyi [ 2010 Sep 02 ] |
aha. I was thinking that you can remove all these empty variables, checked and discovered that the Japanese language uses 'S_GRAPH_DELETED_FROM_HOSTS_PART3' |
Comment by richlv [ 2010 Sep 02 ] |
no, if they are using a string that is not defined in english, it is ok. if somebody tries to undefine a string that is defined in english translation, then it would be a problem. i believe we'll just have to live with this situation until a proper gettexting happens |
Comment by Oleksii Zagorskyi [ 2010 Sep 02 ] |
Everything is fine, I understand where the problem immediately. |