[ZBX-3473] it is possible to save host with empty dns name and "connect to" set to dns Created: 2011 Jan 27  Updated: 2017 May 30  Resolved: 2011 Oct 31

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.4
Fix Version/s: 1.8.9

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: hostconfigform, hosts, trivial, validation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

it is possible to save host with empty dns name and "connect to" set to dns
when exported, it is rejected by trunk upon import



 Comments   
Comment by richlv [ 2011 Oct 25 ]

(1) new code doesn't follow https://zabbix.org/wiki/Docs/specs/coding_style (specifically, spacing)

<richlv> for the record, new/modified still has things like :
if (!check_db_fields($host_db_fields, $host)){

<pavel> RESOLVED.

<Vedmak> CLOSED

Comment by richlv [ 2011 Oct 25 ]

(2) there should be a different fix for trunk (this might be be already be planned, just noting so that it's not forgotten) because of gettext usage

Comment by Pavels Jelisejevs (Inactive) [ 2011 Oct 25 ]

(2) I believe it's already fixed in the trunk. I'll double check it.

Comment by richlv [ 2011 Oct 26 ]

(3) i don't think i like the following

> svn log --stop-on-copy svn://svn.zabbix.com/branches/dev/ZBX-3473
------------------------------------------------------------------------
r22661 | pavels | 2011-10-26 11:01:01 +0300 (Wed, 26 Oct 2011) | 1 line

  • ZBX-3504 Adds a more generic error message when no maps are defined

<pavel> Sorry about that. RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2011 Oct 27 ]

(4) [GUI]
Some code reformation we discussed. (IF clauses)

Done. [RESOLVED]

<Vedmak> review please my last commit

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2011 Oct 31 ]

Merged to /branches/1.8 revision r22796. CLOSED.

Generated at Fri Apr 26 19:27:19 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.