[ZBX-4340] Escalator should expand action's macros only when needed Created: 2011 Nov 09  Updated: 2017 May 30  Resolved: 2014 Oct 06

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 1.8.8
Fix Version/s: None

Type: Incident report Priority: Major
Reporter: Oleksii Zagorskyi Assignee: Unassigned
Resolution: Won't fix Votes: 1
Labels: escalator, macros, performance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File escalator_only_demo.log    

 Description   

This issue is continuation of ZBX-4321

I suggest to reconsider a design when escalator should expand the macros from action's "Default subject" and "Default message"

Currently it does expanding all macros as first step disregarding that for instance:

  • according to operation condition(s) nothing to do;
  • operation type it's "Remote command";
  • operation does not use "Default message" (ZBX-4321 related);
  • escalation step should be skipped;
  • insufficient user permission;
  • allowed period of time doesn't passed;
  • etc.

I suggest to expand macros even after function "check_time_period()" i.e. after all internal conditions will be passed. Once expanded and prepared values should be cashed for next action's operations, steps.

Benefits: less loaded escalator, less loaded SQL server, less lines in the DebugLog when no operations executed

Would be nice to conclude the step of expanding "Default subject" and "Default message" to a separate function because currently in the DebugLog are not visible "borders" where this step is started and finished.

Demo debuglog (escalator only) is attached.



 Comments   
Comment by Alexei Vladishev [ 2011 Nov 29 ]

Caching of the macros is a very good idea. It should be seriously considered for implementation.

Comment by Alexander Vladishev [ 2014 Oct 06 ]

Already fixed in version 2.0.6 with a development work ZBXNEXT-1643. I close the issue.

Generated at Thu Apr 03 07:35:39 EEST 2025 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.