[ZBX-5688] bad trigger line in graphs when using suffixes Created: 2012 Jul 03  Updated: 2017 May 30  Resolved: 2012 Oct 12

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.4rc1, 2.1.0

Type: Incident report Priority: Minor
Reporter: Ghozlane TOUMI Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: suffixes, triggerline, trivial
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When using suffixes in trigger expressions , the trigger line in graph do not take the suffix in account :
using

{host:sysUptime.last(0)}

<1h, the trigger line in the graph and legend is '1' rather than 3600.

I have the same problem using complex triggers :

{host:system.cpu.load[,avg5].min(#2)}

>{$MAX_CPU_LOAD} is OK
but

{host:system.cpu.load[,avg5].min(#2)}

>2*{$MAX_CPU_LOAD} gets a trigger line at 2.

 Comments   
Comment by Alexei Vladishev [ 2012 Oct 10 ]

I would consider this as a bug.

Comment by Alexey Fukalov [ 2012 Oct 12 ]

Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5688

Fixed only suffix support. Complex expressions are not supported for graph triggers for now.

Comment by Ghozlane TOUMI [ 2012 Oct 12 ]

hmm. the fix seems not complete,
from what I understand from source,

  • you translate only K, M and G...
  • for others right hand values, the first numeric value is taken as trigger limit, wich is wrong.
  • trigger > 1h will draw a line at 1 not 3600,
  • trigger > 2*3000 will draw a line at 2.

please

  • add convertion for time based units,
  • for "complex triggers", at least disable the trigger line (I guess a '$' at the end of the regexp should do)
Comment by Alexey Fukalov [ 2012 Oct 12 ]

Hmm, all suffixes (TGMKsmhdw) should work in dev branch.
I added more strict matching for regexp, thank you for suggestion.

Comment by Ghozlane TOUMI [ 2012 Oct 12 ]

Ignore my comment on units, I was reading the diff backwards . duh.

Comment by Toms (Inactive) [ 2012 Oct 16 ]

TESTED

Comment by Alexey Fukalov [ 2012 Oct 16 ]

Fixed in 2.0.4rc1 r30864, pre-2.1.0 r30865.

Generated at Fri Apr 26 06:47:45 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.