[ZBX-8243] changed error message for notsupported items not logged in server logfile Created: 2014 May 21 Updated: 2017 May 30 Resolved: 2014 Jul 03 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Server (S) |
| Affects Version/s: | 2.2.3 |
| Fix Version/s: | 2.2.4rc1, 2.2.5rc1, 2.3.1 |
| Type: | Incident report | Priority: | Trivial |
| Reporter: | richlv | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | logging, troubleshooting | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
if an item becomes unsupported, it is logged in server logfile and stored in item's error field. if the error message later changes, it is written in the item, but not in the logfile - this makes debugging much harder. if the error message changes, that should be written to the logfile, too |
| Comments |
| Comment by Juris Miščenko (Inactive) [ 2014 May 26 ] |
|
Fix implemented at svn://svn.zabbix.com/branches/dev/ZBX-8243 |
| Comment by Andris Zeila [ 2014 May 30 ] |
|
(1) We should log not-escaped error value. jurism Corrected. RESOLVED. wiper CLOSED |
| Comment by Andris Zeila [ 2014 May 30 ] |
|
(2) While looking at error messages I noticed that the 'item xx became supported' message src/libs/zbxdbcache/dbcache.c:1083 is broken. Would be nice to fix it too. jurism Log message adjusted. RESOLVED. |
| Comment by Andris Zeila [ 2014 May 30 ] |
|
Successfully tested, please check changes in r46010 |
| Comment by Juris Miščenko (Inactive) [ 2014 May 30 ] |
|
Fix merged in 2.2.4rc1 r46026, 2.3.1 (trunk) r46029 |
| Comment by Alexander Vladishev [ 2014 Jun 20 ] |
|
REOPENED (3) First error message is printed twice 31909:20140620:160508.408 item "host:agent.ping[]" became not supported: Not supported by Zabbix Agent 31909:20140620:160508.408 error reason for "host:agent.ping[]" changed: "Not supported by Zabbix Agent" jurism RESOLVED. wiper CLOSED |
| Comment by Alexander Vladishev [ 2014 Jun 20 ] |
|
(4) the message is incorrectly formatted
jurism Message formating corrected. RESOLVED. <richlv> let's change that to "Zabbix agent" as per https://www.zabbix.org/wiki/Docs/specs/syntax#Syntax src/zabbix_server/server.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Server. Zabbix %s (revision %s).",
src/zabbix_server/server.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Server stopped. Zabbix %s (revision %s).",
src/zabbix_proxy/proxy.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Proxy (%s) [%s]. Zabbix %s (revision %s).",
src/zabbix_proxy/proxy.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Proxy stopped. Zabbix %s (revision %s).",
src/libs/zbxwin32/service.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent shutdown requested");
src/libs/zbxwin32/service.c: zbx_error("\n\n\t!!!ATTENTION!!! Zabbix Agent started as a console application. !!!ATTENTION!!!\n");
src/zabbix_agent/zabbix_agentd.c: zabbix_log(LOG_LEVEL_INFORMATION, "Starting Zabbix Agent [%s]. Zabbix %s (revision %s).",
src/zabbix_agent/zabbix_agentd.c: zabbix_log(LOG_LEVEL_INFORMATION, "Zabbix Agent stopped. Zabbix %s (revision %s).",
src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Not supported by Zabbix Agent");
src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Zabbix Agent non-critical error");
src/zabbix_server/poller/checks_agent.c: zbx_snprintf(buffer, sizeof(buffer), "Received empty response from Zabbix Agent at [%s]."
include/version.h:#define APPLICATION_NAME "Zabbix Agent"
I think it would be better to create a new ZBX and change all occurrences of Zabbix <Application> at the same time. And I'm not sure if we should change application name in Windows. wiper it was decided to leave out the capitalization issues. The primary issue is fixed, so CLOSED |
| Comment by Alexander Vladishev [ 2014 Jun 20 ] |
|
(5) the line is too long zabbix_log(LOG_LEVEL_WARNING, "error reason for \"%s:%s\" changed: \"%s\"", item->host.host, item->key_orig, h->value_orig.err); jurism Line broken down to fit guideline length. RESOLVED. wiper CLOSED |
| Comment by Juris Miščenko (Inactive) [ 2014 Jun 30 ] |
|
Fix implemented in svn://svn.zabbix.com/branches/dev/ZBX-8243 |
| Comment by Andris Zeila [ 2014 Jul 01 ] |
|
(6) Fixed multiple unrelated formatting issues in r46955, please review jurism Formating now looks proper. Thank you. RESOLVED. CLOSED. |
| Comment by Andris Zeila [ 2014 Jul 01 ] |
|
Successfully tested |
| Comment by Juris Miščenko (Inactive) [ 2014 Jul 01 ] |
|
Corrections merged in 2.2.5rc1 r46961, 2.3.1 (trunk) r46962 |
| Comment by richlv [ 2014 Jul 02 ] |
|
(7) as discussed on irc, whatsnew entry should go in 2.2.4 whatsnew <richlv> looks good to me, CLOSED |