[ZBX-8820] Not working double Bulk acknowledge triggers Created: 2014 Sep 25  Updated: 2017 May 30  Resolved: 2015 Oct 30

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.2.6, 2.4.0
Fix Version/s: 3.0.0alpha2

Type: Incident report Priority: Major
Reporter: Evgeny Molchanov Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: acknowledgements
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File ack_step1.png     PNG File ack_step2.png     PNG File ack_step3.png     PNG File ack_step4.png     PNG File ack_step5.png     PNG File ack_step6.png    
Issue Links:
Duplicate
duplicates ZBX-2622 unable to view acknowledgements from ... Closed
is duplicated by ZBXNEXT-2625 Cannot include in bulk acknowledge al... Closed
is duplicated by ZBX-4248 It is impossible to confirm the trigg... Closed
is duplicated by ZBX-7589 "----[BULK ACKNOWLEDGE]----" suffix b... Closed

 Description   

Not working double Bulk acknowledge triggers. If acknowledge triggers one, the message is saved.

Specification



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 25 ]

Could you please provide more information on how exactly to reproduce the problem?

Comment by Evgeny Molchanov [ 2014 Sep 25 ]

2 trigger a confirmation message test1
again, those same triggers confirmation message test2
test2 message is not saved
confirm only 1 trigger message test2 - - the message is saved

Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 26 ]

Ah, thank you for the detailed description, now I understand.

The thing is that the acknowledge controls are currently inconsistent. When you use bulk acknowledge for triggers, it acknowledges all unacknowledged problem events for the selected triggers. Since the second time you bulk acknowledge a trigger, all of its events are acknowledged, it doesn't do anything.

As for the "Acknowledge" link. If a trigger has unacknowledged problem events, it will act the same way as the bulk acknowledged button, that is, acknowledge all unacknowledged events. But if it doesn't have any unacknowledged problem events, it will acknowledge the last event of the trigger.

I guess we'll need to rethink this feature in the next release, this is extremely confusing. And document this in the current releases.

Comment by Raj R Kumar [ 2014 Oct 16 ]

Is there any workaround for this? This is really needed by our project.

Comment by Oleksii Zagorskyi [ 2014 Dec 22 ]

ZBX-7589 could be also taken into account to develop them together.

Comment by Alexander Vladishev [ 2015 Feb 08 ]

Related issue: ZBX-2622

Comment by Alexander Vladishev [ 2015 Aug 25 ]

Available in the development branch svn://svn.zabbix.com/branches/dev/ZBX-8820

Comment by Oleg Egorov (Inactive) [ 2015 Aug 25 ]

(1) String changes?

Strings added:

  • %1$s event
  • %1$s events
  • Cannot acknowledge events
  • Events acknowledged
  • Incorrect value for field "%1$s": %2$s.
  • Only selected event
  • Only selected events
  • Selected and all unacknowledged PROBLEM events
  • Selected and all unacknowledged events
  • cannot be empty

Strings deleted:

  • ----[BULK ACKNOWLEDGE]----
  • Acknowledge added
  • Acknowledge alarm by
  • Acknowledge and return
  • Add comment by
  • List
  • No events to acknowledge
  • Update and return

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Aug 26 ]

API validation issue added under ZBX-3783 (20)

Also

{
    "eventids": [
        219883,
        219856
    ],
    "message": 0,
    "acknowledge_type": "test"
}

Return success message, and action it the same as acknowledge_type = null

Comment by Oleg Egorov (Inactive) [ 2015 Aug 27 ]

(2) Minor coding style improvement in r55204
Please review

sasha Thanks! CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Aug 27 ]

(3) Performance issue
I have an installation with 109499 unacknowledged events, but real users sometimes have 1 000 000+ unacknowledged events (discussed with dotneft).
I try to acknowledge problem trigger with 109499 events and I get the following error:

Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 41 bytes) in C:\xampp\htdocs\ZBX-8820\frontends\php\include\classes\debug\CProfiler.php on line 211

sasha Works fine for 500K events and memory_limit = 1GB. Please try again without Debug mode.

sasha RESOLVED in r55212.

3:30 minutes for 1M acknowledges and memory_limit = 128M.

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2015 Aug 28 ]

TESTED

Comment by Alexander Vladishev [ 2015 Aug 28 ]

Available in:

  • pre-3.0.0alpha2 (trunk) r55249.
Comment by Alexander Vladishev [ 2015 Aug 28 ]

(4) Documentation

martins-v Updated sections:

Please review. RESOLVED.

sasha

  • Bulk acknowledge now allowed from all these pages: Dashboard->Last 20 issues, Dashboard->System status, Monitoring->Overview (triggers), Monitoring->Status of triggers, Monitoring->Events, Monitoring->Event details, Screens->Host group issues, Screens->Host issues, Screens->System status, Screens->Triggers overview. It must be mentioned.
  • "brackets" are not used in 3.0.0. Please remove this word.

    A 'Yes' may also have a number with it in brackets, indicating the number of comments for the problem so far.

REOPENED

martins-v Updated:

RESOLVED.

sasha Thanks! CLOSED

<richlv> let's mention the removal of the hardcoded bulk acknowledge message in the upgrade notes

martins-v RESOLVED: https://www.zabbix.com/documentation/3.0/manual/installation/upgrade_notes_300#frontend_changes

<richlv> thank you, looks good

CLOSED

Comment by Alexander Vladishev [ 2015 Sep 23 ]

(5) An empty acknowledge can be created now. It should be fixed.

sasha TESTED Take a look at my changes in r55751.

vitalijs.cemeris CLOSED

Comment by vitalijs.cemeris (Inactive) [ 2015 Sep 25 ]

FIXED IN 3.0.0alpha3(trunk) r55762
CLOSED

Comment by Aleksandrs Saveljevs [ 2015 Sep 28 ]

(6) The following comment has a couple of typos:

Trims all elements values that have currect selector and are inside Jquery object first element.

The word "currect" is somewhere between "current" and "correct", and the proper capitalization for "Jquery" is "jQuery".

sasha RESOLVED in r55821.

asaveljevs According to martins-v, "Trims selected element values." is more correct than "Trims selected elements values."

sasha Thanks for pointing me to the right side. RESOLVED in r56001.

CLOSED

Comment by richlv [ 2015 Sep 29 ]

(7) the changelog entry currently talks about "functionality to trim multiple JS elements" - was there no user-visible angle to this change, for example, didn't it disallow adding empty acknowledgement messages ? if it did, that would be nice to use in the changelog entry as per the development guidelines :

Changelog entries should try to describe the fix from user perspective

sasha RESOLVED in r56002.

<richlv> for the record, changelog message was changed to "fixed trimming of new acknowledge messages" - thanks
CLOSED

Comment by Ivo Kurzemnieks [ 2015 Dec 08 ]

The message handling caused ZBX-10140

Generated at Fri Apr 26 04:35:14 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.