(1) No translation strings changed.

sasha CLOSED

RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-9945

(2) Radio button is getting lost when changing the check type.

vitalijs.cemeris RESOLVED in r56004

sasha This solution works fine, but this source code will be hard to maintain. Any changes in the template will shall change this code.

REOPENED

sasha RESOLVED in r56273.

iivs Discussed with richlv and decided to fix another problem that exists in this form:
When removing a discovery check, the element under "Device uniqueness criteria" is removed with the selected radio button leaving all radio buttons empty. Saving that form we receive an error "Field "Device uniqueness criteria" is mandatory.", but when the page is now refreshed, the first radio button is selected. A default one (assuming the first one) should be selected already upon removing an element with selected radio button so at least one radio button is always selected.

REOPENED

sasha Works fine on FF. I cannot reproduce the issue.

sasha Reproducible only with new checks.

Steps:

• click [Create discovery rule]
• create new Zabbix agent discovery check
• select this check in Device uniqueness criteria
• remove this discovery check

sasha RESOLVED in r56289.

iivs Thanks! Works great now.
CLOSED

(3) Coding style:
configuration.discovery.edit.js.php: 21-28

• block with CLabel is missing an indendation;
• multiple method chaining: each method must be written on a separate line;
• misplaced PHP closing tag

vitalijs.cemeris RESOLVED in r56004

sasha The code still incorrectly formatted. REOPENED

sasha RESOLVED in r56271 (also fixed formatting of all templates)

iivs I still think that closing parenthesis should be on a new line. For example configuration.sysmaps.js.php: 311-312. The syntax there is correct. But see, for example, line 161. It is the same thing, only instead of null there is an array, but closing parenthesis looks misplaced.
I fixed several indentation problems and line overflows in r56282, please review.

sasha Thanks! CLOSED

TESTED

Fixed in pre-3.0.0alpha4 r56299.