Flicker-free screens (ZBXNEXT-1327)

[ZBXNEXT-1253] Support of flicker-free displaying of screens in monitoring Created: 2012 Jun 05  Updated: 2017 May 31  Resolved: 2012 Oct 23

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: 2.1.0
Fix Version/s: 2.0.3, 2.1.0

Type: Change Request (Sub-task) Priority: Major
Reporter: Eduards Samersovs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 3
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File time_period_incorrect_scrollbar.png    
Issue Links:
Duplicate
duplicates ZBX-3268 Zoom slider does not affect plain tex... Closed
duplicates ZBX-1212 huge screen not working properly Closed
is duplicated by ZBXNEXT-879 reload screen elements without full p... Closed
is duplicated by ZBX-2858 durations formatted differently in gr... Closed
is duplicated by ZBX-5222 If we add data overview to screen, th... Closed

 Description   

Flicker free means no full refresh of pages for screen displaying in monitoring. Only individual cells should be refreshed.

Flicker free screen should deliver exactly the same look&feel as screens in Zabbix 2.0. Be careful when implementing support of URLs!

All cells must be refreshed individually and absolutely instantly, no flickers are allowed. Even if we have 100x100 screen, there will be no flickering during refresh of individual cells.

Time navigator will not cause page reload.

New code base could be reused in the future to make screen elements embeddable into Dashboard.

Logic and presentation must be separated for displaying cells of different types. Each cell-type must use separate file(s) for presentation.



 Comments   
Comment by richlv [ 2012 Jun 05 ]

this is actually a dupe of ZBXNEXT-601 - see specification draft there as well

Comment by Alexander Vladishev [ 2012 Jun 06 ]

Forum:
http://www.zabbix.com/forum/showthread.php?t=26549

Comment by Eduards Samersovs (Inactive) [ 2012 Jun 19 ]

Implemented in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1253

Comment by Eduards Samersovs (Inactive) [ 2012 Jun 19 ]

(1) Select box changes not synchronized with scroll bar.

<Eduard> RESOLVED

<Vedmak> when some period selected in zoom, timeline can jump to incorrect time usually after currently selected period.

<Eduard> RESOLVED + synchronized sbox formatting as in scrollbar. If you catch the bug with incorrect sbox time, please write use case how to reproduce this..

<Vedmak> CLOSED

Comment by Alexei Vladishev [ 2012 Jun 19 ]

(2) Undefined index: legend [include/classes/flickerfreescreens/CFlickerfreeScreenGraph.php:156]

As seen in configuration of screens when selecting a simple pie graph. Graphs is broken and displays: Warning. Field "legend" is not integer. The URL from Apache log file chart6.php?graphid=503&width=400&height=100&legend=&graph3d=1&period=63072000.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexei Vladishev [ 2012 Jun 19 ]

(3) I have 2x2 screen displaying 4 simple graphs. I am unable to zoom-in into graphs of first column, mouse with pressed left button just moves the whole graph instead of selecting region.

<Eduard> Duplicates (18)
<Eduard> CLOSED

Comment by Alexei Vladishev [ 2012 Jun 19 ]

(4) I have 20x20 screen filled with graphs with 10 seconds refresh interval set in user profile. Firefox keeps loading this screen forever while the screen (header, footer, filter are ok) stays blank, however I see huge number of requests coming to Apache. I see no graphs displayed after waiting for around 10 minutes.

Zabbix 2.0.0 can handle this situation easily displaying all 400 graphs after a few seconds.

Same happens under Configuration. The table is quickly displayed with 'Change' links, but no actual graphs displayed. I see that front-end tries to refresh cells every 10 seconds. Not sure if it has to be done this way when configuring a screen.

PS Increasing of the refresh to 60 seconds interval fixes displaying, however it is still very slow. Also see (5).
<Eduard> Moved to ZBXNEXT-1298

Comment by Alexei Vladishev [ 2012 Jun 19 ]

(5) Doing more experiments with 20x20 screen. Apache shows that all graphs are updated after 60 seconds, but I see old images with older timestamp.

It could be something related to caching, adding a sequence as a GET variable will probably help. Perhaps there are other solutions.

<Eduard> Moved to ZBXNEXT-1298

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(6)
Cannot edit "Data overview" screen element.
"Critical error. Field "screenid" is mandatory."

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(7)
Zooming on graph is always for 1h period, it ignoring actual graph period.

<Eduard> Duplicates (1)

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(8)
When try to sort column in "History of actions" it shows some plain not rendered html.

<Eduard> RESOLVED

<Vedmak> Sorting now works, but after each sorting change it seems to start new update process. For example we have interval 10 seconds, after load i waited 5 sec. and changed sorting, new screen element is updated every 5 sec.

<Eduard> RESOLVED

<Vedmak> When screen is opened, sorting reloads whole page, but after first refresh sorting reload only sorted element.

<Eduard> RESOLVED. Now sorting work like in Host Triggers

<Vedmak> sorting by time is missing

<Eduard> RESOLVED

<Vedmak> In sort selection list, all fields first go with 'ascending' option, only Time has incorrect order.
Also if i select to show for example 5 actions screen element will show only first 5 actions, ordering affect only these first 5 actions. In current trunk it's working differently.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(9)
Data is not shown in 'Plain text' screen elements when edit screen.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(10)
not actually related to this issue, but too small to create separate.
Screen element 'Status of hostgroup triggers' should be renamed to 'Status of host group triggers'.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(11)
'Dynamic' option seems not working for 'Plain text' elements.
It's reset to 'Default' after first refresh.

<Eduard> RESOLVED

<Vedmak> still reproducible

<Eduard> RESOLVED

<Vedmak> still reproducible

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(12)
Data overview is not 'flicker free'. Should it be?
Probably it's because of images in header...

<Eduard> RESOLVED

<Vedmak> not sure if it's related, but...

Seems data overview is not updated, numbers are not changed.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(13)
When screen page is opened in monitoring, refresh interval value is not shown in page title.

<Eduard> RESOLVED

<Vedmak> Same for monitoring->graphs

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(14)
Timeline bar current time is not updated over time.

<Eduard> RESOLVED

<Vedmak> Now when timeline is set to "Now" page sends 2 identical ajax requests.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(15)
"History of actions" when screen is opened shown with sorting by 'Time', but after first refresh sorting jumps to 'Recipient'.

<Eduard> Sorting jumps because of changing $page['file'] variable. If we decide to move sorting to configuration this issue will disappears.

<Eduard> RESOLVED, see (8)

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(16)
Map elements on screen are not clickable anymore.

<Eduard> RESOLVED

<Vedmak> works if map is current screen element, but if we have screen with screen with map, popups don't work.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(17)
'Plain text'. When it's loaded it shows data, but if i move timeline to 'now' time, all data disappear.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(18)
Zooming is not possible for graphs on screen inside screen.

<Eduard> RESOLVED

<Vedmak> zooming works now, but not always synchronized.
Open screen with graph, change period, try to use zoom, it seems it use period which was when screen loaded.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(19)
When we change timeline elements are updated, this updated probably should reset refresh timer. Now we can change timeline, elements are updated and in 1sec they are updated again because of automatic refresh.

<Eduard> RESOLVED

<Vedmak> still reproducible

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(20)
Create screen with 'System status' element and make it display some problems.
Hover mouse over problems, popup is opened, with opened popup wait for automatic refresh, after refresh popup is always shown and cannot be closed.

<Eduard> RESOLVED

<Vedmak> popup that is shown on hover now removed on refresh, but if we click on element to get static popup, it's not removed on refresh.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(21)
in CScreenItem.get there is added unused option 'fillReals'.

Also new option 'hostids' should be documented. I couldn't really understand what it does, get options should filter reasults, but this one seems only add additional field to result. I'm not sure it should be in screen items class at all.

<pavels> Let's discuss this together when you reach this point.

<Eduard> RESOLVED, created new API class - CTemplateScreenItem

<Vedmak> CLOSED complete implementation is moved to ZBXNEXT-1328

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(22)
On host template screens page header is changed, host info bar is missing and links to screens are moved to upper header.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(23)
I think 'flickerfree' should be removed from all names of classes, dirs, etc. because it's just screens with flicker free option, we don't have non-flickerfree screens.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(24)
New function zbx_floatToString is not used, should be removed.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(25)
window.setInterval must be avoided, we should use window.setTimeout instead.
More info why https://developer.mozilla.org/En/Window.setInterval#Dangerous_usage

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(26)
In latest data history 'as plain text' now shows html table instead of plain text.

This branch seems change latest data history view too, is there any specs what is changed?

<Eduard> RESOLVED
In spec is this point: "History page must be redesigned to use flicker-free screens."

<richlv> hmm, i believe the main point here was "what is changed" - exact description is utterly missing -> REOPENED

<Eduard> RESOLVED

<richlv> documentation part split out as (68), CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(27)
For each class there should be separated file, CFlickerfreeScreenItem should be moved to separate file.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 04 ]

(28) New classes lack phpdoc.

<pavels> All of the properties and methods should be commented.
<Eduard> RESOLVED

<pavels> The phpdoc comments lack parameter and return value descriptions. Please add them according to the guidelines https://zabbix.org/wiki/Docs/specs/coding_style#PHPDoc

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 06 ]

(29) When I change the interval on the timeline, the graph scale is not updated. That is, if an interval of 1h has been selected on the timebar, and I change it to 1 month, the whole graph interval will still be 1h.

<Eduard> Timeline box increasing width, commonly, starting from 8 days. Work same as trunk. WON'T FIX.

<pavels> Sorry, this issue seems to be a duplicate of (1) and (7). CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 09 ]

(30) The properties of the new classes should use camel case and probably shouldn't be public.

<Eduard> RESOLVED

<pavels> Please add a phpdoc to all properties.
<Eduard> RESOLVED

<pavels> Please documents the properties themselves too.
<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 09 ]

(31) You don't need to set default option values in jsrpc.php in screen.get, because they are set in the screen classes. Also, to avoid all of the isset blocks, the options can be passed as an array in GET and then passed directly to the screen class.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 12 ]

(32)
Timeline seems broken a bit. I cannot move slider to make it show "now" time with one move.

<Eduard> RESOLVED

<Vedmak> still reproducible

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 13 ]

(33)
Refresh should be disabled in screen configuration.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 13 ]

(34) When I open monitoring - graphs, no graphs are displayed, and I see an error:

Undefined offset: 0 [charts.php:199]
Undefined variable: chartForm [charts.php:199]

<Eduard> RESOLVED

<pavels> The error should be displayed as plain text, not as an image.

<Eduard> RESOLVED

<pavels> The message should be changed to "No graphs defined". We don't use the word "chart" anywhere.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 16 ]

(35)
In screen configuration, graphs show (2y) period in title, but actual period is one day.
<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 16 ]

(36)
Open edit of screen with screen element, it's displayed as screen edit inside screen edit.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Stefan [ 2012 Jul 18 ]

maybe a redseign with html5?! or ajax?!

<Eduard> We must to support IE8 browser and others.., so at this time we not ready to use HTML5.. But it probably will happens in future! WON'T FIX.

Comment by Alexey Fukalov [ 2012 Jul 18 ]

(37)
In monitoring->graphs try to move timeline many times to right border, it begins to go outside timeline area.

<Eduard> RESOLVED

<pavels> The problem remains in Chrome. I can more the timeline up to 31.07.2012 00:00 by dragging it to the border.

<Eduard> Please retest it again..

<pavels> Moved to ZBXNEXT-1351. CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 18 ]

(38)
Every change of timeline starts ajax request. There probably should be some delay, or check that delay consequent requests if there is active one.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 18 ]

(39)
As there are no specs, call it a bug...

When screen is opened in monitoring and then changed in another tab or by another user, these changes are not displayed in opened screen after automatic refresh.

<Eduard> SPEC: Flicker-free screens don't refresh himself configuration, only update data. WON'T FIX.

Comment by Alexey Fukalov [ 2012 Jul 18 ]

(40)
As there are no specs, call it a bug...

Url screen elements are not refreshed by automatic refresh.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 18 ]

(41)
History for log items seems ignore timeline, php error in log history page, filter options not work too.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 19 ]

(42)
When open screen in monitoring->screens, in trunk timeline is reset to "(now)", in branch it's not.

<Eduard> RESOLVED

<Vedmak> still reproducible

<Eduard> Every screen remember himself stime and period, if it was set to "Now" next time it will open on the remembered place. WON'T FIX.

<pavels>This seems to be a duplicate of (47). It contains a more detailed problem description. CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 19 ]

(43)
If w open screen in monitoring and then delete it in configuration, in monitoring non-image elements are replaced with text about PHP fatal error.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 19 ]

(44)
Create screen with "Status of host triggers" element without preselected group.
Open that screen in monitoring, wait for first refresh and try to change group/host, white screen with some error is shown.

Same if you click on 'Ack' link to go to acknowledge form and there click cancel.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 19 ]

(45)
In slideshow screen with graphs are not shown.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 19 ]

(46)
Graphs are not shown in Monitoring->Web.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Kenneth Palmertree [ 2012 Jul 22 ]

(47)

I know this is still in development but want to note this in case it was not noticed already.

In the latest version ZBXNEXT-1253, if a user goes into a screen for the first time and it shows "now" in the time bar, the graphs will not update until the user drags the time bar to the right. Also, if a user comes back to the screen it will not go back to "now" but where the last time the bar was dragged to now.

For example:
1. User goes into screen and there is nothing in their profile for it so it starts at now for ending time.
2. Wait a while but graphs never update and time is frozen on the bar even though it says "now" for ending time.
3. Drag time bar to the right to now and then screens will refresh. Note the time when you do this because it will show this time the next time you come back to screens.
4. After a few minutes leave screen and come back to it and it will stop at the time in 3rd step above.

Tested this in DM setup of Zabbix

<Eduard> Please retest with latest dev branch..

<pavels> Still reproducible.

<Eduard> RESOLVED, please retest (related with (42))

<pavels> CLOSED.

Comment by richlv [ 2012 Jul 24 ]

kenneth, it is very important to have early feedback as it allows to get the feature in usable state earlier and saves time later - thanks for testing

Comment by richlv [ 2012 Jul 24 ]

(48) looks like this branch ends up affecting other areas (latest data and web monitoring were mentioned in comments). unless i missed it, there is no list of "expected to be affected" pages and/or functionality, which would make testing very hard. a full list such pages/functionality areas should be produced.

<Eduard> RESOLVED. Spec says: "To use flicker-free screens the following pages shall be redesigned: Monitoring->Screen, Monitoring->Slide shows, Monitoring->Graphs, Monitoring->Latest data->History, Monitoring->Latest data->Host screens."

Comment by Alexey Fukalov [ 2012 Jul 24 ]

(49)
I have data for last few weeks. On screen with graph if i select period more than 1 year, data is shown as it was gathered one year ago, if period is less than 1 year, everything is correct.

<Eduard> It's ok, WON'T FIX

<pavels> No, this seems to be a bug. REOPENED.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 24 ]

(50)
Open screen with graph, select "dynamic" timeline mode, increase period by dragging timeline end. Screen period increased but graph zoom period is not updated.

<Eduard> RESOLVED

<pavels> Still reproducible in Firefox.

<Eduard> RESOLVED, related to (18) and (42)

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 25 ]

(51) in Monitoring->events timeline stuck after first move.

<Eduard> RESOLVED

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 30 ]

(52)
Go to history of log item, add another log item, swtch to "latest 500 values" added item is removed from filter

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Alexey Fukalov [ 2012 Jul 30 ]

(53)
In Monitoring->Slide shows, there is debug info returned for ajax requests, it results in double debug info on page.
And debug info probably should not be in ajax response.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by richlv [ 2012 Aug 01 ]

(54) dev branch rev 29354 - debug output has been committed in simple graphs

period=1h, (3600)
starttime=August 2, 2010, 5:55 pm, (20100802175533)
stime=August 1, 2012, 4:55 pm, (20120801165533)
usertime=August 1, 2012, 5:55 pm, (20120801175533)
isnow=1

mm, make that all pages with time period scrollbar

<Eduard> RESOLVED =)))

<richlv> CLOSED

Comment by richlv [ 2012 Aug 01 ]

(55) issue title and summary talk about configuration as well, which doesn't seem to be implemented. which is correct ?

<Eduard> Configuration of screens work without flicker-free self refresh..

<richlv> modified description & summary a bit more, CLOSED

Comment by richlv [ 2012 Aug 01 ]

(56) have screen with dynamic elements, open it in monitoring. change time period displayed, switch host - time period is reset back to 1h and "now"

<Eduard> RESOLVED

<richlv> CLOSED

Comment by richlv [ 2012 Aug 01 ]

note : a regression regarding dynamic screens has been filed as ZBX-5399; once that is fixed, that fix should be merged in this branch and dynamic screen functionality retested

Comment by richlv [ 2012 Aug 02 ]

(57) dev branch rev 29364; opera 12.0, firefox 14.0.1 and konqueror 4.7.2 - grab the rightmost edge of the scrollbar and drag it to the right. result :
https://support.zabbix.com/secure/attachment/19709/time_period_incorrect_scrollbar.png

<Eduard> RESOLVED

<richlv> now, whenever that is done when the period is already at "now", period length is increased (leftmost edge moves) - period should not change in this case

<Eduard> Moved to ZBXNEXT-1328. CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 02 ]

(58) I have a screen containing a screen with a graph. The position of the timeline for this screen is not remembered, it's always 1h "now".

<Eduard> RESOLVED

<pavels> Now if i select a time interval on the graph, then change it on the timeline, leave the screen and come back, it is not remembered. Tested in firefox.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 02 ]

(59) Monitoring - screens and graphs does not work in IE8.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 02 ]

(60) In IE9 graph zoom works only once.

<Sasha> on my IE9 9.0.8112.16421 zoom works as expected.

<pavels> Hmm, may be it's our VM issue. Ok, CLOSED.

<Sasha> REOPENED moved to ZBXNEXT-1351. CLOSED

Comment by Alexander Vladishev [ 2012 Aug 03 ]

(61) content are not updated when change time from (now!) by a calendar or scroll bar components

<Sasha> on IE9 works fine without the problem

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Aug 06 ]

(62) zoom show latest data on graph; time navigator works correctly

<Sasha> on IE9 works fine without the problem

<Eduard> RESOLVED

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Aug 06 ]

(63) after move a scroll bar to a left position periods "2h", "3h"... are blocked

<Eduard> Moved to ZBXNEXT-1328. CLOSED

Comment by Alexander Vladishev [ 2012 Aug 06 ]

(64) after network error elements of a screen cease to be updated

<Eduard> Moved to ZBXNEXT-1328. CLOSED

Comment by Alexander Vladishev [ 2012 Aug 06 ]

(65) Elements of the time navigator aren't updated

  • default periods (1h, 2h, 3h, 6h ...)
  • steps (<< 2h 1h | 1h 2h >>)
  • scroll bar

<Eduard> Moved to ZBXNEXT-1328. CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 07 ]

(66) Sometimes when I select an interval on the timeline and refresh the page, the timeline bar is pushed back 1 hour.

<Eduard> Moved to ZBXNEXT-1351. CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 07 ]

(67) There seems to be some debug code in CScreenGraph::get(): "echo strval(false);"

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by richlv [ 2012 Aug 07 ]

(68) didn't see it linked before - spec is at https://zabbix.org/wiki/Docs/specs/ZBXNEXT-1253
things still missing :

  • full api changes (including full descriptions of whatever is new);
  • the sentence "Monitoring->Screens and Monitoring->Graphs use one namespace for saving user profiles data (such as: period, stime, timelinefixed)." is a bit vague, a bit more text explaining what was changed and how it should all be working now is needed

<Eduard> Moved to ZBXNEXT-1328. CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 07 ]

(69) A couple of problems with the "updateProfile" parameter:
1. it is not set in the validator in chart2.php and is unset after check_fields(). May be in some other files too.
2. It is passed as a "true" or "false" string in the URL, which will always result in a string on the server side. It cannot be treated as a boolean value. I strongly suggest we don't pass get parameter that way and just use 0/1.

<Eduard> RESOLVED

<pavels> I suggest we don't compare values to "true" or "false", but cast them to integers when sending AJAX requests from javascript.

<Eduard> RESOLVED

<pavels> CLOSED.

Comment by richlv [ 2012 Aug 07 ]

(70) db patch should update any changed 'profiles' contents

<Eduard> RESOLVED, (profiles.sql)

<Sasha> CLOSED

<richlv> patch should be also added for 2.2, REOPENED

<Sasha> patches for 2.2 should be added in trunk only!

<richlv> 2.2 patches seem to be missing

<Eduard> RESOLVED in ZBXNEXT-1351

<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Aug 08 ]

Successfully tested!

Comment by Eduards Samersovs (Inactive) [ 2012 Aug 08 ]

Fixed in versions pre-2.1.0 (beta) r29459, pre-2.0.3 r29458

Comment by Oleksii Zagorskyi [ 2012 Oct 23 ]

Fix version: 2.2.0 -> 2.1.0

Comment by richlv [ 2013 Aug 12 ]

this resulted in a regression for log/text file viewing : ZBX-6878

Generated at Fri Apr 26 16:01:30 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.