[ZBXNEXT-1467] rename 'save' to reduce confusion with cloning Created: 2012 Oct 12  Updated: 2015 Feb 06  Resolved: 2014 Aug 27

Status: Closed
Project: ZABBIX FEATURE REQUESTS
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.3.4

Type: Change Request Priority: Minor
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: cloning, trivial, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

an extremely common mistake is to attempt to clone some entity, but mistakenly click on "save" without actually clicking on one of the clone buttons.

this mistake is done both by new and experienced users, so we could try to help them instead of blaming them

the suggestion is to change "save" in hosts, items etc "add" or "update", same as is done in web scenario steps, action operations and some other places

 Comments   
Comment by Oleksii Zagorskyi [ 2012 Oct 13 ]

I agree with Rich, even for experienced users the cloning it's a way where easy to do some mistake.
I recall when I need to fast clone, for example, an item to 5 ones with slightly modified key I have to remember to click the Clone button first when I opened the item form. Otherwise after changing the key I often forget to click Clone first and only then Save button.

So if the button will have different names regarding current action (updating existing object/adding new one) it will be goooood improvement.

Comment by Marc [ 2013 Mar 23 ]

I could imagine that having all buttons available (inactive ones grayed out) would effectively prevent from mistakes.
The intention is to have fixed positions by function. Another sufficient way beside graying out might be to hide inactive buttons but still making sure the active ones reside on the same position.

Comment by Alexei Vladishev [ 2014 Aug 25 ]

All forms and popups were enhanced to have different operations 'Add' and 'Update'.

Available in development branch svn://svn.zabbix.com/branches/dev/ZBXNEXT-1467

Comment by richlv [ 2014 Aug 26 ]

(1) edit an existing it service - button says "add"

sasha RESOLVED in r48438

alexei CLOSED

<richlv> this seems to be ok only for leaf it services - any services that have child services still have this problem. filed as a separate issue at ZBX-8683 as we already released 2.3.4.

also, r48438 seems to have fixes together with formatting changes, which was kinda no-no...

(still CLOSED)

Comment by Alexander Vladishev [ 2014 Aug 27 ]

(2) Strings changed:

strings removed:
  • Map is saved! Return?
  • Map save operation failed.
  • Save
  • Save and return
strings added:
  • Map is updated! Return?
  • Map update failed.
  • Update and return

alexei CLOSED

Comment by richlv [ 2014 Aug 30 ]

looks like this was merged to trunk in r48473

Comment by richlv [ 2014 Aug 30 ]

(3) documentation - text in most pages that references buttons, screenshots etc

martins-v That's been done now for 2.4 onward - text and screenshots. Considering the amount of places that had to be changed, difficult to be sure if it's 100% changed, but should be very close to it. RESOLVED.

sasha These screenshots are unchanged:

REOPENED

martins-v Thanks, RESOLVED.

sasha Thanks, CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 04 ]

This caused a regression - ZBX-8715.

Comment by Alexander Vladishev [ 2014 Sep 23 ]

Available in pre-2.3.4 r48473.

Generated at Fri Apr 26 03:49:22 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.