[ZBXNEXT-556] Frontend i18n using PHP gettext module Created: 2010 Nov 10 Updated: 2011 Mar 31 Resolved: 2011 Jan 19 |
|
Status: | Closed |
Project: | ZABBIX FEATURE REQUESTS |
Component/s: | None |
Affects Version/s: | 2.0.0 |
Fix Version/s: | 1.9.1 (alpha) |
Type: | New Feature Request | Priority: | Major |
Reporter: | Konstantin Buravcov (Inactive) | Assignee: | Konstantin Buravcov (Inactive) |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
trunk |
Attachments: |
![]() ![]() |
Description |
As discussed, a gettext support should be added to frontend. 1. All strings that present in current locale files should be embed for gettext translation; |
Comments |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 13 ] |
|
Comment by Oleksii Zagorskyi [ 2010 Nov 13 ] |
Konstantin, please update directory names according to And, I've tried this my environment: |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 13 ] |
Thank you for your comment, Oleksiy. Most likely you are not able to select the translations because you don't have those locales installed on your system. Can you provide the output of this command for your server? |
Comment by Oleksii Zagorskyi [ 2010 Nov 13 ] |
Konstantin, yes you right. And think and describe in few words, as we (translators) now can update the translation. Meaning the search for new untranslated strings than to change, etc. Are there plans to introduce something like a Pootle? |
Comment by richlv [ 2010 Nov 15 ] |
1. if php gettext support is missing, all we get is : 2. administration -> locales is still there, and gives : other than that, seems to work mostly ok |
Comment by richlv [ 2010 Nov 15 ] |
zalex_ua, yes, availability of pootle and other gettext support tools was a significant motivator for this change - but i guess discussing that in more detail is best done on forum/irc |
Comment by richlv [ 2010 Nov 15 ] |
3. formatting of "*you are not able to choose some of the languages, because locales for them are not installed on the web server." slightly bugs me maybe it can be positioned to the right of the dropdown, wrapped & in red ? or maybe just have an icon that would have a tooltip with that text (it's pretty long) ? icon could be an exclamation mark in a red circle |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 16 ] |
Hint moved next to dropdown and is red now. |
Comment by richlv [ 2010 Nov 16 ] |
by now most things seem to be working mostly fine. summary of general points and unresolved nitpick items 1. if some locales are not available, it would be nice to have the error message wrap - now it extends the screen a lot; once these things are sorted out, this might be ready for the great merge |
Comment by richlv [ 2010 Nov 16 ] |
1. wrapping done in dev branch rev 15527. |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 16 ] |
1. wrap done |
Comment by Oleksii Zagorskyi [ 2010 Nov 20 ] |
please, generate a fresh .po file from |
Comment by richlv [ 2010 Nov 24 ] |
ok, this one is getting close to merge 1. french pofile should be regenerated (updated translation was merged); also, what about plurals (for example, see http://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals) |
Comment by richlv [ 2010 Nov 24 ] |
mm, i'd say 'make gettext' should be called automatically by 'dist', and possibly also snapshot build system should be checked for existence of needed gettext tools (msgfmt etc) |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 24 ] |
Merged to trunk rev 15656 |
Comment by richlv [ 2010 Nov 24 ] |
closing then |
Comment by richlv [ 2010 Nov 24 ] |
mm, reopening to set "fix for" |
Comment by Oleksii Zagorskyi [ 2010 Nov 24 ] |
Looks like that after the major upgrade, users will get an error that they will scare: Locale for language "ru_ru" is not found on the web server... It seems you also should to update 'users' table - update 'lang' column: about changing 'ua_ua' to 'uk_ua' in 1.8.4 release - i tested and is no errors, web-interface simply display English version instead of Ukrainian. Ukrainian users need to simply reselect locale in their profile. |
Comment by Oleksii Zagorskyi [ 2010 Nov 24 ] |
and. in my FreeBSD8.1 web-server the 'Latvian (LV)' selection is unavailable. only 'Latvian (LV)'. |
Comment by richlv [ 2010 Nov 24 ] |
hmm. thanks for the headsup. so for 2.0 db patch must be created for the profiles table; |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 25 ] |
I will work on 2.0 patch. |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 25 ] |
patches created in branch |
Comment by richlv [ 2010 Nov 25 ] |
reverted to ua_ua for 1.8; |
Comment by Konstantin Buravcov (Inactive) [ 2010 Nov 25 ] |
DB patches merged: trunk 15681 |
Comment by Oleksii Zagorskyi [ 2011 Jan 07 ] |
It's not critical, but we all forget to update schema.sql and data.sql |
Comment by Oleksii Zagorskyi [ 2011 Jan 07 ] |
... and existing DB schema should be updated in patches. |
Comment by Konstantin Buravcov (Inactive) [ 2011 Jan 19 ] |
schema.sql and data.sql changed in trunk rev 17025. |
Comment by Oleksii Zagorskyi [ 2011 Jan 19 ] |
yes, schema.sql and data.sql already is updated, but "... existing DB >>>>> schema <<<<<<< should be updated in patches too." In the "./upgrades/dbpatches/2.0/mysql/patch/users.sql" need a: |
Comment by Konstantin Buravcov (Inactive) [ 2011 Jan 20 ] |
Oleksiy, thank you, I completely forgot about that |
Comment by Oleksii Zagorskyi [ 2011 Jan 20 ] |
hmmm, whole saga of these patches And usually developers write a single query in the patch, as I suggested in the previous comment. although I prefer a two query |
Comment by Konstantin Buravcov (Inactive) [ 2011 Jan 21 ] |
fixed, thank you. |
Comment by Oleksii Zagorskyi [ 2011 Jan 21 ] |
checked, i have no more remarks |