trunk rev 17688

I've found this bug too.
export template returns an empty XML file.

I've converted the old Zapcat Java_Template to the new jmx format.
I've also gotten rid of the old JVM stats (e.g., MemoryPool,name=PS Old Gen, etc) to the new thread model.
If this gets fixed I'll submit it.

Is there any workaround to make export template feature work in 1.9.4?

no, at this time xml export is not available in trunk

• Is it possible to migrate db data to previous release and use export feature there?
• Any ideas why it's failing? Is it possible to patch scripts / sql queries somehow?
• Is there some external tool (script) to retrieve this information out of database and import into another? SQL dump or anything?

1. not really
2. data model changed, especially because of multiple interface support
3. if it's exactly same schema, sure, just dump the db. if not, nope.

anyway, it's alpha software... did you have any cats ?

2. data model changed, especially because of multiple interface support

Has Export/Import XML format changed with 2.0 release? If I manually generate XML file in 1.8.x format would Import work?

last i tried importing 1.8 xml format worked in trunk

Here's attached patch for export.inc.php script to fix export template feature (tested in 1.9.4). It seems the problem is that XML export class is expecting hosts attribute for items, but API::Item is returning hostid. I'm not sure if it's proper long term fix or if it breaks some other functionality, but it works for me. Attaching it in case others struggling with this bug and desperately waiting for some workaround.

Alexey, regarding to your patch "export.inc.php.patch" maybe you are wrong in your last comment?
I mean need to swap hosts and hostid in your last comment.

Alexey, regarding to your patch "export.inc.php.patch" maybe you are wrong in your last comment?
I mean need to swap hosts and hostid in your last comment.

I'm not an expert in Zabbix codebase but with applied attached patch "export template" feature was working correctly in 1.9.4

-	$item['hosts'] = zbx_toHash($item['hosts'], 'hostid');
-	if(isset($item['hosts'][$host['hostid']])){
+	#$item['hosts'] = zbx_toHash($item['hosts'], 'hostid');
+	if(isset($item['hostid']) && $item['hostid'] == $host['hostid']){

So there's "hostid" mapping in "$item" hash map instead of "hosts".

A new XML specification document: http://zabbix.org/wiki/Docs/specs/ZBX-3531

(1). "ERROR: Import failed" when importing xml with trigger dependencies in it.

Details:

Created: Trigger "1trigger1" on "FULL_TEST2".
Created: Trigger "2trigger2" on "FULL_TEST2".
Incorrect value "" for unsigned int field "triggerid_up".

Dependency is defined in the following way:

<dependency>
<name>1trigger1</name>
<expression>

>10</expression>
</dependency>

<Vedmak> RESOLVED
<Igor> CLOSED

(2). When trying to export network map is created xml file with the following content:

Fatal error</b>: Call to undefined function prepareMapExport() in <b>C:\Program Files\Xampp\xampp\htdocs\Zabbix\ZBX-3531\frontends\php\include\classes\export\CConfigurationExport.php</b> on line <b>553</b><br />

<Vedmak> RESOLVED
<Igor> CLOSED

(3). When importing screen appears message "Imported successfully", but in the details are visible the following errors:

Details
Imported successfully

Error in query [SELECT t.screenitemid,si.screenid FROM screens_items t WHERE (si.screenid IN ('2')) ] [Unknown column 'si.screenid' in 'field list']
mysql_fetch_assoc() expects parameter 1 to be resource, boolean given [include\db.inc.php:560]
mysql_free_result() expects parameter 1 to be resource, boolean given [include\db.inc.php:561]
Error in query [SELECT t.screenitemid,t.x,t.y,t.screenid,si.screenid FROM screens_items t WHERE 1=0 ] [Unknown column 'si.screenid' in 'field list']
mysql_fetch_assoc() expects parameter 1 to be resource, boolean given [include\db.inc.php:560]
mysql_free_result() expects parameter 1 to be resource, boolean given [include\db.inc.php:561]

<Vedmak> RESOLVED
<Igor> CLOSED

(4). Error when trying to import netw map:

ERROR: Import failed
Cannot find icon map "Array" for map "map1".

<Vedmak> this should be already fixed, is this in last branch revision?
<Igor> No, that was not the latest revision. Now in rev #25676 this is working fine.

<CLOSED>

(5) Not a bug, but ... improvement

Would be nice to have button for unchecking all checkboxes (maybe 2 buttons- one for "Update existing" and second for "Add missing" group of checkboxes) in the import form. Now we have 20 checkboxes in the Import form and by default all of them (except "Images" buttons) are checked.
So, in order to import only graphs, we need to uncheck at least all checkboxes and then select graphs.

Yesteday Vedmak proposed the following idea: by default uncheck all checkboxes and let user to choose what to import by checking the appropriate checkbox.

<Vedmak> RESOLVED

<Igor> CLOSED, has been implemented several checkboxes in the import form for hosts, host groups, templates, items, triggers, etc and separately for "update existing" and "add missing" actions.

(6). When trying to import template with items, triggers, graphs, screens and discovery rules in it, finally on the screen will be visible "Imported successfully", will be created items, triggers, graphs, screens, but:

(6.1). Discovery rules will be not created (but they are defined in the xml file (if required, I can provide such xml file for validation);
(6.2). In the details will be visible the following error: Undefined index: host [include\classes\import\formatters\C20ImportFormatter.php:174]

dev branch rev # 25682.

<Vedmak> RESOLVED

<Igor> OK, now this is resolved, but item/trigger/graph prototypes are still not exported (they does not exist in the result xml) when exporting template, as a result are exported only items, triggers, graphs, screens, discovery rules without item & trigger & graph prototypes.

<Vedmak> RESOLVED

<Igor> Sorry, but in dev branch rev #25695 this is still not working, for me there are NO item/trigger/graph prototypes in discovery rule after importing such template. (as discussed, this occurs in case when there is also one more empty drule, without prototypes and in the export xml file will be only this empty discovery rule).

<Vedmak> ye, there was problem, strange i couldn't reproduce it earlier, RESOLVED

<Igor> Nice, now this is working fine! CLOSED

(7). ERROR: Import failed

Details: Cannot find icon "open_source" for map "map2_in_host".

How to reproduce: Import previously exported map with icon image inside it, then delete this image and map from the Zabbix config.
When importing that map will occur above mentioned error.

<Vedmak> Were "Images" checkboxes checked in import form?

<Igor> Yes, seems that I forgot to select these checkboxes. Now double checked - it is working fine, icon images and bgimages are imported/exported fine.

<Igor> CLOSED

(8). ERROR: Cannot add trigger

Details:
Created: Trigger prototype "tr10" on "T2".
Cannot implode expression "

=10".

Occurs when trying to add trigger prototype to the second discovery rule in template.

<Igor> OK, the same problem is in trunk (rev 25720) and there is already created ZBX issue for this problem: ZBX-4647.

Closing this problem nr. 8.

<Igor> CLOSED

(9). ERROR: Import failed
Details: No permissions to referred object or it does not exist!

This error occurs when trying to import only graphs (in the import form has been selected only "graphs") and using previously created export file for hosts.
The same error also occurs when this graph has been deleted before that.

<Vedmak> RESOLVED

<Igor> CLOSED (both for hosts and templates)

Error message should be more descriptive.

(10). ERROR: Import failed
Details: Cannot find screen "Zabbix server" used in screen "screen1".

Error appears when trying to import xml file with exported screen "screen1" that contains another screen "Zabbix server" inside it.
In the xml file there is such screen_item with name="Zabbix server", but import is not working.

<Vedmak> RESOLVED

<Igor> CLOSED

(11). ERROR: Import failed
Details: No permissions to referred object or it does not exist!

This error occur when trying to import screen in which there is map from another host and also in case when there are graphs/simple graphs from the same /another host.

<Vedmak> RESOLVED

<Igor> CLOSED

(12). ERROR: Import failed
Details: Cannot find map "map3" used in map map1".

Error occurs because map "map3" does not exist any more (has been deleted from the config). In xml file there are no configuration of that map "map3".

The same problem also appears for screens: when in one screen there is another screen, will appear the following error:

ERROR: Import failed
Cannot find screen "screen2" used in screen "screen1".

<Igor> For this problem has been created separate issue ZBX-4723.

(13). When importing xml file from 1.8 (v.1.8.9rc1) to 2.0, in the Details appears the following message:

Imported successfully
Details: No permission for Template [abc]

In the result host and template has not been created.

<Igor> CLOSED, there was no such template on the destination host.

(14). When importing xml file from 1.8 (v.1.8.9rc1) into 1.9.10 appears the following error:

ERROR: Import failed
Updated: Item "agent.ping" on "H3".
Updated: Item "snmpv1_item" on "H3".
Created: Item "db_item" on "H3".
Created: Item "2_snmpv3 item" on "H3".
Created: Item "1_snmpv2 item" on "H3".
Updated: Item "key2" on "H3".
Updated: Item "Outgoing traffic on interface $1" on "H3".
Updated: Item "proc.num[apache2,,]" on "H3".
Created: Item "ssh item" on "H3".
No interface found.

<Vedmak> RESOLVED

<Igor> CLOSED, this occurred when importing IPMI items.

(15) I think the calls to CItemGeneral::checkExistingItems() should be moved from createReal() to checkInput()

<Vedmak> agree, RESOLVED

<pavels> I don't think we need two separate methods, it can be implemented in one. Just check if the passed item has an "itemid" field, if it does - check that it's itemid is different from the existing items. See CUserMacro::checkIfHostMacrosDontRepeat() as an example.

<Vedmak> RESOLVED

<pavels> CLOSED.

(16) The new code really needs more comments.

<pavels> A couple of "TODO: comment:" comments left in CConfigurationExport.php

<Vedmak> RESOLVED

<pavels> CLOSED.

(17). After importing xml file with value mappings from 1.8.9rc1 into 1.9.10, value mapping will be not created, but in the exported xml file value mapping exists.

<Vedmak> in 1.8 we have incorrect value map reference, export has real db id which is incorrect. From 2.0 -> 2.0 should work.

<Igor> Import / export 2.0->2.0 with valuemaps is working fine. In v1.8.x we need to fix issue devoted to valuemaps in v1.8.x: ZBX-4723

(18). Screen import 1.8 ->2.0:

ERROR: Import failed
No host group ID provided for screen element.

In the xml file there are really no "hostgroupid" element.
Can provide export xml file.

<Igor> Fixed in trunk, CLOSED

(19) the CXmlImportReader::read() method has old translation strings.

<Vedmak> RESOLVED

<pavels> CLOSED

(20). Does not directly relates to import/export, BUT in dev branch ZBX-3531, when using dynamic item in the screen, there is not possible to set checkbox "Dynamic item" to the "checked" state, after saving, it will be reset to the "unchecked" state and in the xml file always will be "0" value: <dynamic>0</dynamic>
If I in the xml file set dynamic=1 and then import such xml file, then item will be dynamic.

But in trunk branch can check / un-check this button and save screen configuration, but in trunk in the result xml file there are NO parameter "dynamic" at all.

Similar to ZBX-4702.

<Igor> In the latest trunk rev #25871, option "Dynamic item" always will be checked, not possible to uncheck it. Problem with screen cell config form. This will be fixed in trunk under the issue ZBX-4702.

(21) CConfigurationImport::processImages() performs API result checks which are unnecessary since we are expecting the API to throw exceptions.

<Vedmak> RESOLVED

<pavels> CLOSED.

(22) Shouldn't icon maps and other stuff be resolved through the CImportReferencer instead of plain API calls in CConfigurationImport::processMaps()

<Vedmak> RESOLVED

<pavels> CLOSED.

(23) Shouldn't there be something under the SYSMAP_ELEMENT_TYPE_IMAGE case in CConfigurationImport::processMaps()?

<Vedmak> No, it shouldn't be there at all RESOLVED

<pavels> CLOSED.

(24) I think "missed" and "exists" is a poor choice for option names, it's really unclear what they mean when you look at the code. I suggest you rename them to "add" and "update" respectfully.

<Vedmak> "add" and "update" are not much better imo, because it's not clear what will be added and what updated. Probably best would be "addMissing" "updateExisting", what do you think?

<pavels> Yes, that will work too.

<Vedmak> RESOLVED

<pavels> CLOSED.

(25) Shouldn't CConfigurationImport::processTemplateScreens() check for screen options before saving the objects?

<Vedmak> added separate rules for template screens

<pavels> The "template_screens", "discoveryrules" and "template_linkages" options should be converted to camel case.

<Vedmak> RESOLVED

<pavels> CLOSED.

(26). Now, when using rev #25859 from dev branch ZBX-3531 and when importing host, appears the following error:

ERROR: Import failed

Illegal offset type [include\classes\import\CConfigurationImport.php:242]
Illegal offset type [include\classes\import\formatters\C20ImportFormatter.php:209]
Illegal offset type [include\classes\import\CConfigurationImport.php:509]
Illegal offset type in isset or empty [include\classes\import\CImportReferencer.php:70]
trim() expects parameter 1 to be string, array given [api\classes\CHost.php:1326]
No groups for host "Array".

<Vedmak> RESOLVED

<Igor> CLOSED

(27) CConfigurationExportBuilder::formatMacros() should use order_macros() instead of order_result() for sorting macros. May this problems occurs in some other places as well.

<Vedmak> RESOLVED

<pavels> CLOSED.

(28) I guess the old export code can be removed from zbxXML.

<Vedmak> RESOLVED

<pavels> You could also me zbxXML to a separate file.

<pavels> CLOSED.

(29) The ArrayHelper class should be moved to a separate file in the include/classes/helpers folder.

<Vedmak> RESOLVED

<pavels> CLOSED.

(30) CConfigurationImport::import() should now throw Exceptions inside a try/catch clause.

<Vedmak> RESOLVED

<pavels> CLOSED.

(31) ERROR: Import failed

Details:
Undefined index: templates [include\classes\import\CConfigurationImport.php:198]Invalid argument supplied for foreach() [include\classes\import\CConfigurationImport.php:198]Updated: Item "jmx[“java.lang:type=Memory”,”HeapMemoryUsage.used”]" on "T_jmx".Undefined index: flags [api\classes\CItemGeneral.php:590]Item with key "jmx[“java.lang:type=Memory”,”HeapMemoryUsage.used”]" already exists on "test_ZBX-4552" as an item.

Error occurs when trying to import template with jmx item (T_jmx:jmx[“java.lang:type=Memory”,”HeapMemoryUsage.used”]) second time.

<Vedmak> RESOLVED

<Igor> CLOSED, can not reproduce such error any more.

(32) New problem appears when trying to update item in the template linked to the host:

ERROR: Cannot update item

Details:
Updated: Item "agent.ping" on "T_agent".
Undefined index: flags [api\classes\CItemGeneral.php:590]
Item with key "agent.ping" already exists on "test_ZBX-4552" as an item. [CItem.update -> CItem.inherit -> CItemGeneral.prepareInheritedItems -> CItemGeneral.errorInheritFlags]

<Vedmak> RESOLVED

<Igor> CLOSED

(33) Error "Undefined index: templates [include\classes\class.cpagefilter.php:206]" in the bottom of the Conf->Hosts->Triggers page after updating trigger in the template, but trigger has been updated successfully.

<Vedmak> RESOLVED

<Igor> CLOSED, but appeared new problem, please see below

(34) Warning "Use of undefined constant S_GRAPHS_BIG - assumed 'S_GRAPHS_BIG' [graphs.php:405]" in the bottom of the Configuration->Templates->Graphs report, also after "Configuration of graphs" record appears non-replaced valuable:

S_GRAPHS_BIG
Group Host
Displaying 0 of 0 found

<Vedmak> RESOLVED

<Igor> CLOSED

(35) i'd suggest changing "Template linkages" to "Template linkage" - this word doesn't sound too well in plural, and the plural here isn't really needed

<Vedmak> RESOLVED

<richlv> CLOSED

(36) invalid input file gets me "Incorrect import reader type." - if that's our message, can we make it somewhat... more meaningful ?

<Vedmak> RESOLVED

<richlv> apparently resolution was changing the message to something like :
Unsupported import file extension "txt".

CLOSED

(37) dev branch rev 25917. see https://support.zabbix.com/secure/attachment/18321/template1b-cut7.xml
importing it fails with "Missing item [:] for host [Template_Windows2]", which doesn't seem to be a very valid item reference.

<Vedmak> Strange, for me in latest revision it gives message "Item [Template_Windows2:network[3]] does not exists.".
Anyway, how message should look like? 'Item "key" on host "host" does not exists for graph "graph".' or 'Graph "graph": missing item "key" on host "host".' or ...?

<Igor> For me the same "Item "Template_Windows2:network[3]" does not exists." error when trying to import this template.

<Vedmak> btw you have
<ymin_item_key>:</ymin_item_key>
<ymax_item_key>:</ymax_item_key>
in xml.

<richlv> oh, nice catch. i'd suggest messages that tell where the invalid item reference was found.
item "key", referenced in trigger "name" does not exist
item "key", referenced in graph "name" items, does not exist
item "key", referenced in graph "name" y axis maximum limit, does not exist
item "key", referenced in graph "name" y axis minimum limit, does not exist

any other location i missed ?

(feel free to adapt the messages to our style / better grammar )

<richlv> ok, after some discussion with Vedmak, new suggestions :
Trigger "name" item reference: item with key "key" on host "host" not found.
Graph "name" item reference: item with key "key" on host "host" not found.
Graph "name" y axis maximum limit: item with key "key" on host "host" not found.
Graph "name" y axis minimum limit: item with key "key" on host "host" not found.

<richlv> see (38), CLOSED

(38) see (37). error messages like these should provide context information - in this case, if we had both triggers and custom graphs in an xml, we wouldn't know which type is causing this message. the message should print out at least the context where we are encountering the data that it doesn't like.

<richlv> split out as ZBX-4853, CLOSED

(39) agent items in the exported xml still have things like allowed_hosts, snmp parameters, username/password, key and maybe other incorrect fields
trapper items have ipmi_sensor, snmp parameters, username/password, key and maybe other incorrect fields.

looks like all exported item fields should be reviewed

<Vedmak> All fields should be reviewed, but we decided that at first step we export everything. RESOLVED

<richlv> split out as ZBX-4854 - CLOSED

(40) documentation

<richlv> split out as ZBX-4855, CLOSED

(41) 'No icon for map element "New element"' - trailing dot is missing

<Vedmak> RESOLVED

<richlv> CLOSED

development branch is svn://svn.zabbix.com/dev/ZBX-3531

(42) When deleting graph from the host:

Deleted: Graph "graph1" on "test_ZBX-4552".
Use of undefined constant S_GRAPHS_DELETED - assumed 'S_GRAPHS_DELETED' [graphs.php:287]
Use of undefined constant S_CANNOT_DELETE_GRAPHS - assumed 'S_CANNOT_DELETE_GRAPHS' [graphs.php:287]

But in the result graph has been deleted.

<Vedmak> RESOLVED

<Igor> CLOSED

(43) In CConfigurationImport replace static variables with object properties.

<Vedmak> RESOLVED

<pavels> CLOSED.

(44) When importing xml with host configuration with valuemap definition, appears the following error: (can be visible in the "Details" of the import process, although import was successful, host has been created, but value map has not been created):

Undefined index: valuemap [include\classes\import\CConfigurationImport.php:695]

<Vedmak> RESOLVED

<Igor> CLOSED

svn://svn.zabbix.com/trunk 26002

(45). At this moment (trunk rev #26007), after merging src files from this DEV branch to the trunk branch, exported files do not have correct names.
Earlier there was "zbx_screens_export.xml" for the screen export, "zbx_hosts_export.xml" for host export, "zbx_templates_export.xml" for template export, BUT now for all objects there will be created files with "zbx_export.xml" title.
Before merging this was working fine.

<Vedmak> RESOLVED

<Igor> CLOSED, now in dev branch we will have files with names like zbx_export_hosts.xml, zbx_export_templates.xml, zbx_export_screens.xml, zbx_export_maps.xml.

(46) [GUI]
Errors in action configuration form.

<Vedmak> RESOLVED

<Igor> CLOSED, now there are no anymore undefined index errors In Conf->Actions report.
<Eduard> CLOSED

there are several still open sub-problems, reopening

(47) S_GRAPH_TEMPLATE_HOST_CANNOT_OTHER_ITEMS_HOSTS_SMALL was removed from the old english locale file, but it's still used in api/classes/CGraphPrototype.php

<Vedmak> fixed in rev. 26318.

<richlv> CLOSED

(48) S_GRAPH_ITEM was removed from the old english locale file, but it's still used in popup_gitem.php

<Vedmak> fixed in rev. 26318.

<richlv> CLOSED

remaining subproblems have been split out in new issues, closing

Reopen to rename issue.