Fix fping interval detection and confusing documentation of ICMP checks interval

XMLWordPrintable

    • Sprint 67 (Aug 2020), Sprint 68 (Sep 2020)
    • 4

      Steps to reproduce:
      #open https://www.zabbix.com/documentation/current/manual/config/items/itemtypes/simple_checks:

      1. open /var/log/zabbix/zabbix_server.log:
        5198:20200529:191836.432 item "xxxxxxxx:icmppingloss[,100,20,50,500]" became not supported: fping failed: /usr/sbin/fping: You need i >= 10, p >= 20, r < 20, and t >= 50
        5198:20200529:191836.432 item "xxxxxxxx:icmppingloss[,100,20,50,500]" became not supported: fping failed: /usr/sbin/fping: You need i >= 10, p >= 20, r < 20, and t >= 50
      

      Problem: -i is set internally according to the ./src/libs/zbxicmpping/icmpping.c in get_interval_option:

       * Comments: starting with fping (4.x), the packets interval can be 0ms, 1ms, *
       *           otherwise minimum value is 10ms                                  *
       ******************************************************************************
      ...
      zbx_snprintf(tmp, sizeof(tmp), "%s -c1 -t50 -i0 %s", fping, dst);
      ...
      zbx_snprintf(tmp, sizeof(tmp), "%s -c1 -t50 -i1 %s", fping, dst);
      ...
              else
                   {
                      *value = 10;
      

      Expected:
      Interval should be recalculated if for example fping chnaged version from 4.X to 3.X and server was not restarted.
      Correct documentation with notes about interval used and how it's calculated.

            Assignee:
            dimir
            Reporter:
            Edgar Akhmetshin
            Team I
            Votes:
            1 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: